All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ross Burton" <ross@burtonini.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 7/7] oeqa/target/ssh: don't assume target_dumper is set
Date: Fri, 10 Sep 2021 11:20:50 +0100	[thread overview]
Message-ID: <20210910102050.1266413-7-ross.burton@arm.com> (raw)
In-Reply-To: <20210910102050.1266413-1-ross.burton@arm.com>

The target_dumper property is only set by the QemuTarget subclass, so
assign a default value and check it isn't None before calling it.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/lib/oeqa/core/target/ssh.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/lib/oeqa/core/target/ssh.py b/meta/lib/oeqa/core/target/ssh.py
index b61c7d141d9..8cd2966fa38 100644
--- a/meta/lib/oeqa/core/target/ssh.py
+++ b/meta/lib/oeqa/core/target/ssh.py
@@ -41,6 +41,7 @@ class OESSHTarget(OETarget):
             self.ssh = self.ssh + [ '-p', port ]
             self.scp = self.scp + [ '-P', port ]
         self._monitor_dumper = None
+        self.target_dumper = None
 
     def start(self, **kwargs):
         pass
@@ -99,7 +100,8 @@ class OESSHTarget(OETarget):
             if self.monitor_dumper:
                 self.monitor_dumper.dump_monitor()
         if status == 255:
-            self.target_dumper.dump_target()
+            if self.target_dumper:
+                self.target_dumper.dump_target()
             if self.monitor_dumper:
                 self.monitor_dumper.dump_monitor()
         return (status, output)
-- 
2.25.1


  parent reply	other threads:[~2021-09-10 10:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 10:20 [PATCH 1/7] testimage: TEST_SERVER_IP isn't mandatory Ross Burton
2021-09-10 10:20 ` [PATCH 2/7] testimage: pass the base image name to the target class Ross Burton
2021-09-10 10:20 ` [PATCH 3/7] oeqa/core/target: remove abstract decorations Ross Burton
2021-09-10 10:20 ` [PATCH 4/7] oeqa/core/target: move server_ip to superclass Ross Burton
2021-09-10 10:20 ` [PATCH 5/7] oeqa/core/target: remove server port parameter Ross Burton
2021-09-10 10:20 ` [PATCH 6/7] oeqa/core/target: add target_ip to superclass Ross Burton
2021-09-10 10:20 ` Ross Burton [this message]
2021-09-10 12:21 ` [OE-core] [PATCH 1/7] testimage: TEST_SERVER_IP isn't mandatory Ross Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210910102050.1266413-7-ross.burton@arm.com \
    --to=ross@burtonini.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.