All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tilak Tangudu <tilak.tangudu@intel.com>,
	Imre Deak <imre.deak@intel.com>
Subject: [Intel-gfx] [PATCH 2/3] drm/i915: Disallow D3Cold.
Date: Fri, 10 Sep 2021 13:44:46 -0400	[thread overview]
Message-ID: <20210910174447.289750-2-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <20210910174447.289750-1-rodrigo.vivi@intel.com>

During runtime or s2idle suspend and resume cases on discrete cards,
if D3Cold is really achieved, we will blow everything up and
freeze the machine because we are not yet handling the pci states
properly.

On Integrated it simply doesn't matter because D3hot is the maximum
that we will get anyway, unless the system is on S3/S4 and our power
is cut.

Let's put this hammer for now everywhere. So we can work to enable
the auto-suspend by default without blowing up the world.

Then, this should be removed when we finally fix the D3Cold flow.

Cc: Tilak Tangudu <tilak.tangudu@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index a40b5d806321..086a9a475ce8 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -301,6 +301,7 @@ static void sanitize_gpu(struct drm_i915_private *i915)
  */
 static int i915_driver_early_probe(struct drm_i915_private *dev_priv)
 {
+	struct pci_dev *pdev = to_pci_dev(dev_priv->drm.dev);
 	int ret = 0;
 
 	if (i915_inject_probe_failure(dev_priv))
@@ -331,6 +332,13 @@ static int i915_driver_early_probe(struct drm_i915_private *dev_priv)
 	if (ret < 0)
 		return ret;
 
+	/*
+	 * FIXME: Temporary hammer to avoid freezing the machine on our DGFX
+	 * This should be totally removed when we handle the pci states properly
+	 * on runtime PM and on s2idle cases.
+	 */
+	pci_d3cold_disable(pdev);
+
 	ret = vlv_suspend_init(dev_priv);
 	if (ret < 0)
 		goto err_workqueues;
-- 
2.31.1


  reply	other threads:[~2021-09-10 17:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 17:44 [Intel-gfx] [PATCH 1/3] drm/i915/runtime_pm: Consolidate runtime_pm functions Rodrigo Vivi
2021-09-10 17:44 ` Rodrigo Vivi [this message]
2021-09-13 10:52   ` [Intel-gfx] [PATCH 2/3] drm/i915: Disallow D3Cold Gupta, Anshuman
2021-09-13 18:48     ` Vivi, Rodrigo
2021-09-10 17:44 ` [Intel-gfx] [PATCH 3/3] drm/i915: Enable runtime pm autosuspend by default Rodrigo Vivi
2021-09-13 10:57   ` Gupta, Anshuman
2021-09-13 18:49     ` Vivi, Rodrigo
2021-09-10 18:10 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/runtime_pm: Consolidate runtime_pm functions Patchwork
2021-09-10 18:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-10 19:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-09-10 22:06 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/runtime_pm: Consolidate runtime_pm functions (rev2) Patchwork
2021-09-10 22:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-11  0:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210910174447.289750-2-rodrigo.vivi@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tilak.tangudu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.