From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C241C433F5 for ; Fri, 10 Sep 2021 20:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 551B961209 for ; Fri, 10 Sep 2021 20:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234218AbhIJUuP (ORCPT ); Fri, 10 Sep 2021 16:50:15 -0400 Received: from netrider.rowland.org ([192.131.102.5]:46007 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S233733AbhIJUuO (ORCPT ); Fri, 10 Sep 2021 16:50:14 -0400 Received: (qmail 50185 invoked by uid 1000); 10 Sep 2021 16:49:01 -0400 Date: Fri, 10 Sep 2021 16:49:01 -0400 From: Alan Stern To: cristian.birsan@microchip.com Cc: gregkh@linuxfoundation.org, nicolas.ferre@microchip.com, ada@thorsis.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] USB: host: ehci-atmel: Add support for HSIC phy Message-ID: <20210910204901.GA50170@rowland.harvard.edu> References: <20210910163842.1596407-1-cristian.birsan@microchip.com> <20210910163842.1596407-3-cristian.birsan@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210910163842.1596407-3-cristian.birsan@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 10, 2021 at 07:38:42PM +0300, cristian.birsan@microchip.com wrote: > From: Cristian Birsan > > Add support for USB Host High Speed Port HSIC phy. > > Signed-off-by: Cristian Birsan > --- Acked-by: Alan Stern > drivers/usb/host/ehci-atmel.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c > index e893467d659c..05d41fd65f25 100644 > --- a/drivers/usb/host/ehci-atmel.c > +++ b/drivers/usb/host/ehci-atmel.c > @@ -18,6 +18,8 @@ > #include > #include > #include > +#include > +#include > > #include "ehci.h" > > @@ -25,6 +27,9 @@ > > static const char hcd_name[] = "ehci-atmel"; > > +#define EHCI_INSNREG(index) ((index) * 4 + 0x90) > +#define EHCI_INSNREG08_HSIC_EN BIT(2) > + > /* interface and function clocks */ > #define hcd_to_atmel_ehci_priv(h) \ > ((struct atmel_ehci_priv *)hcd_to_ehci(h)->priv) > @@ -154,6 +159,9 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev) > goto fail_add_hcd; > device_wakeup_enable(hcd->self.controller); > > + if (of_usb_get_phy_mode(pdev->dev.of_node) == USBPHY_INTERFACE_MODE_HSIC) > + writel(EHCI_INSNREG08_HSIC_EN, hcd->regs + EHCI_INSNREG(8)); > + > return retval; > > fail_add_hcd: > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C5C2C433F5 for ; Fri, 10 Sep 2021 20:51:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5947061209 for ; Fri, 10 Sep 2021 20:51:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5947061209 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lZ9spqTPC0eMyHkQiYErRCNy2+NDV+Dguh4hsC8S/Ss=; b=KPVtX0Rc4QjNwV Ed7g6ktrqxek/MhOs/9NArQoTLpsHxC/imdAIebsDz9SMK59BSErKWsJ9CG6rtJyUYePOo05hmBXt RBPMJpQEmAQKZjP0djrD8rtPQj1WIdNbO9gU2BJWBRd/mLUBeUvlUWqNvhYRfZEYC/uTP+VUiAnhh XzC6rO6/sgwyaJVwotyPzq6Lr76VdVog1R6KLkxT3KQsOJDBGZQmGz7I0K8ci8IsQ1XqJYwqe5kL6 qnbtiKEnJCJv+2x5Y0x2KAsFFI7pbsMjMCb26GnhdxFa51s14/3i72PkPP4vJQMmRmOfBNTVh/G/S HPWGRrA0D4isdusBUYnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOnSQ-00DnP4-0f; Fri, 10 Sep 2021 20:49:10 +0000 Received: from netrider.rowland.org ([192.131.102.5]) by bombadil.infradead.org with smtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOnSL-00DnNy-SO for linux-arm-kernel@lists.infradead.org; Fri, 10 Sep 2021 20:49:07 +0000 Received: (qmail 50185 invoked by uid 1000); 10 Sep 2021 16:49:01 -0400 Date: Fri, 10 Sep 2021 16:49:01 -0400 From: Alan Stern To: cristian.birsan@microchip.com Subject: Re: [PATCH 2/2] USB: host: ehci-atmel: Add support for HSIC phy Message-ID: <20210910204901.GA50170@rowland.harvard.edu> References: <20210910163842.1596407-1-cristian.birsan@microchip.com> <20210910163842.1596407-3-cristian.birsan@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210910163842.1596407-3-cristian.birsan@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210910_134906_103951_2C7CCA75 X-CRM114-Status: GOOD ( 14.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, ada@thorsis.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 10, 2021 at 07:38:42PM +0300, cristian.birsan@microchip.com wrote: > From: Cristian Birsan > > Add support for USB Host High Speed Port HSIC phy. > > Signed-off-by: Cristian Birsan > --- Acked-by: Alan Stern > drivers/usb/host/ehci-atmel.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c > index e893467d659c..05d41fd65f25 100644 > --- a/drivers/usb/host/ehci-atmel.c > +++ b/drivers/usb/host/ehci-atmel.c > @@ -18,6 +18,8 @@ > #include > #include > #include > +#include > +#include > > #include "ehci.h" > > @@ -25,6 +27,9 @@ > > static const char hcd_name[] = "ehci-atmel"; > > +#define EHCI_INSNREG(index) ((index) * 4 + 0x90) > +#define EHCI_INSNREG08_HSIC_EN BIT(2) > + > /* interface and function clocks */ > #define hcd_to_atmel_ehci_priv(h) \ > ((struct atmel_ehci_priv *)hcd_to_ehci(h)->priv) > @@ -154,6 +159,9 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev) > goto fail_add_hcd; > device_wakeup_enable(hcd->self.controller); > > + if (of_usb_get_phy_mode(pdev->dev.of_node) == USBPHY_INTERFACE_MODE_HSIC) > + writel(EHCI_INSNREG08_HSIC_EN, hcd->regs + EHCI_INSNREG(8)); > + > return retval; > > fail_add_hcd: > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel