From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84AFCC433F5 for ; Fri, 10 Sep 2021 21:18:42 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C97D3611BF for ; Fri, 10 Sep 2021 21:18:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C97D3611BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A184983757; Fri, 10 Sep 2021 23:18:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="dHycdWOb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 248D383752; Fri, 10 Sep 2021 23:18:37 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7A1F08375A for ; Fri, 10 Sep 2021 23:18:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id 22so3595513qkg.2 for ; Fri, 10 Sep 2021 14:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Budk0XYvIVc7YidQfQ1oglxC5fvonFkAyBPBeHsL4CI=; b=dHycdWOb9QGepXN6CRNbMiHlDU4CItiAACC2K5n8o1ldny1YBONdRycihRVjVnX2ls bnDPk8vSof0E9Cf4ExzHRzDfPwgFseBsCrqXtZg0a0Qf/EhOhVtskOZDpOmKMYb4T716 FRpx1IBCY7EczOxCAsSpEOn5mXM3USOhupwac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Budk0XYvIVc7YidQfQ1oglxC5fvonFkAyBPBeHsL4CI=; b=f1s9PhVgfkgld7RMIcGzUFlAAi/QKWpykABWJ1ZAcnXYJBqgpsnSGHDxgrdvp/+78W 3nNDhaRQN5AAyrXWzWq3dGqdWJdsk7/zMZxHjqoz+9IoC7u+Ga18xRAAE1+r/HIIjiN9 Hse4S1FzQPCo8S2EtyCPzHsQcdV1ZWneI3D1J31yV1BzHOYm4jwzhNugIQ2bo+o8TrF+ xglvvlYFp/0PQBEmfOfOJkfrk0yMtI2OP5z6h2Ny7L5J86AL+O7rs3U4o5+toe5ekRjH 9m92h3F/XJ3aggNE0gNU0/NZWc2cZtFrpjq/R0v7MGcTmvqn6OT2JDnqELCiMqoF/njS 2/HQ== X-Gm-Message-State: AOAM531TZ+TmlHuRRMWDduwIoWyCjFJwxOtTrVlcewODayTBptO4gS+p lNUeULw1uvHbhvMOG6EOGp8GVw== X-Google-Smtp-Source: ABdhPJzd5VekTX4qGyuiQeNgFj9XsyLBZa0WHT2nuaIpSZ+nXLG1mQBLczpoMLuEHIGlwOI1sfx29g== X-Received: by 2002:a37:2ec1:: with SMTP id u184mr9728640qkh.500.1631308711314; Fri, 10 Sep 2021 14:18:31 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-55fd-c014-b2c6-676a.res6.spectrum.com. [2603:6081:7b01:cbda:55fd:c014:b2c6:676a]) by smtp.gmail.com with ESMTPSA id i14sm3935274qtr.2.2021.09.10.14.18.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Sep 2021 14:18:30 -0700 (PDT) Date: Fri, 10 Sep 2021 17:18:28 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?iso-8859-1?Q?Beh=FAn?= , u-boot@lists.denx.de Subject: Re: [PATCH 00/11] Reduce usage of timestamp macros Message-ID: <20210910211828.GC12964@bill-the-cat> References: <20210802131838.21097-1-pali@kernel.org> <20210901205909.GA23592@bill-the-cat> <20210901210545.4mbkattfc4m7nupl@pali> <20210901211706.GR858@bill-the-cat> <20210901212854.dabsvrkga4xdqxdf@pali> <20210901213357.GS858@bill-the-cat> <20210901214452.lxyy7cqjn6fkbghk@pali> <20210901214957.ypd6ztgdsoxhd5l6@pali> <20210910205618.ij56grpj4ycrfzzd@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="b3HDrgTSPI5RNpIl" Content-Disposition: inline In-Reply-To: <20210910205618.ij56grpj4ycrfzzd@pali> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --b3HDrgTSPI5RNpIl Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 10, 2021 at 10:56:18PM +0200, Pali Roh=E1r wrote: > On Wednesday 01 September 2021 23:49:57 Pali Roh=E1r wrote: > > On Wednesday 01 September 2021 23:44:52 Pali Roh=E1r wrote: > > > On Wednesday 01 September 2021 17:33:57 Tom Rini wrote: > > > > On Wed, Sep 01, 2021 at 11:28:54PM +0200, Pali Roh=E1r wrote: > > > > > On Wednesday 01 September 2021 17:17:06 Tom Rini wrote: > > > > > > On Wed, Sep 01, 2021 at 11:05:45PM +0200, Pali Roh=E1r wrote: > > > > > > > On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > > > > > > > > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Roh=E1r wrot= e: > > > > > > > >=20 > > > > > > > > > Including timestamp.h (either directly or transitionally)= cause build > > > > > > > > > system to recompile binaries at every 'make' run. This ha= s disadvantage > > > > > > > > > in U-Boot development as for every small change 'make' re= compiles lot of > > > > > > > > > other irrelevant files which were not touched / changed. > > > > > > > > >=20 > > > > > > > > > This patch series eliminate transitional / indirect usage= of > > > > > > > > > timestamp.h by removing unneeded inclusion of header file= s, moving > > > > > > > > > timestamp values from macros to global variables, etc... > > > > > > > > >=20 > > > > > > > > > After these patches, U-Boot tools are not recompiled by e= very 'make' run, > > > > > > > > > which decrease time for incremental U-Boot recompilation. > > > > > > > > >=20 > > > > > > > > > Please test these patches, specially m68k and powerpc par= ts as I do not > > > > > > > > > have any of these boards. > > > > > > > > >=20 > > > > > > > > > Patch series depend on this patch (now marked as accepted= ): > > > > > > > > > http://patchwork.ozlabs.org/project/uboot/patch/202107101= 11001.32325-1-pali@kernel.org/ > > > > > > > > >=20 > > > > > > > > > Pali Roh=E1r (11): > > > > > > > > > Remove #include from files which do not n= eed it > > > > > > > > > Remove #include from files which do not nee= d it > > > > > > > > > efi_loader: Use directly version_string variable > > > > > > > > > version: Move version_string[] from version.h to versio= n_string.h > > > > > > > > > m68k: mcf: Remove overloading version_string > > > > > > > > > version: Put version_string[] variable into section > > > > > > > > > .text_version_string > > > > > > > > > powerpc: mpc: Put U-Boot version string at correct plac= e by linker > > > > > > > > > script > > > > > > > > > version: Do not make version_string[] variable as a weak > > > > > > > > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME fro= m debug log > > > > > > > > > version: Remove global macro U_BOOT_VERSION_STRING from= version.h > > > > > > > > > Remove including timestamp.h in version.h > > > > > > > >=20 > > > > > > > > So, looking at https://source.denx.de/u-boot/u-boot/-/pipel= ines/8948 > > > > > > > > this fails to build for at least qemu-ppce500 and xtfpga. = Over in=20 > > > > > > > > doc/develop/ci_testing.rst we document how to run a world b= uild. Please > > > > > > > > fix these build errors and re-submit, thanks. > > > > > > >=20 > > > > > > > Already happened about month ago > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/202108081120= 38.7942-1-pali@kernel.org/ > > > > > > >=20 > > > > > > > As stated, following build command now passes: > > > > > > > make CROSS_COMPILE=3Dpowerpc-linux-gnu- MCR3000_defconfig u-b= oot.bin > > > > > >=20 > > > > > > OK, I'll make sure to grab that. Note that xtfpga isn't PowerP= C... > > > > >=20 > > > > > I saw only error https://source.denx.de/u-boot/u-boot/-/jobs/3166= 01 and > > > > > this should be fixed above patch. At least I got similar error for > > > > > MCR3000_defconfig with new gcc before that. > > > > >=20 > > > > > But now after scrolling down I see that second xtfpga error > > > > > https://source.denx.de/u-boot/u-boot/-/jobs/316614 > > > > > But seems that in this UI is error log truncated. I see only > > > > >=20 > > > > > +xtensa-dc233c-elf-ld.bfd: section .text_version_string LMA [0000= 0000fe021584,00000000fe0215c7] overlaps section .u_boot_list LMA [00000000f= e021584,00000000fe021e6b] > > > > >=20 > > > > > Is there a way how to show full build log? And which defconfig and > > > > > compiler is used? Because that error does not help me what is wro= ng > > > > > here... > > > >=20 > > > > That's the full error log, from the linker, I believe. It's the xt= fpga > > > > config for the xtensa architecture. It's one of the few that build= man > > > > won't fetch a good toolchain for so you'll want to look at > > > > tools/docker/Dockerfile and see we get it from > > > > https://github.com/foss-xtensa/toolchain/releases/download/2020.07/= x86_64-2020.07-xtensa-dc233c-elf.tar.gz > > > > if you don't have the CI builder container itself handy already. > > >=20 > > > So this is the only other build which failed, right? I suspect that > > > there is some other bug in xtfpga linker script, that it missed > > > specifying wildcard sections and this change triggered it. > > >=20 > > > I will try to look at it. > >=20 > > Just a quick look... > > https://source.denx.de/u-boot/u-boot/-/blob/master/arch/xtensa/cpu/u-bo= ot.lds#L78 > > Probably it is needed to specify .text_version_string section here, like > > is specified .text section there. >=20 > I really do not know what is the memory layout of u-boot image for this > platform, but could not something like this help? >=20 > --- arch/xtensa/cpu/u-boot.lds 2021-09-10 22:50:51.501324477 +0200 > +++ arch/xtensa/cpu/u-boot.lds 2021-09-10 22:53:55.271410047 +0200 > @@ -47,6 +47,7 @@ SECTIONS > RELOCATE2(DoubleExceptionVector,literal); > RELOCATE2(DoubleExceptionVector,text); > RELOCATE1(text); > + RELOCATE1(text_version_string); > RELOCATE1(rodata); > RELOCATE1(data); > RELOCATE1(u_boot_list); > @@ -76,7 +77,8 @@ SECTIONS > __monitor_start =3D XTENSA_SYS_TEXT_ADDR; > =20 > SECTION_text(XTENSA_SYS_TEXT_ADDR, FOLLOWING(.DoubleExceptionVector.te= xt)) > - SECTION_rodata(ALIGN(16), FOLLOWING(.text)) > + SECTION_text_version_string(ALIGN(16), FOLLOWING(.text)) > + SECTION_rodata(ALIGN(16), FOLLOWING(.text_version_string)) > SECTION_u_boot_list(ALIGN(16), FOLLOWING(.rodata)) > SECTION_data(ALIGN(16), FOLLOWING(.u_boot_list)) > =20 >=20 > > > It is pity that in above gitlab build log is missing full command whi= ch > > > produced that error as in its arguments could be something interestin= g, > > > like path to linker script or compile flags... Seems likely, thanks for digging something out! --=20 Tom --b3HDrgTSPI5RNpIl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmE7y6QACgkQFHw5/5Y0 tyyhpgv+MC/lfFEhkfJ/VUD/L5yEdGa1l6XgtAJvo0YHvn6f9vQfxxwDDCLtOWIW UfA1nADcN+KBxmHRhzHrGTJpLoUfhoVPebcitzwN1FUcIeHkyqmclEn7sK1d4W/x 67VFdH7XzjvbAe1Pj+3rAI9Y/8c9Wav7TQYGwPbZS6ga8yyLGbCuG9/S1l4ojcyT bHrdNFUkmvM1cU0duF6ZOEraG0cuY1lNyrnX+7HKIT1+a/JnY4WVtj9fgGY5bemS 8m/hxYic9h+jpVHeV1ArwuCLORwtQtQO+e4Ligyu92qnrYk3hGhftogt7Kx/Z85a qkK3TySrwmQwgKkzIAYSrVzXcE5+2pzorXew3yyjawFbssUsUh0GxE6aNuW8d8Kd 6TJeaFKstPEe1ci0DL8oDlBH7aL3xDBggCbnnCxc+gIcfDtfgx2O5pGMKJNMcLqa LvdaaxA28QX/2YfhkUsZQxOeS4Oq0qSWsBHgBCrrtCuDoXJybIqJ979vaMrVdYRb AbJZWxZN =kFAT -----END PGP SIGNATURE----- --b3HDrgTSPI5RNpIl--