All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: Simon Glass <sjg@chromium.org>, Rick Chen <rick@andestech.com>,
	Leo Yu-Chi Liang <ycliang@andestech.com>,
	u-boot@lists.denx.de
Subject: [PATCH 7/9] net: macb: Fix -Wint-to-pointer-cast warnings
Date: Sun, 12 Sep 2021 11:15:14 +0800	[thread overview]
Message-ID: <20210912031516.24885-7-bmeng.cn@gmail.com> (raw)
In-Reply-To: <20210912031516.24885-1-bmeng.cn@gmail.com>

The following warning is seen in macb.c in a 32-bit build:

  warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

Change to use dev_read_addr_index_ptr(), or cast with uintptr_t.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 drivers/net/macb.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 57ea45e2dc..fe14027b31 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -574,14 +574,9 @@ static int macb_phy_find(struct macb_device *macb, const char *name)
 #ifdef CONFIG_DM_ETH
 static int macb_sifive_clk_init(struct udevice *dev, ulong rate)
 {
-	fdt_addr_t addr;
 	void *gemgxl_regs;
 
-	addr = dev_read_addr_index(dev, 1);
-	if (addr == FDT_ADDR_T_NONE)
-		return -ENODEV;
-
-	gemgxl_regs = (void __iomem *)addr;
+	gemgxl_regs = dev_read_addr_index_ptr(dev, 1);
 	if (!gemgxl_regs)
 		return -ENODEV;
 
@@ -1383,7 +1378,7 @@ static int macb_eth_probe(struct udevice *dev)
 		macb->phy_addr = ofnode_read_u32_default(phandle_args.node,
 							 "reg", -1);
 
-	macb->regs = (void *)pdata->iobase;
+	macb->regs = (void *)(uintptr_t)pdata->iobase;
 
 	macb->is_big_endian = (cpu_to_be32(0x12345678) == 0x12345678);
 
@@ -1444,7 +1439,7 @@ static int macb_eth_of_to_plat(struct udevice *dev)
 {
 	struct eth_pdata *pdata = dev_get_plat(dev);
 
-	pdata->iobase = (phys_addr_t)dev_remap_addr(dev);
+	pdata->iobase = (uintptr_t)dev_remap_addr(dev);
 	if (!pdata->iobase)
 		return -EINVAL;
 
-- 
2.25.1


  parent reply	other threads:[~2021-09-12  3:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12  3:15 [PATCH 1/9] cache: sifive: Fix -Wint-to-pointer-cast warning Bin Meng
2021-09-12  3:15 ` [PATCH 2/9] clk: " Bin Meng
2021-09-15  3:46   ` Leo Liang
2021-09-12  3:15 ` [PATCH 3/9] gpio: " Bin Meng
2021-09-15  3:57   ` Leo Liang
2021-09-12  3:15 ` [PATCH 4/9] i2c: ocores: " Bin Meng
2021-09-15  4:39   ` Leo Liang
2021-09-12  3:15 ` [PATCH 5/9] dm: core: Add a new API devfdt_get_addr_index_ptr() Bin Meng
2021-09-15  7:21   ` Leo Liang
2021-09-30  4:09   ` Simon Glass
2021-09-12  3:15 ` [PATCH 6/9] dm: Provide dev_read_addr_index_ptr() wrapper Bin Meng
2021-09-15  7:23   ` Leo Liang
2021-09-30  4:09   ` Simon Glass
2021-09-12  3:15 ` Bin Meng [this message]
2021-09-13 18:40   ` [PATCH 7/9] net: macb: Fix -Wint-to-pointer-cast warnings Ramon Fried
2021-09-12  3:15 ` [PATCH 8/9] ram: sifive: " Bin Meng
2021-09-15  7:25   ` Leo Liang
2021-09-12  3:15 ` [PATCH 9/9] board: sifive: Fix -Wint-to-pointer-cast warning Bin Meng
2021-09-15  7:26   ` Leo Liang
2021-09-15  3:40 ` [PATCH 1/9] cache: " Leo Liang
2021-10-11  3:14   ` Bin Meng
2021-10-12  7:43     ` Leo Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210912031516.24885-7-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=rick@andestech.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.