All of lore.kernel.org
 help / color / mirror / Atom feed
* [mcgrof:20210910-sysfs-generic-deadlock-fix 3/10] lib/test_sysfs.c:148:26: sparse: sparse: symbol 'first_test_dev' was not declared. Should it be static?
@ 2021-09-12  2:46 ` kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-09-12  2:46 UTC (permalink / raw)
  To: Luis Chamberlain; +Cc: kbuild-all, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git 20210910-sysfs-generic-deadlock-fix
head:   45e10e4ef8d083225f3fcd0157b447f2de52b5ed
commit: ed2111f617d4365d6a7a5032ae2002e434d901bc [3/10] selftests: add tests_sysfs module
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/commit/?id=ed2111f617d4365d6a7a5032ae2002e434d901bc
        git remote add mcgrof https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git
        git fetch --no-tags mcgrof 20210910-sysfs-generic-deadlock-fix
        git checkout ed2111f617d4365d6a7a5032ae2002e434d901bc
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> lib/test_sysfs.c:148:26: sparse: sparse: symbol 'first_test_dev' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41895 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [mcgrof:20210910-sysfs-generic-deadlock-fix 3/10] lib/test_sysfs.c:148:26: sparse: sparse: symbol 'first_test_dev' was not declared. Should it be static?
@ 2021-09-12  2:46 ` kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-09-12  2:46 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1402 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git 20210910-sysfs-generic-deadlock-fix
head:   45e10e4ef8d083225f3fcd0157b447f2de52b5ed
commit: ed2111f617d4365d6a7a5032ae2002e434d901bc [3/10] selftests: add tests_sysfs module
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/commit/?id=ed2111f617d4365d6a7a5032ae2002e434d901bc
        git remote add mcgrof https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git
        git fetch --no-tags mcgrof 20210910-sysfs-generic-deadlock-fix
        git checkout ed2111f617d4365d6a7a5032ae2002e434d901bc
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> lib/test_sysfs.c:148:26: sparse: sparse: symbol 'first_test_dev' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41895 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [RFC PATCH mcgrof] selftests: first_test_dev can be static
  2021-09-12  2:46 ` kernel test robot
@ 2021-09-12  2:46   ` kernel test robot
  -1 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-09-12  2:46 UTC (permalink / raw)
  To: Luis Chamberlain; +Cc: kbuild-all, linux-kernel

lib/test_sysfs.c:148:26: warning: symbol 'first_test_dev' was not declared. Should it be static?

Fixes: ed2111f617d4 ("selftests: add tests_sysfs module")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 test_sysfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_sysfs.c b/lib/test_sysfs.c
index f8935bd678b12..273fc3f397401 100644
--- a/lib/test_sysfs.c
+++ b/lib/test_sysfs.c
@@ -145,7 +145,7 @@ struct sysfs_test_device {
 	int y;
 };
 
-struct sysfs_test_device *first_test_dev;
+static struct sysfs_test_device *first_test_dev;
 
 static struct miscdevice *dev_to_misc_dev(struct device *dev)
 {

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [RFC PATCH mcgrof] selftests: first_test_dev can be static
@ 2021-09-12  2:46   ` kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-09-12  2:46 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

lib/test_sysfs.c:148:26: warning: symbol 'first_test_dev' was not declared. Should it be static?

Fixes: ed2111f617d4 ("selftests: add tests_sysfs module")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 test_sysfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_sysfs.c b/lib/test_sysfs.c
index f8935bd678b12..273fc3f397401 100644
--- a/lib/test_sysfs.c
+++ b/lib/test_sysfs.c
@@ -145,7 +145,7 @@ struct sysfs_test_device {
 	int y;
 };
 
-struct sysfs_test_device *first_test_dev;
+static struct sysfs_test_device *first_test_dev;
 
 static struct miscdevice *dev_to_misc_dev(struct device *dev)
 {

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [mcgrof:20210910-sysfs-generic-deadlock-fix 3/10] lib/test_sysfs.c:148:26: sparse: sparse: symbol 'first_test_dev' was not declared. Should it be static?
@ 2021-09-12 21:32 ` kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-09-12 21:32 UTC (permalink / raw)
  To: Luis Chamberlain; +Cc: kbuild-all, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git 20210910-sysfs-generic-deadlock-fix
head:   45e10e4ef8d083225f3fcd0157b447f2de52b5ed
commit: ed2111f617d4365d6a7a5032ae2002e434d901bc [3/10] selftests: add tests_sysfs module
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/commit/?id=ed2111f617d4365d6a7a5032ae2002e434d901bc
        git remote add mcgrof https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git
        git fetch --no-tags mcgrof 20210910-sysfs-generic-deadlock-fix
        git checkout ed2111f617d4365d6a7a5032ae2002e434d901bc
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> lib/test_sysfs.c:148:26: sparse: sparse: symbol 'first_test_dev' was not declared. Should it be static?

vim +/first_test_dev +148 lib/test_sysfs.c

   147	
 > 148	struct sysfs_test_device *first_test_dev;
   149	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41895 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [mcgrof:20210910-sysfs-generic-deadlock-fix 3/10] lib/test_sysfs.c:148:26: sparse: sparse: symbol 'first_test_dev' was not declared. Should it be static?
@ 2021-09-12 21:32 ` kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-09-12 21:32 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git 20210910-sysfs-generic-deadlock-fix
head:   45e10e4ef8d083225f3fcd0157b447f2de52b5ed
commit: ed2111f617d4365d6a7a5032ae2002e434d901bc [3/10] selftests: add tests_sysfs module
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/commit/?id=ed2111f617d4365d6a7a5032ae2002e434d901bc
        git remote add mcgrof https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git
        git fetch --no-tags mcgrof 20210910-sysfs-generic-deadlock-fix
        git checkout ed2111f617d4365d6a7a5032ae2002e434d901bc
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> lib/test_sysfs.c:148:26: sparse: sparse: symbol 'first_test_dev' was not declared. Should it be static?

vim +/first_test_dev +148 lib/test_sysfs.c

   147	
 > 148	struct sysfs_test_device *first_test_dev;
   149	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41895 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-12 21:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-12  2:46 [mcgrof:20210910-sysfs-generic-deadlock-fix 3/10] lib/test_sysfs.c:148:26: sparse: sparse: symbol 'first_test_dev' was not declared. Should it be static? kernel test robot
2021-09-12  2:46 ` kernel test robot
2021-09-12  2:46 ` [RFC PATCH mcgrof] selftests: first_test_dev can be static kernel test robot
2021-09-12  2:46   ` kernel test robot
2021-09-12 21:32 [mcgrof:20210910-sysfs-generic-deadlock-fix 3/10] lib/test_sysfs.c:148:26: sparse: sparse: symbol 'first_test_dev' was not declared. Should it be static? kernel test robot
2021-09-12 21:32 ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.