All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
	netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [RFC PATCH net] net: dsa: flush switchdev workqueue before tearing down CPU/DSA ports
Date: Sun, 12 Sep 2021 19:19:13 +0300	[thread overview]
Message-ID: <20210912161913.sqfcmff77ldc3m5e@skbuf> (raw)
In-Reply-To: <5223b1d0-b55b-390c-b3d3-f6e6fa24d6d8@gmail.com>

On Sun, Sep 12, 2021 at 09:13:36AM -0700, Florian Fainelli wrote:
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> Did you post this as a RFC for a particular reason, or just to give
> reviewers some time?

Both.

In principle there's nothing wrong with what this patch does, only
perhaps maybe something with what it doesn't do.

We keep saying that a network interface should be ready to pass traffic
as soon as it's registered, but that "walk dst->ports linearly when
calling dsa_port_setup" might not really live up to that promise.

So while we do end up bringing all ports up at the end of
dsa_tree_setup_switches, I think for consistency we should do the same
thing there, i.e. bring the shared ports up first, then the user ports.
That way, the user ports should really be prepared to pass traffic as
soon as they get registered.

But I don't really know what kind of story to build around that to
include it as part of this patch, other than consistency. For teardown,
I think it is much more obvious to see an issue.

  reply	other threads:[~2021-09-12 16:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12 16:00 [RFC PATCH net] net: dsa: flush switchdev workqueue before tearing down CPU/DSA ports Vladimir Oltean
2021-09-12 16:13 ` Florian Fainelli
2021-09-12 16:19   ` Vladimir Oltean [this message]
2021-09-12 16:24     ` Florian Fainelli
2021-09-12 16:33       ` Vladimir Oltean
2021-09-13  2:06         ` Florian Fainelli
2021-09-13  2:12           ` Vladimir Oltean
2021-09-13  2:20             ` Florian Fainelli
2021-09-13 11:31               ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210912161913.sqfcmff77ldc3m5e@skbuf \
    --to=olteanv@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.