From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4B81C433EF for ; Sun, 12 Sep 2021 23:39:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B038D610CB for ; Sun, 12 Sep 2021 23:39:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236675AbhILXkT (ORCPT ); Sun, 12 Sep 2021 19:40:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234094AbhILXkS (ORCPT ); Sun, 12 Sep 2021 19:40:18 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A580C061574 for ; Sun, 12 Sep 2021 16:39:04 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1mPZ3s-00049t-Ip; Mon, 13 Sep 2021 01:39:00 +0200 Date: Mon, 13 Sep 2021 01:39:00 +0200 From: Florian Westphal To: Jeremy Sowden Cc: Pablo Neira Ayuso , Netfilter Devel Subject: Re: [PATCH nf] netfilter: ip6_tables: zero-initialize fragment offset Message-ID: <20210912233900.GN23554@breakpoint.cc> References: <20210912212433.45389-1-jeremy@azazel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210912212433.45389-1-jeremy@azazel.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Jeremy Sowden wrote: > ip6tables only sets the `IP6T_F_PROTO` flag on a rule if a protocol is > specified (`-p tcp`, for example). However, if the flag is not set, > `ip6_packet_match` doesn't call `ipv6_find_hdr` for the skb, in which > case the fragment offset is left uninitialized and a garbage value is > passed to each matcher. Fixes: f7108a20dee44 ("netfilter: xtables: move extension arguments into compound structure (1/6)" Reviewed-by: Florian Westphal