All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xu Yilun <yilun.xu@intel.com>
To: Tom Rix <trix@redhat.com>
Cc: Russ Weight <russell.h.weight@intel.com>,
	mdf@kernel.org, linux-fpga@vger.kernel.org,
	linux-kernel@vger.kernel.org, lgoncalv@redhat.com,
	hao.wu@intel.com, matthew.gerlach@intel.com
Subject: Re: [PATCH v15 5/6] fpga: image-load: create status sysfs node
Date: Mon, 13 Sep 2021 16:27:06 +0800	[thread overview]
Message-ID: <20210913082706.GB773070@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <ae637d01-b6c1-4b7f-a536-449e27c7711d@redhat.com>

On Sat, Sep 11, 2021 at 10:58:16AM -0700, Tom Rix wrote:
> 
> On 9/10/21 4:30 PM, Russ Weight wrote:
> > 
> > On 9/10/21 1:52 AM, Xu Yilun wrote:
> > > On Wed, Sep 08, 2021 at 07:18:45PM -0700, Russ Weight wrote:
> > > > Extend the FPGA Image Load class driver to include a status sysfs node that
> > > > can be viewed to determine from the command line if an image load is in
> > > > progress. Status will be one of: idle, starting, preparing, writing, or
> > > > programming.
> > > The FPGA_IMAGE_LOAD_STATUS ioctl already provides the progress info.
> > > Why we need 2 user interfaces for the same information?
> > Updates on Vista Creek can take up to 40 minutes. I thought it might
> > be helpful to have a simple way, from the command line, to verify
> > whether or not there is an image upload in progress. Do you agree? Or
> > do you think this is unnecessary? Should I remove it? Or save it for
> > a later patch (after the main patches have been accepted)?
> 
> I agree, there should not be two methods to doing the same thing.
> 
> I prefer the ioctl since it handles other cmd's as well.
> 
> The user has to use the ioctl to start the write so it would for more
> natural to use the ioctl over sysfs to the check the status
> 
> Remove it.
> 
> Make a strong case for it's need when/if you want to add it back later.

Yes, remove it. Not a strong use case for this interface now.

Thanks,
Yilun

  reply	other threads:[~2021-09-13  8:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09  2:18 [PATCH v15 0/6] FPGA Image Load (previously Security Manager) Russ Weight
2021-09-09  2:18 ` [PATCH v15 1/6] fpga: image-load: fpga image load class driver Russ Weight
2021-09-10  6:46   ` Xu Yilun
2021-09-10 20:47     ` Russ Weight
2021-09-09  2:18 ` [PATCH v15 2/6] fpga: image-load: enable image loads Russ Weight
2021-09-10  8:22   ` Xu Yilun
2021-09-10 23:18     ` Russ Weight
2021-09-13  6:48       ` Xu Yilun
2021-09-13  9:36         ` Xu Yilun
2021-09-21 19:08           ` Russ Weight
2021-09-09  2:18 ` [PATCH v15 3/6] fpga: image-load: signal eventfd when complete Russ Weight
2021-09-09  2:18 ` [PATCH v15 4/6] fpga: image-load: add status ioctl Russ Weight
2021-09-10  8:50   ` Xu Yilun
2021-09-10 23:23     ` Russ Weight
2021-09-11 18:12       ` Tom Rix
2021-09-13  8:24         ` Xu Yilun
2021-09-09  2:18 ` [PATCH v15 5/6] fpga: image-load: create status sysfs node Russ Weight
2021-09-10  8:52   ` Xu Yilun
2021-09-10 23:30     ` Russ Weight
2021-09-11 17:58       ` Tom Rix
2021-09-13  8:27         ` Xu Yilun [this message]
2021-09-09  2:18 ` [PATCH v15 6/6] fpga: image-load: enable cancel of image upload Russ Weight
2021-09-10 14:55   ` Xu Yilun
2021-09-10 23:38     ` Russ Weight
2021-09-11 13:13       ` Tom Rix
2021-09-13 10:00         ` Xu Yilun
2021-09-21 20:43           ` Russ Weight
     [not found] ` <20210912023739.4078-1-hdanton@sina.com>
2021-09-21 18:36   ` [PATCH v15 2/6] fpga: image-load: enable image loads Russ Weight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210913082706.GB773070@yilunxu-OptiPlex-7050 \
    --to=yilun.xu@intel.com \
    --cc=hao.wu@intel.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.gerlach@intel.com \
    --cc=mdf@kernel.org \
    --cc=russell.h.weight@intel.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.