From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C860C43217 for ; Mon, 13 Sep 2021 15:52:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E955D610A8 for ; Mon, 13 Sep 2021 15:52:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245412AbhIMPxe (ORCPT ); Mon, 13 Sep 2021 11:53:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:60768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244949AbhIMPxX (ORCPT ); Mon, 13 Sep 2021 11:53:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6E47660FC1; Mon, 13 Sep 2021 15:52:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631548326; bh=M8x3WoJty67LjoQsNC1A0PS9DP75fGoueCiDQ+i1TEU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Z7gsYlm6JRj3VhO7cu90aoVVlTnLuXv7EWIuiaKiNYC7oMsncjSnym3kJJnl4X+rV 05gIOfVYfZ9pYedV2SBjR71hms6PfMyQ2pHt4hMX0Fu+O61CWj+3BwlVe/FOsrk3Tl pGJM/qiI6cahYwLspBhfvMGiw2sl72PffO/Sppgkwl+3n9v1RjEnz70ogqaprUlfYf NfjXV94PeainCTvS6tzT6VOhFkWZi9lYQongjiNXYK7AdkS1Wbjl2s/E2/SiqAuLX3 KSvYsqexTVBnpxyd8frr/TLjwcFXXbgDNfQlgAHr+Qgc7wiiy8Bro+r/ZSHUONVQks 6xcDv5wonPiNw== Date: Mon, 13 Sep 2021 08:52:05 -0700 From: Jakub Kicinski To: zhenggy Cc: ncardwell@google.com, netdev@vger.kernel.org, edumazet@google.com, davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, ycheng@google.com, qitiepeng@chinatelecom.cn, wujianguo@chinatelecom.cn, liyonglong@chinatelecom.cn Subject: Re: [PATCH v3] tcp: fix tp->undo_retrans accounting in tcp_sacktag_one() Message-ID: <20210913085205.531d435a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1630314010-15792-1-git-send-email-zhenggy@chinatelecom.cn> References: <1630314010-15792-1-git-send-email-zhenggy@chinatelecom.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 30 Aug 2021 05:00:10 -0400 zhenggy wrote: > Commit 10d3be569243 ("tcp-tso: do not split TSO packets at retransmit > time") may directly retrans a multiple segments TSO/GSO packet without > split, Since this commit, we can no longer assume that a retransmitted > packet is a single segment. > > This patch fixes the tp->undo_retrans accounting in tcp_sacktag_one() > that use the actual segments(pcount) of the retransmitted packet. > > Before that commit (10d3be569243), the assumption underlying the > tp->undo_retrans-- seems correct. > > Fixes: 10d3be569243 ("tcp-tso: do not split TSO packets at retransmit time") > Please remove this empty line. There should be no empty lines between tags. > Signed-off-by: zhenggy Please fix the data on your system and repost. I'm pretty sure this wasn't posted on Aug 30th.