From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E12EC433F5 for ; Mon, 13 Sep 2021 12:09:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 615D160FBF for ; Mon, 13 Sep 2021 12:09:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239849AbhIMMKf (ORCPT ); Mon, 13 Sep 2021 08:10:35 -0400 Received: from foss.arm.com ([217.140.110.172]:57178 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239815AbhIMMKd (ORCPT ); Mon, 13 Sep 2021 08:10:33 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F0FEC31B; Mon, 13 Sep 2021 05:09:17 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.16.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4B58E3F59C; Mon, 13 Sep 2021 05:09:16 -0700 (PDT) Date: Mon, 13 Sep 2021 13:09:08 +0100 From: Mark Rutland To: cgel.zte@gmail.com Cc: catalin.marinas@arm.com, will@kernel.org, pcc@google.com, maz@kernel.org, peterz@infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lv Ruyi , Zeal Robot Subject: Re: [PATCH] arm64/kernel: remove duplicate include in process.c Message-ID: <20210913120908.GA9450@C02TD0UTHF1T.local> References: <20210902011126.29828-1-lv.ruyi@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210902011126.29828-1-lv.ruyi@zte.com.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 01, 2021 at 06:11:26PM -0700, cgel.zte@gmail.com wrote: > From: Lv Ruyi > > Remove all but the first include of linux/sched.h from process.c > > Reported-by: Zeal Robot > Signed-off-by: Lv Ruyi > --- > arch/arm64/kernel/process.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > index 19100fe8f7e4..1a1213cca173 100644 > --- a/arch/arm64/kernel/process.c > +++ b/arch/arm64/kernel/process.c > @@ -18,7 +18,6 @@ > #include > #include > #include > -#include > #include > #include > #include For the benefit of other reviewers, while it's not obvious from the patch context, arlier in the includes (which aren't currently sorted), there's a block with: | #include | #include | #include | #include ... and so this patch looks good to me: Acked-by: Mark Rutland IMO it would be nice to sort the includes if that's not too churny (but that should be a separate patch). Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A371C433F5 for ; Mon, 13 Sep 2021 12:11:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4DEF60FBF for ; Mon, 13 Sep 2021 12:11:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D4DEF60FBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8ib0kzocvVgJgaiVd2wLPvqhso8JfudS/orLL0ikuyI=; b=43MWk3uy+javl6 rpJdLIwC1gyHR/Z47zZiJj6IxgPuYnCe5mhCUd7ba3hSLB/wn16HCOLLbk5CVbGXEmEEBg/LsfRYz 159eMShLvhvFEnpKc0ByXp142p+zT6VlH351NW3gBDxHm/fQvuBy2rszSPrsNBLxjLD9q0t6xFIuu rNeRkhUt1au8CzLBLBXnw30V67OEyjg+Rc2Dm1YZqt1ujbU6tBugbCtKfa/GjYgKeNyDscN7WItUz lHktEe+ZqbTX9wwdQQO4VMoCxpwBH9/KJ49Y5O1m6FW8NBHlcNFRWTBv8lJYYz9j4NFD6ZcFgOzGq Am0hKODnt5+ZExT+LOSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPkm5-001Xiv-Mz; Mon, 13 Sep 2021 12:09:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPkm1-001Xi6-EY for linux-arm-kernel@lists.infradead.org; Mon, 13 Sep 2021 12:09:22 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F0FEC31B; Mon, 13 Sep 2021 05:09:17 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.16.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4B58E3F59C; Mon, 13 Sep 2021 05:09:16 -0700 (PDT) Date: Mon, 13 Sep 2021 13:09:08 +0100 From: Mark Rutland To: cgel.zte@gmail.com Cc: catalin.marinas@arm.com, will@kernel.org, pcc@google.com, maz@kernel.org, peterz@infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lv Ruyi , Zeal Robot Subject: Re: [PATCH] arm64/kernel: remove duplicate include in process.c Message-ID: <20210913120908.GA9450@C02TD0UTHF1T.local> References: <20210902011126.29828-1-lv.ruyi@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210902011126.29828-1-lv.ruyi@zte.com.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210913_050921_646179_C686B33C X-CRM114-Status: GOOD ( 17.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 01, 2021 at 06:11:26PM -0700, cgel.zte@gmail.com wrote: > From: Lv Ruyi > > Remove all but the first include of linux/sched.h from process.c > > Reported-by: Zeal Robot > Signed-off-by: Lv Ruyi > --- > arch/arm64/kernel/process.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > index 19100fe8f7e4..1a1213cca173 100644 > --- a/arch/arm64/kernel/process.c > +++ b/arch/arm64/kernel/process.c > @@ -18,7 +18,6 @@ > #include > #include > #include > -#include > #include > #include > #include For the benefit of other reviewers, while it's not obvious from the patch context, arlier in the includes (which aren't currently sorted), there's a block with: | #include | #include | #include | #include ... and so this patch looks good to me: Acked-by: Mark Rutland IMO it would be nice to sort the includes if that's not too churny (but that should be a separate patch). Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel