From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F64FC433EF for ; Mon, 13 Sep 2021 12:43:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68DA560FF2 for ; Mon, 13 Sep 2021 12:43:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236260AbhIMMok (ORCPT ); Mon, 13 Sep 2021 08:44:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:34270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238241AbhIMMoj (ORCPT ); Mon, 13 Sep 2021 08:44:39 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BAD9660FBF; Mon, 13 Sep 2021 12:43:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631537004; bh=yJ4ueh+BO+Eim5GlQAHvD/jC8/yyMw/A2pszTTlipf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Uh7vPwgYDUjDa0Ka1KtcHPOvbYjYireDALG+UCMqB5zH1I+QzXU7kssiZ9Sv7aDJ0 C+JVpDhRluKGMBK4A5APeW1ozq1gmAAUgwBOmL+4Au20gaKoOf9HFptPuXHLgJP7LH yfzI3ko9NOtNH9Bx8BzcGVg4gU7iHPS8DcwJNc3OD85FKCoQG/oIWb+TXgNOToIsfe LnxtQvRLS+QD5LPr0Mqdr1AKxiK3KDNYoPIp9bPAIn63bIqqndplIsrTX2E5KNj7L2 mgDX/Ok1m7fCgDz1wF8gu1VQOEId/3pIwmBm6hjnDxFyBCZk/gsseQK//cJdW/98eG CBeTkiUYalMpg== From: Mark Brown To: Catalin Marinas , Will Deacon , Shuah Khan , Shuah Khan Cc: linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, Mark Brown Subject: [PATCH v1 2/4] selftests: arm64: Remove bogus error check on writing to files Date: Mon, 13 Sep 2021 13:37:09 +0100 Message-Id: <20210913123711.51274-3-broonie@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210913123711.51274-1-broonie@kernel.org> References: <20210913123711.51274-1-broonie@kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1028; h=from:subject; bh=yJ4ueh+BO+Eim5GlQAHvD/jC8/yyMw/A2pszTTlipf8=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBhP0X0GHlxtnIY4Eu/5/J5cdKSDM5mRmL00dmRJpB8 pcoNJEyJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCYT9F9AAKCRAk1otyXVSH0AbNB/ 97T/ElaD18tKfvi6H8tjzaKDZp3Lis7lsloiDMe2ZznGjX7kDm2EY6c9liJYAsynngFKLCoPotrMVS mjQxUnFfo3ktFrSol91MMls0M1jVPd1CTc/QWDYArFbOSFck9YzaTG3blB8Kl4nqsD4hdhY+RlUKB7 sSmoh1AvQgkueZzplBnuM/sGOFZHkqZT4mizvP4ySzrpjjhj6q+CvCPDwmYZhU3CTCeNMFKkJt9/bQ v+n1ratWmfPG0Y/1IfJmxnE9BhhR7qVsgDHMrj20z4HAzDVUhu7rSVzEv4nSC5I7ivqsxQ0S8oNVKg srTsxhFB9yLGuEwdluUPm10Hs//dol X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Due to some refactoring with the error handling we ended up mangling things so we never actually set ret and therefore shouldn't be checking it. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/vec-syscfg.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tools/testing/selftests/arm64/fp/vec-syscfg.c b/tools/testing/selftests/arm64/fp/vec-syscfg.c index b2de002ee325..d48d3ee1bc36 100644 --- a/tools/testing/selftests/arm64/fp/vec-syscfg.c +++ b/tools/testing/selftests/arm64/fp/vec-syscfg.c @@ -180,7 +180,6 @@ static int file_read_integer(const char *name, int *val) static int file_write_integer(const char *name, int val) { FILE *f; - int ret; f = fopen(name, "w"); if (!f) { @@ -192,11 +191,6 @@ static int file_write_integer(const char *name, int val) fprintf(f, "%d", val); fclose(f); - if (ret < 0) { - ksft_test_result_fail("Error writing %d to %s\n", - val, name); - return -1; - } return 0; } -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88259C433EF for ; Mon, 13 Sep 2021 12:46:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C7F460FBF for ; Mon, 13 Sep 2021 12:46:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4C7F460FBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5fnrnokOt5826wOfBJUgN5c0VyWwx189IN7FufqYZEs=; b=kFJtIv6VVXZkyZ xvCc4N4efihR0zPcjsc5oNSljG05AxLQLAnSSKzougiYgCBMZ5F/cm1C8SgqrIN7457FNtfMAo0lV fd4ZrTNNbQJgiiCEOGQqwx/3Pvcin8icyiGHT3RDTnEu/bp+DJdRywUd4WGsb7hc1YEv+4d0LtbDe UemZEkEGAFhVbnR2cPONQujNGv85lJBBU/i7l9q9UuSiIuv8ZTxbmCd7L9VMk2UHHd//HWkULV9jr tkZDaXOfelf23B8gNKW3mH2UptA9zOGWfIJlRYTlMKW8RxnGdcYnAcqz54c8uXN0T20PmOi/vU8Rg hA36B8AXz1IX1vDa4Ssw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPlJL-001co7-4E; Mon, 13 Sep 2021 12:43:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPlIy-001ciO-IY for linux-arm-kernel@lists.infradead.org; Mon, 13 Sep 2021 12:43:25 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BAD9660FBF; Mon, 13 Sep 2021 12:43:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631537004; bh=yJ4ueh+BO+Eim5GlQAHvD/jC8/yyMw/A2pszTTlipf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Uh7vPwgYDUjDa0Ka1KtcHPOvbYjYireDALG+UCMqB5zH1I+QzXU7kssiZ9Sv7aDJ0 C+JVpDhRluKGMBK4A5APeW1ozq1gmAAUgwBOmL+4Au20gaKoOf9HFptPuXHLgJP7LH yfzI3ko9NOtNH9Bx8BzcGVg4gU7iHPS8DcwJNc3OD85FKCoQG/oIWb+TXgNOToIsfe LnxtQvRLS+QD5LPr0Mqdr1AKxiK3KDNYoPIp9bPAIn63bIqqndplIsrTX2E5KNj7L2 mgDX/Ok1m7fCgDz1wF8gu1VQOEId/3pIwmBm6hjnDxFyBCZk/gsseQK//cJdW/98eG CBeTkiUYalMpg== From: Mark Brown To: Catalin Marinas , Will Deacon , Shuah Khan , Shuah Khan Cc: linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, Mark Brown Subject: [PATCH v1 2/4] selftests: arm64: Remove bogus error check on writing to files Date: Mon, 13 Sep 2021 13:37:09 +0100 Message-Id: <20210913123711.51274-3-broonie@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210913123711.51274-1-broonie@kernel.org> References: <20210913123711.51274-1-broonie@kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1028; h=from:subject; bh=yJ4ueh+BO+Eim5GlQAHvD/jC8/yyMw/A2pszTTlipf8=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBhP0X0GHlxtnIY4Eu/5/J5cdKSDM5mRmL00dmRJpB8 pcoNJEyJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCYT9F9AAKCRAk1otyXVSH0AbNB/ 97T/ElaD18tKfvi6H8tjzaKDZp3Lis7lsloiDMe2ZznGjX7kDm2EY6c9liJYAsynngFKLCoPotrMVS mjQxUnFfo3ktFrSol91MMls0M1jVPd1CTc/QWDYArFbOSFck9YzaTG3blB8Kl4nqsD4hdhY+RlUKB7 sSmoh1AvQgkueZzplBnuM/sGOFZHkqZT4mizvP4ySzrpjjhj6q+CvCPDwmYZhU3CTCeNMFKkJt9/bQ v+n1ratWmfPG0Y/1IfJmxnE9BhhR7qVsgDHMrj20z4HAzDVUhu7rSVzEv4nSC5I7ivqsxQ0S8oNVKg srTsxhFB9yLGuEwdluUPm10Hs//dol X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210913_054324_700060_0AB17F41 X-CRM114-Status: UNSURE ( 8.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Due to some refactoring with the error handling we ended up mangling things so we never actually set ret and therefore shouldn't be checking it. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/vec-syscfg.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tools/testing/selftests/arm64/fp/vec-syscfg.c b/tools/testing/selftests/arm64/fp/vec-syscfg.c index b2de002ee325..d48d3ee1bc36 100644 --- a/tools/testing/selftests/arm64/fp/vec-syscfg.c +++ b/tools/testing/selftests/arm64/fp/vec-syscfg.c @@ -180,7 +180,6 @@ static int file_read_integer(const char *name, int *val) static int file_write_integer(const char *name, int val) { FILE *f; - int ret; f = fopen(name, "w"); if (!f) { @@ -192,11 +191,6 @@ static int file_write_integer(const char *name, int val) fprintf(f, "%d", val); fclose(f); - if (ret < 0) { - ksft_test_result_fail("Error writing %d to %s\n", - val, name); - return -1; - } return 0; } -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel