From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A067AC433EF for ; Mon, 13 Sep 2021 14:01:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C334610CC for ; Mon, 13 Sep 2021 14:01:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6C334610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:36292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPmWr-0001Wc-Bb for qemu-devel@archiver.kernel.org; Mon, 13 Sep 2021 10:01:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPli8-0001zw-PS for qemu-devel@nongnu.org; Mon, 13 Sep 2021 09:09:26 -0400 Received: from mga09.intel.com ([134.134.136.24]:16672) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPli6-00048q-6x for qemu-devel@nongnu.org; Mon, 13 Sep 2021 09:09:24 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10105"; a="221708805" X-IronPort-AV: E=Sophos;i="5.85,288,1624345200"; d="scan'208";a="221708805" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2021 06:06:27 -0700 X-IronPort-AV: E=Sophos;i="5.85,288,1624345200"; d="scan'208";a="543205240" Received: from yangzhon-virtual.bj.intel.com (HELO yangzhon-Virtual) ([10.238.144.101]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA256; 13 Sep 2021 06:06:24 -0700 Date: Mon, 13 Sep 2021 20:52:28 +0800 From: Yang Zhong To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , pbonzini@redhat.com Subject: Re: [PATCH v2 1/3] monitor: Add HMP and QMP interfaces Message-ID: <20210913125228.GA27608@yangzhon-Virtual> References: <20210910102258.46648-1-yang.zhong@intel.com> <20210910102258.46648-2-yang.zhong@intel.com> <4ae8c563-9b44-d234-eb01-a61000d01439@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Received-SPF: pass client-ip=134.134.136.24; envelope-from=yang.zhong@intel.com; helo=mga09.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yang.zhong@intel.com, seanjc@google.com, eblake@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Sep 13, 2021 at 01:56:13PM +0100, Daniel P. Berrangé wrote: > On Mon, Sep 13, 2021 at 02:48:37PM +0200, Paolo Bonzini wrote: > > On 13/09/21 11:35, Daniel P. Berrangé wrote: > > > > g_autoptr(Error) err = NULL > > > I was mistaken here - Error shouldn't use g_autoptr, just > > > > > > Error err = NULL; > > > > > > > > + SGXInfo *info = qmp_query_sgx(NULL); > > > > Pass in &err not NULL; > > > > > > > > Also declare it with 'g_autoptr(SGXInfo) info = ...' > > > > > > > > And then > > > > > > > > if (err) { > > > > monitor_printf(mon, "%s\n", error_get_pretty(err); > > > Then use the simpler: > > > > > > error_report_err(err); > > > > Indeed. > > > > That said, more long term (but this is something Coccinelle could help with) > > perhaps error_report_err should not free the error, and instead we should > > use g_autoptr(Error) in the callers. I don't like functions that do not > > have free in their name and yet free a pointer... > > Yes, this error_report_err surprises me every 6 months when I > come to deal with it. So I think using g_autoptr would be a > nice replacement, with no additional burden in terms of lines > of code in callers too. > Do we need call qapi_free_SGXInfo(info) here? In previous code design, the code like below: SGXInfo *info = qmp_query_sgx(&err); ...... qapi_free_SGXInfo(info); Yang > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|