From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C102BC433EF for ; Mon, 13 Sep 2021 15:07:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72E4360FE6 for ; Mon, 13 Sep 2021 15:07:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 72E4360FE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPnYf-0002jl-82 for qemu-devel@archiver.kernel.org; Mon, 13 Sep 2021 11:07:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPnXI-0001k0-7P for qemu-devel@nongnu.org; Mon, 13 Sep 2021 11:06:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:49447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPnXG-00036d-MZ for qemu-devel@nongnu.org; Mon, 13 Sep 2021 11:06:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631545577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m5FMm2OEXgS3pt/NGIhjo5gnyehc8tguYaR9eAVBCxc=; b=esQfEXsj3/HrWB8DNs+//8Sh8UxSckAax1A/bFWTJiOvXuUdAyRm+OFPBnJOR8IQNiGIGH 0T1fDFUCB+1pHG9xF8mInh+MEH4f1WecTasU0L4LBwpAlWa1HEQkHgubVI92h4MYYxuKXJ Og2NCxiLOe8lgbsVpwYMG6hYL/B72Xk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-444-V403ulxaOEqcdVbsJ08XOg-1; Mon, 13 Sep 2021 11:06:16 -0400 X-MC-Unique: V403ulxaOEqcdVbsJ08XOg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F6198010F4 for ; Mon, 13 Sep 2021 15:06:15 +0000 (UTC) Received: from redhat.com (ovpn-113-222.phx2.redhat.com [10.3.113.222]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C43C369A; Mon, 13 Sep 2021 15:06:11 +0000 (UTC) Date: Mon, 13 Sep 2021 10:06:09 -0500 From: Eric Blake To: Markus Armbruster Subject: Re: [PATCH 12/22] test-qobject-input-visitor: Wean off UserDefListUnion Message-ID: <20210913150609.hr4fm3uqyqd4vlz5@redhat.com> References: <20210913123932.3306639-1-armbru@redhat.com> <20210913123932.3306639-13-armbru@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210913123932.3306639-13-armbru@redhat.com> User-Agent: NeoMutt/20210205-772-2b4c52 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Sep 13, 2021 at 02:39:22PM +0200, Markus Armbruster wrote: > The test_visitor_in_list_union_FOO() use simple union UserDefListUnion > to cover lists of builtin types. Rewrite as > test_visitor_in_list_struct(), using struct ArrayStruct and a lot less > code. > > test_visitor_in_fail_union_list() uses UserDefListUnion to cover > "variant members don't match the discriminator value". Cover that in > test_visitor_in_fail_union_flat() instead, and drop > test_visitor_in_fail_union_list(). Appropriating the former for this > purpose is okay, because it actually failed due to missing > discriminator, which is still covered by > test_visitor_in_fail_union_flat_no_discrim(). > > Signed-off-by: Markus Armbruster > --- > tests/unit/test-qobject-input-visitor.c | 460 ++++++++---------------- > 1 file changed, 148 insertions(+), 312 deletions(-) > > @@ -1206,7 +1066,7 @@ static void test_visitor_in_fail_union_flat(TestInputVisitorData *data, > Error *err = NULL; > Visitor *v; > > - v = visitor_input_test_init(data, "{ 'string': 'c', 'integer': 41, 'boolean': true }"); > + v = visitor_input_test_init(data, "{ 'enum1': 'value2', 'string': 'c', 'integer': 41, 'boolean': true }"); Long line; do we care? Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org