From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49401C43219 for ; Mon, 13 Sep 2021 15:36:35 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DA7D610A6 for ; Mon, 13 Sep 2021 15:36:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4DA7D610A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6F99083979; Mon, 13 Sep 2021 17:36:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Pa11PPSp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1E24E83979; Mon, 13 Sep 2021 17:36:29 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 72E77833C1 for ; Mon, 13 Sep 2021 17:36:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id bk29so10964529qkb.8 for ; Mon, 13 Sep 2021 08:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IhMIzUyY80lTIWZwyXNkNhjr1C9NMzp6/jv9UUvYGYE=; b=Pa11PPSpWlR5RvFqtdJJTFtsjN2yJgTPyPIVF60YLyayKmlclAX0mHGTYhCkOmObCt hw5ofc0yFKgTgZesTMaDNWZZKSdrL4uQ8HwwhEehLDWEn9UbTHEgw6tke5vO2oOVsH03 8xk/bk7XtDhYYHeE9z+c/M8McRpDE8JrGe/I0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IhMIzUyY80lTIWZwyXNkNhjr1C9NMzp6/jv9UUvYGYE=; b=rl7J9dus51dL5cxsZy3U8ttz+lYuk88Y8d17AOv86xVQpo23ZFkLWieUDmPFvHQFFc i2buKSdbg32Dn7oFisie18tGGxu0gVJISOOp3OLDm401/NahkgozZ9os7aFlxqBSkP5J x96lpMw3KqdcZ69bqwMqt2v5TVKvCVg+ADN+Scgzb/Sk3vII2EQB3s3dyDbGQoAov+Ek uYy8sS0Gx6Ot8gKPX5XiG7ymYdnigQ5ObNC0+m7BxIZ9O2Xiojm0lZeoIaQuTViBzmTL RRzp1hd7DNPbCl/prhzEr8UvpahxzwmaqVl1F6ejsVbDIK+60XQHZAEYDe+zkBuG8Yy3 fTBw== X-Gm-Message-State: AOAM532qIrVIXdMRaNBUNb0Kj5h+H475uKP5xKEwfssmqGIi+8q8/RmP y3B2DfR8hvqnqahZI26PgXtivw== X-Google-Smtp-Source: ABdhPJwjSlJZZAn6LjpZ8Qkzex8+RId5OHiUVw9WLAzlninv6kO3kPt8iCrtUpWvqyRsdDizvfmyFw== X-Received: by 2002:a05:620a:4ed:: with SMTP id b13mr244636qkh.26.1631547384185; Mon, 13 Sep 2021 08:36:24 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-0166-c2e8-bb10-efce.res6.spectrum.com. [2603:6081:7b01:cbda:166:c2e8:bb10:efce]) by smtp.gmail.com with ESMTPSA id q7sm5499196qkm.68.2021.09.13.08.36.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Sep 2021 08:36:23 -0700 (PDT) Date: Mon, 13 Sep 2021 11:36:21 -0400 From: Tom Rini To: Jan Kiszka , Simon Glass Cc: U-Boot Mailing List , Le Jin , Bao Cheng Su , Nian Gao , Chao Zeng , Lokesh Vutla Subject: Re: [PATCH v7 5/5] iot2050: Enable watchdog support, but do not auto-start it Message-ID: <20210913153621.GP12964@bill-the-cat> References: <44b858e8826f4617439aec11ad850431e4bc1a21.1628000645.git.jan.kiszka@siemens.com> <20210911001003.GA2638@bill-the-cat> <0fd4c0d4-c42f-bb15-b68b-3ccf9a9037e0@siemens.com> <20210913123445.GB12964@bill-the-cat> <5d515165-6f39-285d-7bd1-a412ed468cf4@siemens.com> <20210913145609.GO12964@bill-the-cat> <54d40bce-3baf-e485-3467-863eca5bf296@siemens.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="d1TbJDQJIIsIsPGO" Content-Disposition: inline In-Reply-To: <54d40bce-3baf-e485-3467-863eca5bf296@siemens.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --d1TbJDQJIIsIsPGO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 13, 2021 at 04:59:35PM +0200, Jan Kiszka wrote: > On 13.09.21 16:56, Tom Rini wrote: > > On Mon, Sep 13, 2021 at 04:31:37PM +0200, Jan Kiszka wrote: > >> On 13.09.21 14:34, Tom Rini wrote: > >>> On Mon, Sep 13, 2021 at 09:57:45AM +0200, Jan Kiszka wrote: > >>>> On 11.09.21 02:10, Tom Rini wrote: > >>>>> On Tue, Aug 03, 2021 at 04:24:05PM +0200, Jan Kiszka wrote: > >>>>> > >>>>>> From: Jan Kiszka > >>>>>> > >>>>>> This allows to use the watchdog in custom scripts but does not enf= orce > >>>>>> that the OS has to support it as well. > >>>>>> > >>>>>> Signed-off-by: Jan Kiszka > >>>>> > >>>>> Sorry for the late reply. This causes CI to fail: > >>>>> Building current source for 1 boards (1 thread, 16 jobs per thread) > >>>>> aarch64: + iot2050 > >>>>> +(iot2050) WARNING ATF file bl31.bin NOT found, resulting binary is= non-functional > >>>>> +(iot2050) WARNING OPTEE file bl32.bin NOT found, resulting might b= e non-functional > >>>>> +(iot2050) binman: Filename 'k3-rti-wdt.fw' not found in input path= (.,/home/trini/work/u-boot/u-boot,board/siemens/iot2050,arch/arm/dts) (cwd= =3D'/tmp/iot2050/.bm-work/iot2050') > >>>>> +(iot2050) make[1]: *** [all] Error 1 > >>>>> +(iot2050) make: *** [sub-make] Error 2 > >>>>> 0 0 1 /1 iot2050 > >>>>> > >>>>> And needs to be handled like ATF/OPTEE/etc where CI can build but t= hrow > >>>>> a "THIS WILL NOT RUN CORRECTLY" type warning to the user. > >>>>> > >>>> > >>>> I was about to sent an update anyway - time passed, and now we even = have > >>>> support for the next generation integrated from the beginning. But > >>>> related upstream DT changes are not yet merged. > >>> > >>> OK. > >>> > >>>> But back to this issue: How can CI be fed with all those required > >>>> binaries? The build makes no sense in their absence. > >>> > >>> To be clearer, CI isn't fed all of the binaries, we just use /dev/null > >>> in that case and try and make it clear it won't boot. K3 isn't a good > >>> example here, but I think sunxi uses binman and handles this same cla= ss > >>> of problem? > >>> > >> > >> I'm seeing it additionally carrying a "missing-msg" property, but that > >> alone (even with missing-blob-help updated) does not make the build > >> pass. It rather seems I'm missing some "allow_missing" property for th= at > >> image, but even reading the code gives no clue yet how to achieve that. > >> Yet another binman mystery. > >=20 > > You might also need a new file in tools/binman/etype/ ? Also, it will > > have a non-zero exit status still, but with a value of 101 which we > > check for and know that's "binary blob missing" and so OK to allow CI to > > pass on. > >=20 >=20 > Err, that doesn't sound like binman is making my life easier. Why can't > a I simple do something like >=20 > k3-rti-wdt-firmware { > type =3D "blob"; > load =3D <0x82000000>; > blob { > filename =3D CONFIG_WDT_K3_RTI_FW_FILE; > missing-msg =3D "k3-rti-wdt-firmware"; > allow_missing; > }; > }; >=20 > and be done? Sounds like a good idea, and I'm not quite sure what's missing to go =66rom where we are today to there. I might be missing something myself. --=20 Tom --d1TbJDQJIIsIsPGO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmE/b/IACgkQFHw5/5Y0 tyyE9wwAi3S6WdlT07QGpfpZSMAOe5KnggY10pfJmetjad0x4K6rJ5YgyJPLrszO YHQA0N0WRhW1aWWa3c/PZ8UOkVJA5D27GGuay20ZSB4vay08ay1UcwcbDfL57UYt REtNfyMFENPU9OSy9vgv0UGFS/wAhcRBicWKW6+tHVxJ1EJOlEFwVfWGMWocqPj7 9V2wT1RH/M+p+ELpxFq1jOOP2e+bHeSpx4s/D1QTtO4FSSJtQg26lSS//wNdP0cX 0iC0qRAqVP2z8opaBwmG2LTX0rtuh4oF5KNet+MBcSOJdCHl667e53AJZFC+4Her P3SuWcpDMqneyR/PdiBBvscp7X60s4RLwHQZCQiDdcrf4v9mCnUEnIO35FWzzVWj MqfNOlRI1Gxf0jg+2DH0kW4dfGvOFmb2y0P1VPAa5xnDhhoKCsXlpWlyLHUbhdpA HQrwvPc3YXtZ1ABrC4YSWu1wze137GV0tt9YvHLm4c1+n5nU/v7m26DXEb7N4Zzf DiMuAsAQ =bkVv -----END PGP SIGNATURE----- --d1TbJDQJIIsIsPGO--