From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 508B2C433F5 for ; Mon, 13 Sep 2021 16:03:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16A12604D1 for ; Mon, 13 Sep 2021 16:03:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 16A12604D1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K91E4TSzjvCEVLK6Nx9BJbYsINgueuYox3qhVtwoAzw=; b=XPrVRMefAvASoC q8+BYXPQvgzgr8IVOjHDqDn9eqU5+H6p/TFfVvFc6RKTCj7z5YCemzPjvkM7aCABiypesU6H6ZrK5 4Bg6lnp+HKyZPgYjcCgcyFAokCBgmyN5YHstVd5hhsQBQtU19yKK4oqcHOOtlgtrjO1frlENPeA/G UHrbLleDSb3SRwSrI27gTPYbzk3J9LLVyT9cyuqnT/uo5hhwHQUN8dbgI84lI30OgyXKqtaB+kocy MNT+AIMKie8YPONjht1OqVMh0WUziDBwZenRqgKUk4nbs31+fkqFdntToJU5dDHCtY3nw1+VP+KLP news1ysbX9ORGhNAEf+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPoQP-002H3n-Az; Mon, 13 Sep 2021 16:03:17 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPoQM-002H2F-D8 for linux-nvme@lists.infradead.org; Mon, 13 Sep 2021 16:03:15 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 63F7768AFE; Mon, 13 Sep 2021 18:03:11 +0200 (CEST) Date: Mon, 13 Sep 2021 18:03:10 +0200 From: Christoph Hellwig To: Anton Eidelman Cc: linux-nvme@lists.infradead.org, hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, Anton Eidelman , Chaitanya Kulkarni Subject: Re: [PATCH v2 3/3] nvme/multipath: fix stale ana state for namespaces just added by scan work Message-ID: <20210913160310.GC6442@lst.de> References: <20210912185459.13496-4-anton@lightbitslabs.com> <20210913153023.70879-1-anton@lightbitslabs.com> <20210913153023.70879-4-anton@lightbitslabs.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210913153023.70879-4-anton@lightbitslabs.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210913_090314_629596_B0D8FAF0 X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Sep 13, 2021 at 09:30:23AM -0600, Anton Eidelman wrote: > Scan work initially adds new namespaces to ctrl->namespaces TAIL. > They make the list unordered temporarily until nvme_scan_work() > finally sorts the list. > > Solution: > In order to preserve the way ctrl->namespaces is updated and sorted, > make nvme_update_ana_state() deal with the case where ctrl->namespaces > is not fully sorted and has new namespaces appended with potentially > lower nsids. > nvme_update_ana_state() keeps track of the nsid seen in the list, > detects the unsorted case (rare), and restarts scanning of desc->nsids. Can we dust off the patch from Chaitanya to switch to an always sorted xarray instead of papering over this delayed sort? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme