All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "X86 ML" <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	"Marcus Rückert" <mrueckert@suse.com>
Subject: Re: [PATCH] x86/umip: Add a umip= cmdline switch
Date: Mon, 13 Sep 2021 14:38:36 -0700	[thread overview]
Message-ID: <20210913213836.GA10627@ranerica-svr.sc.intel.com> (raw)
In-Reply-To: <YTx0+0pfyzHuX80L@zn.tnic>

On Sat, Sep 11, 2021 at 11:20:59AM +0200, Borislav Petkov wrote:
> On Fri, Sep 10, 2021 at 06:14:59PM -0700, Ricardo Neri wrote:
> > If it is printing the same information again and again, wouldn't it be
> > simpler to have a umip_pr_warn_once()?
> 
> If you do a once thing, you're blocking any other programs from warning,
> output you probably wanna see.

That is right. Although, I am not sure programs you can have in
the same machine that also want to use UMIP-protected instructions.
> 
> With the command line switch you do the same but you're at least pushing
> the user to become active and do it first. I.e., with enabling that
> option, the user basically says that she/he is not interested in any of
> that output and that is ok.
> 
> The optimal thing would be to ratelimit it per process but that would be
> an overkill and not really needed.

Indeed.

Thanks and BR,
Ricardo

  reply	other threads:[~2021-09-13 21:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 20:04 [PATCH] x86/umip: Add a umip= cmdline switch Borislav Petkov
2021-09-11  1:14 ` Ricardo Neri
2021-09-11  9:20   ` Borislav Petkov
2021-09-13 21:38     ` Ricardo Neri [this message]
2021-09-14 16:51       ` Borislav Petkov
2021-09-15 11:34         ` Ricardo Neri
2021-09-15 12:21           ` Marcus Rückert
2021-09-15 13:00             ` Ricardo Neri
2021-09-15 13:14               ` Borislav Petkov
2021-09-15 14:46           ` [PATCH] x86/umip: Downgrade warning messages to debug loglevel Borislav Petkov
2021-09-16  0:27             ` Ricardo Neri
2021-09-23 14:59               ` Borislav Petkov
2021-09-13 21:45 ` [PATCH] x86/umip: Add a umip= cmdline switch Ricardo Neri
2021-09-14 16:52   ` Borislav Petkov
2021-09-23 15:03 ` [tip: x86/cpu] x86/umip: Downgrade warning messages to debug loglevel tip-bot2 for Borislav Petkov
2021-09-25 11:31 ` tip-bot2 for Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210913213836.GA10627@ranerica-svr.sc.intel.com \
    --to=ricardo.neri-calderon@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mrueckert@suse.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.