All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Eidelman <anton.eidelman@gmail.com>
To: linux-nvme@lists.infradead.org, hch@lst.de, kbusch@kernel.org,
	sagi@grimberg.me, axboe@fb.com
Cc: Anton Eidelman <anton@lightbitslabs.com>
Subject: [PATCH v3 2/3] nvme/multipath: cosmetic: keep ns nsid locally
Date: Mon, 13 Sep 2021 15:46:31 -0600	[thread overview]
Message-ID: <20210913214632.88294-3-anton@lightbitslabs.com> (raw)
In-Reply-To: <20210913214632.88294-1-anton@lightbitslabs.com>

Keep the nsid of the current namespace in a local variable,
in order to avoid multiple occurrances of "ns->head->ns_id".

Signed-off-by: Anton Eidelman <anton@lightbitslabs.com>
---
 drivers/nvme/host/multipath.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index e8ccdd398f78..e1ce80c12815 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -601,15 +601,17 @@ static int nvme_update_ana_state(struct nvme_ctrl *ctrl,
 	down_read(&ctrl->namespaces_rwsem);
 	list_for_each_entry(ns, &ctrl->namespaces, list) {
 		unsigned nsid;
+		unsigned ns_nsid = ns->head->ns_id;
+
 again:
 		nsid = le32_to_cpu(desc->nsids[n]);
-		if (ns->head->ns_id < nsid)
+		if (ns_nsid < nsid)
 			continue;
-		if (ns->head->ns_id == nsid)
+		if (ns_nsid == nsid)
 			nvme_update_ns_ana_state(desc, ns);
 		if (++n == nr_nsids)
 			break;
-		if (ns->head->ns_id > nsid)
+		if (ns_nsid > nsid)
 			goto again;
 	}
 	up_read(&ctrl->namespaces_rwsem);
-- 
2.25.1


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  parent reply	other threads:[~2021-09-13 21:47 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12 18:54 [PATCH RESEND 0/3] nvme/mpath: fix missed namespaces in ana state update Anton Eidelman
2021-09-12 18:54 ` [PATCH 1/3] nvme/multipath: fix failure to update ns ana state Anton Eidelman
2021-09-12 18:54 ` [PATCH 2/3] nvme/multipath: cosmetic: keep ns nsid locally Anton Eidelman
2021-09-12 18:54 ` [PATCH 3/3] nvme/multipath: fix stale ana state for namespaces just added by scan work Anton Eidelman
2021-09-13 15:30   ` [PATCH v2 0/3] nvme/mpath: fix missed namespaces in ana state update Anton Eidelman
2021-09-13 15:30     ` [PATCH v2 1/3] nvme/multipath: fix failure to update ns ana state Anton Eidelman
2021-09-13 16:01       ` Christoph Hellwig
2021-09-13 19:29       ` Sagi Grimberg
2021-09-14  8:27       ` Christoph Hellwig
2021-09-13 15:30     ` [PATCH v2 2/3] nvme/multipath: cosmetic: keep ns nsid locally Anton Eidelman
2021-09-13 16:02       ` Christoph Hellwig
2021-09-13 20:19         ` Anton Eidelman
2021-09-13 20:57           ` Keith Busch
2021-09-14  5:44             ` Christoph Hellwig
2021-09-13 15:30     ` [PATCH v2 3/3] nvme/multipath: fix stale ana state for namespaces just added by scan work Anton Eidelman
2021-09-13 16:03       ` Christoph Hellwig
2021-09-13 16:08         ` Keith Busch
2021-09-14  6:24           ` Sagi Grimberg
2021-09-14  6:30             ` Christoph Hellwig
2021-09-14  6:40               ` Christoph Hellwig
2021-09-14  7:09               ` Sagi Grimberg
2021-09-14  7:32                 ` Christoph Hellwig
2021-09-14 16:45                   ` Anton Eidelman
2021-09-15  9:32                     ` Sagi Grimberg
2021-09-14 14:24               ` Keith Busch
2021-09-13 16:07       ` Keith Busch
2021-09-13 16:11         ` Christoph Hellwig
2021-09-13 16:24           ` Keith Busch
2021-09-13 16:46           ` Anton Eidelman
2021-09-13 15:32     ` [PATCH v2 0/3] nvme/mpath: fix missed namespaces in ana state update Christoph Hellwig
2021-09-13 15:42     ` [PATCH v2 0/3] nvme/mpath: fix missed namespaces in ana state update FIXED Anton Eidelman
2021-09-13 21:46       ` [PATCH v3 0/3] nvme/mpath: fix missed namespaces in ana state update Anton Eidelman
2021-09-13 21:46         ` [PATCH v3 1/3] nvme/multipath: fix failure to update ns ana state Anton Eidelman
2021-09-13 21:46         ` Anton Eidelman [this message]
2021-09-13 21:46         ` [PATCH v3 3/3] nvme/multipath: fix stale ana state for namespaces just added by scan work Anton Eidelman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210913214632.88294-3-anton@lightbitslabs.com \
    --to=anton.eidelman@gmail.com \
    --cc=anton@lightbitslabs.com \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.