All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: "Alex G." <mr.nuke.me@gmail.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 5/5] serial: Rework CONFIG_SYS_BAUDRATE_TABLE
Date: Mon, 13 Sep 2021 18:14:03 -0400	[thread overview]
Message-ID: <20210913221403.GU12964@bill-the-cat> (raw)
In-Reply-To: <596e1bf3-0c51-c528-77e0-2be943c18e28@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

On Mon, Sep 13, 2021 at 05:03:13PM -0500, Alex G. wrote:

[snip]
> Suggestion II: Define the Kconfig SYS_BAUDRATE_TABLE table to a C array,
> like 'default "{ 300, 420, 690}" ' and forego the #ifdefs in serial.h

Oh!  And FWIW, I don't _think_ this works.  I'd be quite happy to be
proven wrong, but there's not a useful Kconfig type here.  If we use
"string" and put in "{ 115200 }", we end up with:
static const unsigned long baudrate_table[] = "{ 115200 }";
which isn't what we want.  We'd need something clever next to turn a
string in to something we can use.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  parent reply	other threads:[~2021-09-13 22:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 21:24 [PATCH 1/5] kgdb: Remove unused serial related options Tom Rini
2021-09-13 21:24 ` [PATCH 2/5] Convert CONFIG_BAUDRATE to Kconfig Tom Rini
2021-10-02 21:09   ` Tom Rini
2021-09-13 21:24 ` [PATCH 3/5] serial: Use the default CONFIG_SYS_BAUDRATE_TABLE in more platforms Tom Rini
2021-10-02 21:09   ` Tom Rini
2021-09-13 21:24 ` [PATCH 4/5] serial: Remove extraneous SYS_MALLOC_F check Tom Rini
2021-10-02 21:09   ` Tom Rini
2021-09-13 21:24 ` [PATCH 5/5] serial: Rework CONFIG_SYS_BAUDRATE_TABLE Tom Rini
2021-09-13 22:03   ` Alex G.
2021-09-13 22:11     ` Tom Rini
2021-09-24 19:08       ` Pali Rohár
2021-09-24 22:07         ` Tom Rini
2021-09-25 12:22           ` Pali Rohár
2021-09-13 22:14     ` Tom Rini [this message]
2021-09-15  2:07 ` [PATCH 1/5] kgdb: Remove unused serial related options Peng Fan (OSS)
2021-09-15  3:15   ` Tom Rini
2021-09-26  9:54     ` Peng Fan (OSS)
2021-09-26 16:54       ` Tom Rini
2021-10-02 21:09 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210913221403.GU12964@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=mr.nuke.me@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.