From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23C4CC433EF for ; Mon, 13 Sep 2021 23:53:29 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FB04610F9 for ; Mon, 13 Sep 2021 23:53:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1FB04610F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0FE8183884; Tue, 14 Sep 2021 01:53:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id EFAE783891; Tue, 14 Sep 2021 01:53:22 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 403C48387E for ; Tue, 14 Sep 2021 01:53:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7B18A6D; Mon, 13 Sep 2021 16:53:18 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C69ED3F719; Mon, 13 Sep 2021 16:53:17 -0700 (PDT) Date: Tue, 14 Sep 2021 00:53:13 +0100 From: Andre Przywara To: Samuel Holland Cc: u-boot@lists.denx.de, Jagan Teki Subject: Re: [PATCH 1/3] sunxi: Clean up inclusions of asm/arch/gpio.h Message-ID: <20210914005313.085b6748@slackpad.fritz.box> In-Reply-To: <20210911215049.5840-2-samuel@sholland.org> References: <20210911215049.5840-1-samuel@sholland.org> <20210911215049.5840-2-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, 11 Sep 2021 16:50:47 -0500 Samuel Holland wrote: > As part of migrating to DM_GPIO and DM_PINCTRL, eventually we will > remove the asm/arch/gpio.h header. In preparation, clean up the various > files that include it. > > Some files did not contain any GPIO code at all, so this header was > completely unused. > > A few files contained only legacy platform-specific GPIO code for > setting up pin muxes. They were left unchanged, as that code will be > completely removed by the DM_PINCTRL migration. > > The remaining files contain some combination of DM_GPIO and legacy GPIO > code. For those, switch to including asm/gpio.h (if it wasn't included > already). Right now, this header provides both sets of functions, > because ARCH_SUNXI selects GPIO_EXTRA_HEADER. This will still be the > right header to include once the DM_GPIO migration is complete and > GPIO_EXTRA_HEADER is no longer needed. Nice cleanup, and it survived a buildman sunxi (all 158 boards). > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Cheers, Andre > --- > > arch/arm/mach-sunxi/board.c | 1 - > arch/arm/mach-sunxi/clock.c | 1 - > arch/arm/mach-sunxi/clock_sun4i.c | 1 - > board/sunxi/board.c | 1 - > board/sunxi/gmac.c | 1 - > drivers/gpio/axp_gpio.c | 1 - > drivers/gpio/sunxi_gpio.c | 1 - > drivers/mmc/sunxi_mmc.c | 3 +-- > drivers/net/sun8i_emac.c | 5 +---- > drivers/power/axp809.c | 1 - > drivers/power/axp818.c | 1 - > drivers/usb/musb-new/sunxi.c | 2 -- > drivers/video/sunxi/sunxi_display.c | 1 - > drivers/video/sunxi/sunxi_lcd.c | 1 - > 14 files changed, 2 insertions(+), 19 deletions(-) > > diff --git a/arch/arm/mach-sunxi/board.c b/arch/arm/mach-sunxi/board.c > index d9b04f75fc4..373cb56db49 100644 > --- a/arch/arm/mach-sunxi/board.c > +++ b/arch/arm/mach-sunxi/board.c > @@ -21,7 +21,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/arch/arm/mach-sunxi/clock.c b/arch/arm/mach-sunxi/clock.c > index f591affebf7..de7e8752988 100644 > --- a/arch/arm/mach-sunxi/clock.c > +++ b/arch/arm/mach-sunxi/clock.c > @@ -10,7 +10,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/arch/arm/mach-sunxi/clock_sun4i.c b/arch/arm/mach-sunxi/clock_sun4i.c > index 57ee018eaa2..471609764d2 100644 > --- a/arch/arm/mach-sunxi/clock_sun4i.c > +++ b/arch/arm/mach-sunxi/clock_sun4i.c > @@ -12,7 +12,6 @@ > #include > #include > #include > -#include > #include > > #ifdef CONFIG_SPL_BUILD > diff --git a/board/sunxi/board.c b/board/sunxi/board.c > index 2b7d655678d..dcd7f0b4375 100644 > --- a/board/sunxi/board.c > +++ b/board/sunxi/board.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/board/sunxi/gmac.c b/board/sunxi/gmac.c > index d8fdf7728e0..1fa54ed72de 100644 > --- a/board/sunxi/gmac.c > +++ b/board/sunxi/gmac.c > @@ -4,7 +4,6 @@ > #include > #include > #include > -#include > > void eth_init_board(void) > { > diff --git a/drivers/gpio/axp_gpio.c b/drivers/gpio/axp_gpio.c > index 73058cf40b4..35585dc8ac9 100644 > --- a/drivers/gpio/axp_gpio.c > +++ b/drivers/gpio/axp_gpio.c > @@ -6,7 +6,6 @@ > */ > > #include > -#include > #include > #include > #include > diff --git a/drivers/gpio/sunxi_gpio.c b/drivers/gpio/sunxi_gpio.c > index 24cb604e3e3..7ce3ef73b46 100644 > --- a/drivers/gpio/sunxi_gpio.c > +++ b/drivers/gpio/sunxi_gpio.c > @@ -14,7 +14,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c > index 178b8cf106d..c62b5f5a6f9 100644 > --- a/drivers/mmc/sunxi_mmc.c > +++ b/drivers/mmc/sunxi_mmc.c > @@ -15,12 +15,11 @@ > #include > #include > #include > +#include > #include > #include > #include > -#include > #include > -#include > #include > > #ifndef CCM_MMC_CTRL_MODE_SEL_NEW > diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c > index d7553fe1634..46786d9f764 100644 > --- a/drivers/net/sun8i_emac.c > +++ b/drivers/net/sun8i_emac.c > @@ -14,9 +14,9 @@ > #include > #include > #include > +#include > #include > #include > -#include > #include > #include > #include > @@ -31,9 +31,6 @@ > #include > #include > #include > -#if CONFIG_IS_ENABLED(DM_GPIO) > -#include > -#endif > > #define MDIO_CMD_MII_BUSY BIT(0) > #define MDIO_CMD_MII_WRITE BIT(1) > diff --git a/drivers/power/axp809.c b/drivers/power/axp809.c > index 6323492b66d..0396502cdb5 100644 > --- a/drivers/power/axp809.c > +++ b/drivers/power/axp809.c > @@ -13,7 +13,6 @@ > #include > #include > #include > -#include > #include > #include > > diff --git a/drivers/power/axp818.c b/drivers/power/axp818.c > index 0531707c8aa..2dc736467bb 100644 > --- a/drivers/power/axp818.c > +++ b/drivers/power/axp818.c > @@ -13,7 +13,6 @@ > #include > #include > #include > -#include > #include > #include > > diff --git a/drivers/usb/musb-new/sunxi.c b/drivers/usb/musb-new/sunxi.c > index fea4105f3d1..7e62e3fe6ea 100644 > --- a/drivers/usb/musb-new/sunxi.c > +++ b/drivers/usb/musb-new/sunxi.c > @@ -25,8 +25,6 @@ > #include > #include > #include > -#include > -#include > #include > #include > #include > diff --git a/drivers/video/sunxi/sunxi_display.c b/drivers/video/sunxi/sunxi_display.c > index 4361a58cd7e..128888f7af1 100644 > --- a/drivers/video/sunxi/sunxi_display.c > +++ b/drivers/video/sunxi/sunxi_display.c > @@ -17,7 +17,6 @@ > > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/video/sunxi/sunxi_lcd.c b/drivers/video/sunxi/sunxi_lcd.c > index 7a9eba1ed42..8b9c3b2bfa9 100644 > --- a/drivers/video/sunxi/sunxi_lcd.c > +++ b/drivers/video/sunxi/sunxi_lcd.c > @@ -15,7 +15,6 @@ > #include > #include > #include > -#include > #include > #include >