From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 2204DC433EF
	for <linux-kernel@archiver.kernel.org>; Tue, 14 Sep 2021 11:26:34 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 0619F603E7
	for <linux-kernel@archiver.kernel.org>; Tue, 14 Sep 2021 11:26:34 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232055AbhINL1t (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 14 Sep 2021 07:27:49 -0400
Received: from mail.kernel.org ([198.145.29.99]:45954 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S231941AbhINL1r (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 14 Sep 2021 07:27:47 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 181086108B;
        Tue, 14 Sep 2021 11:26:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1631618790;
        bh=z17rkFjIwbMfar/Gaqd/jjuffYq/yJJhF9L7K2YXTPM=;
        h=Date:From:To:Cc:Subject:In-Reply-To:From;
        b=htNEbtOR8qIlDyRjbMOB9WHAN23xw30njyo4Z42xUf66tdcFROqF99j61kAILuWku
         EEi7WY+kqZM0x4c9s0vRVj+qvX97IYAP7YCguzD7doP/d0i3WtzTNwiMZWCM1g1HFQ
         h1C1FGtxXJolrKsVRIi2uMdxG/ItX9HWzsVhsYGZhe5Mc0D3rOH11ZlDjfE2jyvlV9
         AylWfFbbnWCwxI4ElWshfq4Rjx8Bs7GgtCsGMgg/uefYgQ8V8gC7v0Fp34a4O/2ZTP
         OO9l5SwILc7PDBXMizpfqhfgpbSUvUiuL6azvn9pqzh3X9Mxv9vg9mh1mCUO+tV5oS
         7bowPvbgqGsBw==
Date:   Tue, 14 Sep 2021 06:26:28 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Dave Jones <davej@codemonkey.org.uk>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: Linux 5.15-rc1
Message-ID: <20210914112628.GA1412445@bjorn-Precision-5520>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <870c3332-db60-9cf5-0439-247f91ce7808@gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 14, 2021 at 08:21:46AM +0200, Heiner Kallweit wrote:
> On 14.09.2021 01:46, Bjorn Helgaas wrote:

> > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATTANSIC, PCI_ANY_ID, quirk_blacklist_vpd);
> >  /*
> 
> Leaving the quirks in FIXUP_HEADER stage would have the advantage that for
> blacklisted devices the vpd sysfs attribute isn't visibale. The needed
> changes to the patch are minimal.

What do you have in mind?  The only thing I can think of would be to
add a "pci_dev.no_vpd" bit.  "vpd.cap == 0" means the device has no
VPD, and "vpd.len == 0" means we haven't determined the size yet.  All
devices start off with vpd.cap == 0 and vpd.len == 0, so a
FIXUP_HEADER quirk would have to set a sentinel value or some other
bit.

Bjorn