From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24787C433EF for ; Tue, 14 Sep 2021 18:28:23 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 859D560F58 for ; Tue, 14 Sep 2021 18:28:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 859D560F58 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BFD884068F; Tue, 14 Sep 2021 20:28:21 +0200 (CEST) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id 1E7964003C for ; Tue, 14 Sep 2021 20:28:21 +0200 (CEST) Received: by mail-pf1-f179.google.com with SMTP id f65so75693pfb.10 for ; Tue, 14 Sep 2021 11:28:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OkTmcqshbtO+DkT8tTtjLrnDgWzJcEk4Y8q/AKgd2PY=; b=XNBr2t4s5SoBIyTf49qN6yXBWePQHUSJC8tt3IO6V+Xp1UgIGL+VO7TOVUqbxS8LgX EsOkql6UI4tLD/4HexTPrAs33F4Y6l28Sh7shsn/UTT/fOVS5bp14s17LAtXNRmS4W0N qN2R81dvwi2HKI/ILriTWN6uGteuOealgzyuPD4Lse+DJAQY2cZki8hIUlNqnB05HeGf tW29rDk9xe6N+3ueo1YGqPTQBt0RAktBwySNcq9xS+zT5uosZY+bkduRNrFsWb4PqjlC Byyx5wgyMsPpy17obckUiBTVTE0rNaGdhMPyZSkgCxjSCy0C5IxAa9dXSPWVCRTWMn5N VHgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OkTmcqshbtO+DkT8tTtjLrnDgWzJcEk4Y8q/AKgd2PY=; b=6W7ZXpNL0o3XDryy+YJ2qNBS7EDkDckVEmScwNRLVT+nWLP+A/diRKJFJ6x/BLrpnk 6u4DWshtxey/dZ+BEtr0ZwRa/Lk73MTY/xXFtlxdDO5ItJoCp23mtwcR1QES/KmnfLXq hnkn2fbxMrv0DAoH0YijD04LhnFykg7nMhzwMqtEkY57ydc5HgqQQGFsSUtJ1F4b6NpQ CG+82u9h9as/t0xvqra/XDwWewiyt+jamv/Rl5WsmqwwVryOP6Ms/6BWaOaaMuCSGA4t IZvS5np4XKvoDYz8R5B1hlup3x0+V76q8LdcxAWZwYptawNNcuNrEkyxoRX7HqsnkUC/ 4EzA== X-Gm-Message-State: AOAM533vdvAOiuVxDDVGBDZsTgysBvBPfOJEFrq2vwwHKPKPo+cGcSq0 KW7ZJCo5+NSmoAs2wvrUWkS7waeWxv32Jw== X-Google-Smtp-Source: ABdhPJy6ZYs8kErJOZ2GRLjbqtD+eelqfNoSmadXWXAWiu87tv77azu5OloyGeVs59mqQ3cOkUi/vg== X-Received: by 2002:a62:b515:0:b0:42c:1d6e:3697 with SMTP id y21-20020a62b515000000b0042c1d6e3697mr6173611pfe.23.1631644100222; Tue, 14 Sep 2021 11:28:20 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id d18sm11951076pge.65.2021.09.14.11.28.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 11:28:19 -0700 (PDT) Date: Tue, 14 Sep 2021 11:28:17 -0700 From: Stephen Hemminger To: Usama Nadeem Cc: thomas@monjalon.net, dev@dpdk.org Message-ID: <20210914112817.519ba4bb@hermes.local> In-Reply-To: <20210914180827.184123-1-usama.nadeem@emumba.com> References: <20210913120951.103968-1-usama.nadeem@emumba.com> <20210914180827.184123-1-usama.nadeem@emumba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] Warns if IPv4, UDP or TCP checksum offload not available X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 14 Sep 2021 23:08:27 +0500 Usama Nadeem wrote: > + > + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_UDP_CKSUM) > + local_port_conf.rxmode.offloads |= > + DEV_RX_OFFLOAD_UDP_CKSUM; > + > + else > + printf("WARNING: UDP Checksum offload not available.\n"); > + > + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_TCP_CKSUM) > + local_port_conf.rxmode.offloads |= > + DEV_RX_OFFLOAD_TCP_CKSUM; > + > + else > + printf("WARNING: TCP Checksum offload not available.\n"); Why does l3fwd care about L4 checksum offload? The application should really be just a simple L3 router. But it seems to have become a test for ptype and depends on TCP/UDP.