From: joevt <joevt@shaw.ca>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: [PATCH 09/11] edid-decode: allow undefined aspect ratio
Date: Tue, 14 Sep 2021 05:11:27 -0700 [thread overview]
Message-ID: <20210914121129.51451-10-joevt@shaw.ca> (raw)
In-Reply-To: <20210914121129.51451-1-joevt@shaw.ca>
Distinguish between "undefined" and "reserved" aspect ratios. See examples apple-xdr-6k-tile0, lg-ultrafine-5k-v1-thunderbolt-dp1-tile0, asus-xg438q-dp
"undefined" is for an aspect ratio that doesn't exist in the list of known aspect ratios. This does not deserve a fail.
"reserved" should not be used and still deserves the fail.
Signed-off-by: Joe van Tunen <joevt@shaw.ca>
---
parse-displayid-block.cpp | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/parse-displayid-block.cpp b/parse-displayid-block.cpp
index 9713c46..8f4e366 100644
--- a/parse-displayid-block.cpp
+++ b/parse-displayid-block.cpp
@@ -270,10 +270,12 @@ void edid_state::parse_displayid_type_1_7_timing(const unsigned char *x,
t.hratio = 256;
t.vratio = 135;
break;
- default:
+ case 8:
s += "undefined";
- if ((x[3] & 0xf) > (dispid.version <= 0x12 ? 7 : 8))
- fail("Unknown aspect 0x%02x.\n", x[3] & 0xf);
+ break;
+ default:
+ s += "reserved";
+ fail("Unknown aspect 0x%02x.\n", x[3] & 0xf);
break;
}
switch ((x[3] >> 5) & 0x3) {
@@ -455,10 +457,12 @@ void edid_state::parse_displayid_type_3_timing(const unsigned char *x)
t.hratio = 256;
t.vratio = 135;
break;
- default:
+ case 8:
s += "undefined";
- if ((x[3] & 0xf) > (dispid.version <= 0x12 ? 7 : 8))
- fail("Unknown aspect 0x%02x.\n", x[3] & 0xf);
+ break;
+ default:
+ s += "reserved";
+ fail("Unknown aspect 0x%02x.\n", x[0] & 0xf);
break;
}
--
2.24.3 (Apple Git-128)
next prev parent reply other threads:[~2021-09-14 12:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 12:11 [PATCH 00/11] edid-decode: bug fixes, additions, changes joevt
2021-09-14 12:11 ` [PATCH 01/11] edid-decode: add more example EDIDs joevt
2021-09-14 12:11 ` [PATCH 02/11] edid-decode: ignore dSYM joevt
2021-09-14 12:11 ` [PATCH 03/11] edid-decode: change install directories for macOS joevt
2021-09-15 10:06 ` Hans Verkuil
2021-09-15 15:25 ` Joe van Tunen
2021-09-14 12:11 ` [PATCH 04/11] edid-decode: add bounds checking joevt
2021-09-15 10:07 ` Hans Verkuil
2021-09-14 12:11 ` [PATCH 05/11] edid-decode: fix standard timing vertical pixels joevt
2021-09-15 10:08 ` Hans Verkuil
2021-09-15 11:10 ` Hans Verkuil
2021-09-15 18:28 ` Joe van Tunen
2021-09-14 12:11 ` [PATCH 06/11] edid-decode: linefeed before fail joevt
2021-09-14 12:11 ` [PATCH 07/11] edid-decode: always linefeed after hex_block joevt
2021-09-15 10:10 ` Hans Verkuil
2021-09-15 15:43 ` Joe van Tunen
2021-09-15 18:27 ` Joe van Tunen
2021-09-14 12:11 ` [PATCH 08/11] edid-decode: output full frequencies for 4:2:0 joevt
2021-09-14 12:11 ` joevt [this message]
2021-09-14 12:11 ` [PATCH 10/11] edid-decode: add warnings to VESA VSDB joevt
2021-09-14 12:11 ` [PATCH 11/11] edid-decode: cta and displayid changes joevt
2021-09-15 13:37 ` Hans Verkuil
2021-09-16 9:15 ` Joe van Tunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914121129.51451-10-joevt@shaw.ca \
--to=joevt@shaw.ca \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.