All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Andi Shyti <andi.shyti@intel.com>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/4] drm/i915: rename debugfs_gt files
Date: Tue, 14 Sep 2021 07:46:01 -0700	[thread overview]
Message-ID: <20210914144601.pws37hme5v3teqyg@ldmartin-desk2> (raw)
In-Reply-To: <87o88v34bm.fsf@intel.com>

On Tue, Sep 14, 2021 at 12:16:13PM +0300, Jani Nikula wrote:
>On Wed, 08 Sep 2021, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>> We shouldn't be using debugfs_ namespace for this functionality. Rename
>> debugfs_gt.[ch] to intel_gt_debugfs.[ch] and then make functions,
>> defines and structs follow suit.
>>
>> While at it and since we are renaming the header, sort the includes
>> alphabetically.
>
>I didn't do a detailed review, maybe someone should, but superficially
>seems good. On the series,
>
>Acked-by: Jani Nikula <jani.nikula@intel.com>

thanks. What about the question I raised on

intel_gt_register_debugfs() vs
intel_gt_debugfs_register()?

and

intel_gt_pm_register_debugfs() vs
intel_gt_pm_debugfs_register()?

what would be prefered here?

thanks
Lucas De Marchi

  reply	other threads:[~2021-09-14 14:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09  0:49 [Intel-gfx] [PATCH 1/4] drm/i915: rename debugfs_gt files Lucas De Marchi
2021-09-09  0:49 ` Lucas De Marchi
2021-09-09  0:49 ` [Intel-gfx] [PATCH 2/4] drm/i915: rename debugfs_engines files Lucas De Marchi
2021-09-09  0:49   ` Lucas De Marchi
2021-09-09  0:49 ` [Intel-gfx] [PATCH 3/4] drm/i915: rename debugfs_gt_pm files Lucas De Marchi
2021-09-09  0:49   ` Lucas De Marchi
2021-09-10 17:52   ` [Intel-gfx] " Lucas De Marchi
2021-09-10 21:14     ` Yokoyama, Caz
2021-09-10 21:52       ` Lucas De Marchi
2021-09-10 23:53         ` Yokoyama, Caz
2021-09-15  0:24     ` Matt Roper
2021-09-09  0:49 ` [Intel-gfx] [PATCH 4/4] drm/i915: deduplicate frequency dump on debugfs Lucas De Marchi
2021-09-09  0:49   ` Lucas De Marchi
2021-09-09  1:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: rename debugfs_gt files Patchwork
2021-09-09  1:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-09  2:50 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-09-09  6:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: rename debugfs_gt files (rev2) Patchwork
2021-09-09  7:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-09  8:51 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-09-14  9:16 ` [PATCH 1/4] drm/i915: rename debugfs_gt files Jani Nikula
2021-09-14  9:16   ` [Intel-gfx] " Jani Nikula
2021-09-14 14:46   ` Lucas De Marchi [this message]
2021-09-14 15:02     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210914144601.pws37hme5v3teqyg@ldmartin-desk2 \
    --to=lucas.demarchi@intel.com \
    --cc=andi.shyti@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.