From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34C5BC433EF for ; Wed, 15 Sep 2021 00:17:40 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D1A461212 for ; Wed, 15 Sep 2021 00:17:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7D1A461212 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6A6A181E1C; Wed, 15 Sep 2021 02:17:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="pGh7PHjw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 00119829F9; Wed, 15 Sep 2021 02:17:33 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0613.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0e::613]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 89B2581BC0 for ; Wed, 15 Sep 2021 02:17:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A6Z2MHOUpcmFmLhGvfG4QqaMikn+qyrokTPvmIYwHCG+n2zy1udVsOP2hbPtzcfKOThlxNQZH2JjROf+ze9jUXMjFcNUWXE+5sLGvni8x67GaznuQwKVGB8j1DjofUqS5nQ75pFRFG61uAEqcmoVspRp7fLK1rYpdggtDcxcBR7B4uoep2/iJmfhGaw5foNXzk7G8Z/ICnYizFpNY/6g0ZyxG3c5lY3g4mrWZMQh5sp2zOK1Z9PlYdmAoVFfh1/67+O3C5Xt7xGhQBJUCWTQHU3ezwqy01UkvoiGQnJBAgJt8JTlFSBFTRWXxSz2RtDOD+u2AHWSz7FqPAp2ZkZZyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NnFcBm1BC9urNuprm29F10LRbRsNi2fGEzxlKS/8FV8=; b=KdBC/XH0ZVsJQBtQbemKm3ybNzHx8ELJy2JyJ53nqLSa38zOuVQJcvXVACD+kDJqyZq/AXTnC9uXsGlGYcFqWYzKvHjSK4LxYym0eybS88cgpzGGkIRkPr+PVTjVowir13C33Jj4701wLZMGopiLMRA8UO11l8lGLsMOIM066h4Mb8GrvfMNFJC39Gs7A0zsv7/xXJ9v1j2X7KRJY8pK/od+fkta7j4BMXuQmCDzsqi6RXiD6ht8768jDB5aNuD/07FESF/BKCNaZYedzBau7TlRGEnlctLxBFWtZELRzx+pgLBsHJ4s76+5mmkSchYNMhGu2abEYNbEcsRqQccEAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NnFcBm1BC9urNuprm29F10LRbRsNi2fGEzxlKS/8FV8=; b=pGh7PHjw0FJm1NMxXAruguiqWyppwjjUBMXFboqldwBUVAqCs8Y0IjQrNHBEywl11efXvfHghg+cAEdgHF0aJIRrEHt/LdM9l22FLk3VxhFZBj/8hdD03JSwzTghVYqbYH3BsphD0Y/PJABPvZ12fHhTE2qbzBX7FqMU6Y7+xe4= Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR04MB4223.eurprd04.prod.outlook.com (2603:10a6:803:41::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.17; Wed, 15 Sep 2021 00:17:29 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 00:17:29 +0000 From: Vladimir Oltean To: Michael Walle CC: "u-boot@lists.denx.de" , Jagan Teki , Priyanka Jain , Tom Rini , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH v3 27/29] arm: dts: ls1028a: drop non-removable property from esdhc controller node Thread-Topic: [PATCH v3 27/29] arm: dts: ls1028a: drop non-removable property from esdhc controller node Thread-Index: AQHXoBoXCHJm9MfVHUiGWKlCluSTequkTeyA Date: Wed, 15 Sep 2021 00:17:29 +0000 Message-ID: <20210915001727.vf2jis6dfmq4ibgf@skbuf> References: <20210902164558.1920849-1-michael@walle.cc> <20210902164558.1920849-28-michael@walle.cc> In-Reply-To: <20210902164558.1920849-28-michael@walle.cc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: walle.cc; dkim=none (message not signed) header.d=none;walle.cc; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7ef174d4-3487-4587-3af3-08d977de3484 x-ms-traffictypediagnostic: VI1PR04MB4223: x-ld-processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Jer0cTRBgb5sLtBefd7FYKZVbktOTovaA46Qr4pGRizAumFT7HADC6zsVawYHt/kS/xYiRw1EoW3XNozKmvUBiHxHKMfEy4ODh8dH2H/nUCXZyt/lxp+xW42Dmwf5jssFuecB81mJS4nmA/3C/ZVNobi2ZJ1Th1plIrUa+I8a9zBk82HjAzxH9/uaYZhppoMhVoCKItxCOk0wQ6vLx0qoTJr4ZLnMobokAYdhitdEuBi0d81uH9v65FNXkHVYquIiNh5WPMdBhnIRi8kJ4jIFLmzo4i8GA5Yi4b6XiktPse1Ch5sN/vqHVcRtY1KaO9qlSrrgqvIiTxTjcTtneqCCXsWFviv/1vQV6eThtkAuPOnu5AbYNkPLCGuSmUgpibblnCmBVauhPBgyt7veSFz4QzuZQ0R9Yo12cXiJmzOxiTU0qQE1Oa/gBOVY8nyfacwfqxlkzdqCpTqzZMTPiwunJ0L/V662aojAnofhREgpNMKu8OVdgkjINfsXVuxE3cuhB14jI3KHIO1hg/kTuEbh+tFLdBj1cprpCoOrhJ+OqoN1FopZ2n7D2VC+AMRITHoJXKQjHl8BABWeWVDNVSjtWapTVAmx///GmGbcNzo+ngSaYPaOe35q+/8qcT1ExuOR9bLIGLaOCNud9355hpe0up6SbFYhpXd5PzDHnQ5K7IZ3TeHV0q73AwKJh8RBuIW0pimjJJA/PEytjEQsvispw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(7916004)(4636009)(366004)(39860400002)(396003)(136003)(346002)(376002)(5660300002)(26005)(6506007)(8936002)(38100700002)(6486002)(1076003)(76116006)(64756008)(66446008)(38070700005)(9686003)(6512007)(186003)(4326008)(66946007)(66476007)(8676002)(122000001)(44832011)(2906002)(478600001)(6916009)(54906003)(71200400001)(83380400001)(33716001)(91956017)(66556008)(86362001)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?v706uMHTMy4L0uQD9XnXKRCJOhIUNMYYzl+acB66GbHALliCdpyFnSRik7tC?= =?us-ascii?Q?gAqhg6uSKUnfXcCLF9ERqFZk7bv8zOXZm5KmZ82CQ+pisHFPPH8nRoLdCWVq?= =?us-ascii?Q?yrt6QY6VaPXpejuRduAXHbW2ltr9t4Ywg+gWdGvtsLH60W3t+s1k0eD/BYCR?= =?us-ascii?Q?T4+RZzuCwLKD3uWKW70qFVv/yNUu7O5ljoGtN7dpmt+LnOVtKhTzGWZhxavy?= =?us-ascii?Q?SYnjbxbAjLgILGfO0LAEvkPMDltZEj32dDORrUSYe14/NnG17Ob04ptZMzQB?= =?us-ascii?Q?87dTTHf3tKchO7MmY96aq6pvsGBLCSaH4Lw+bxXLvb8f3fOSOAs3l1HJDu+y?= =?us-ascii?Q?j4u7WIADuIwpzh2jfgx4GQJo75wjk5pEf2t6/FcoZ6CThFJZjEeW1burpzSq?= =?us-ascii?Q?XVDnZFAxGgw3RymBk0FLj13T5tpe/CJHLEK+Z/q/tK/k0NSsvp+F8O1L3HG3?= =?us-ascii?Q?7/kKCDmg3JxghwolI6LTIPF9ngqilet74sMquPzrYjy1VwgW+S1+jRZp4rKj?= =?us-ascii?Q?JqMJKfqtuJqZwvQKVpuiBfM0iPX7yv1Kj+xSWZvfc2RVhLbF/xQQKkLM9g0T?= =?us-ascii?Q?LCJtb51CDEEyqxs16Cl1y2wJTYzIBv+NAKMgViJRRA/dup5GQNygbKwK61Qq?= =?us-ascii?Q?AR7n5afOADzh7Ew4YTiopj80cOAQ0tkJeJIVwn3HRLuLgt98N2WTot2mhvYi?= =?us-ascii?Q?ybzEhsBs71+9ylbOzK0jxyZgu23fviNC1gxAzt3SVQ7mJCo8S3Vme3qmAZYx?= =?us-ascii?Q?JV+zDFXXppkTMsejbE/jTCZu71GDOMRRQPp/PMYWx0CfenWfvM39kSYqx5Rj?= =?us-ascii?Q?VWs4b1dC3YhkdTGl3ptHrpmoAs2/rkLycAOrpkx+CfovUr95ktJRDsu2Hvhh?= =?us-ascii?Q?6in+iswCBKiVb7N8OK72aTR/AqDFjw0zDx9xPawnHCOnmoCFWpkiQFi28JYu?= =?us-ascii?Q?9FD7tyh/mDfZJZeXROQAPypZKqroasGgqKKCQRXPFRF/CAMwdQoTYWUbFhfQ?= =?us-ascii?Q?h6/GPRraEjWigZFgZK1PRFlyjM/iVtNtEEgerW+MnSM4gXNYchG4/G7ExI3v?= =?us-ascii?Q?Ndw0arPCO9eGGRIV7tjesNrbekC3z9iWrtAhNUUCYyD19BrPRb7agqXIIdKl?= =?us-ascii?Q?TGWTaq6PUNhMnooUX84/LGzs4sDJ4g8hWBRahRvUd9iWzzXZcg7TBAnIMZhG?= =?us-ascii?Q?aNoqFtHZiDk/ne2QY0UVsivnRfIsPaW7dBo3SipGx36GWh9eINDd1qG/vuU9?= =?us-ascii?Q?bP1bxvLuLeUL7InRemEFJ3rStK7aNmYlv3ylwqY6K/WdIlz8KTE3gdo8PrhB?= =?us-ascii?Q?Agp5plp/4bT1blFAV6YsF0Mc?= Content-Type: text/plain; charset="us-ascii" Content-ID: <3C1578C773DB6345AF267BF5020041BA@eurprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ef174d4-3487-4587-3af3-08d977de3484 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2021 00:17:29.6042 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cr8wCcWVL8diViClMo5q3x5vQdVf2a/XBa4ZdqwxEhkHMhxu+ALi/GVMxwoN52mk1LTH6RpMeqgsjJJR0XWPmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4223 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Sep 02, 2021 at 06:45:56PM +0200, Michael Walle wrote: > The linux device tree hasn't set this property. To be similarly we remove s/similarly/similar/ > it from the u-boot device tree, too. The second controller of the > LS1028A has indeed no card detect pin. Because it is an eMMC controller. > The present state register of the > second controller will always report the card as present. Thus, there > should be no functional change otherwise than one more register access > to read the present state. Tested? > The property should still be introduced in > the linux device tree. How do you feel about dropping this patch? >=20 > Signed-off-by: Michael Walle > --- > arch/arm/dts/fsl-ls1028a.dtsi | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/arch/arm/dts/fsl-ls1028a.dtsi b/arch/arm/dts/fsl-ls1028a.dts= i > index d2f558d208..af6dabe847 100644 > --- a/arch/arm/dts/fsl-ls1028a.dtsi > +++ b/arch/arm/dts/fsl-ls1028a.dtsi > @@ -210,7 +210,6 @@ > reg =3D <0x0 0x2150000 0x0 0x10000>; > interrupts =3D ; > big-endian; > - non-removable; > bus-width =3D <4>; > status =3D "disabled"; > }; > --=20 > 2.30.2 > =