From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60289C433EF for ; Wed, 15 Sep 2021 10:36:56 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FCDC610FF for ; Wed, 15 Sep 2021 10:36:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8FCDC610FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3C29E82849; Wed, 15 Sep 2021 12:36:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="Nq/51lY+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C67B282039; Wed, 15 Sep 2021 12:36:50 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0617.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::617]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 70EF782BD6 for ; Wed, 15 Sep 2021 12:36:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OGfdvWH57wRvy/TanDSm2T1W+1ain1EBF3ZXFiah/lcCTNWf/f2itaGJFfPiXXQst9/O6qReY4mx4SOboNPGB/kzP/Y6nNuZIL2SGrMiUMzXPwgcizFCwpbFkmxwaGEr+wqwsfonvip/mvtzdmgJ6v8+LjbDBOgMtqihDifZVcJhWwA4vONaqy1TCOw9bEXs1VgBQGOuTBsuAidXtGVMd3Hz9Cm3/R/cvzm/+aJYwDe+1Osxgn6s3Cij/7XXJ6mGj0zLvNE+C0KMtQGxYJN9do+C2KHVqn3/IuG5IXrfpk/LeV03iFfRDBJ8Rb3f/uwHKHUkimklWbfYX6hqamKURQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=55aql8LehSZKi7/IC/WrFakEqjVXXMCZKd2g6u8g6vk=; b=kBwN/Fi+1iNTPrJkcbT/XieNsoePEFC2mEbIoE79UmiXk2MMr3YqiZX8snZQcuSv7LSU0+ZJlARkR4/O/kfvFhMGsSO1buUt8ehbr9NewfwHFEhl+Mhp7eMVDbac66Hkmpv4SOhBhW6ESg5hK3M9Uzbs7wx08tU4CnYUb+ovXC9XQYNBLe6K9w4rxfKNiS5lHburufsaGb7ZZBjXgD/zKiEYyT8zm0p9361GkD2lFTgbk4YkwgCiEQvRZEJuSXXEBIovHaMXJekWTyZKvPhX4JHqA6Hxv3r96eo0AiR5yFWo/J3/CLTElqiegAwlBmSSTJvqQH6V8LO21H641b4+uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=55aql8LehSZKi7/IC/WrFakEqjVXXMCZKd2g6u8g6vk=; b=Nq/51lY+JHt1VDKnhPHT5lqL2UXZhj1/TfRNwI18LU6p+c41nOXwLNpvc/7qD40cr+AQTuUS27kIBAkQAS2a7l8HJX4btoj7MLiNYzENIiBEKiepjzf1F7Fif/P/C4WBN26uv5PqCWVZ7zaEYMFucp5YOVNf/SK7voHWEHYodhE= Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0402MB3407.eurprd04.prod.outlook.com (2603:10a6:803:5::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.17; Wed, 15 Sep 2021 10:36:44 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 10:36:44 +0000 From: Vladimir Oltean To: Michael Walle CC: "u-boot@lists.denx.de" , Jagan Teki , Priyanka Jain , Tom Rini , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH v3 27/29] arm: dts: ls1028a: drop non-removable property from esdhc controller node Thread-Topic: [PATCH v3 27/29] arm: dts: ls1028a: drop non-removable property from esdhc controller node Thread-Index: AQHXoBoXCHJm9MfVHUiGWKlCluSTequkTeyAgACD9oCAACkQgA== Date: Wed, 15 Sep 2021 10:36:44 +0000 Message-ID: <20210915103643.bffuyiv2bv3utj3l@skbuf> References: <20210902164558.1920849-1-michael@walle.cc> <20210902164558.1920849-28-michael@walle.cc> <20210915001727.vf2jis6dfmq4ibgf@skbuf> <821a30e635e5c2b78f283342cbb9b883@walle.cc> In-Reply-To: <821a30e635e5c2b78f283342cbb9b883@walle.cc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: walle.cc; dkim=none (message not signed) header.d=none;walle.cc; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a1b5f917-a232-484d-b98d-08d97834b695 x-ms-traffictypediagnostic: VI1PR0402MB3407: x-ld-processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pYpwbgtJvHM6CDzv2396LiScJof97txb7TqRLJgYMV4pucgnzC2EW83niCPJsqKrN92poiSMuB8FZngvHX+k1bMxL0OolowoU7bvDj0l+gRwHvt1zPKipJITZKiyyLv7fCezyp5EuZaQVlXlwBxPZLLQZSRd3+zCeIDu7nBOrb4xiSqqH7TUl2nBHDPlaCWJgEiiw4/+RhTUnCJLxtKZeQYPh0rLwXvx6h514PpH+7M/cw29xhtS2DcLRYMCT9a7o5aIn0nf+1Tv3F6Jw/kaLggiLlK7Kg4gWBlnwNoLgIHFgno+j4u3hKjRlXVNmCh/QfpmNcRlnVl0+arStKlY0Cv4t2r2eLMBrmJwri7E0sbJJT5jVKzoBlKsreDdU9tJwGAx54AVqdlZ9HEQ6Mr7+3ZzDm7zHEUcwfwCEmcUvsluzOL1FdmZgAPJe8RxRI0PCtYLti/Dyl7vkmuMl866V5U6UJ9Xh+zrjBnTRj+l2f/ksrAcX8UsTIu0I8joEQcY7KjsozLZk+hJupxQZlYacwVXbNwS1F5lpK6ZZ0cjszIyEZ3Mi/0ms/XLTGb0c8+dNJ9P0KeeTOA9u1YpVgPtd/vwJ8biqoi79W6JzNOu/BJrNKBRRimWJqzxN2sQfqA2DcoKPSkeWNVckQOYVgIy9q9zeIYe7Ph3b++TQxYziNrIa/ZGcZNO8kgyxTp7NMhxnIXFUFSe2lwGNK1Nrxj5QQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(7916004)(39840400004)(136003)(346002)(366004)(376002)(396003)(6512007)(2906002)(91956017)(71200400001)(38070700005)(122000001)(54906003)(9686003)(316002)(26005)(38100700002)(33716001)(186003)(8936002)(8676002)(86362001)(6916009)(478600001)(4326008)(83380400001)(66446008)(6486002)(66476007)(6506007)(1076003)(64756008)(66946007)(76116006)(5660300002)(44832011)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xufQZEBJIQJ0N5KbicOxy0sIQfGw5+Ze9jLhxGLOexYtqhEWNWgRtdy6b4NK?= =?us-ascii?Q?yCtyLGYUBJamXjXeR2xgJFCnbKKH12Vtq8ZcAPaK8fTmLG7Bcd/TWbHnUa7M?= =?us-ascii?Q?hCx6F0/eK37QffJ9RfWrLSlF+8XBA8dKf8RUD7YB5plhliO/qfBm93G2Nf3i?= =?us-ascii?Q?l2sFoPL1w6ig74Uz7R+yc3crj72+lIU/bLQOI+i67knPp1tktuDdrhBrBZS4?= =?us-ascii?Q?WvE5gG/6AzUr5q8Eyu3aqtVzjT/frhaAlfFpqckPGb7CIhTshgXlPF2JvHl/?= =?us-ascii?Q?X6YHITfwbVcWDk9/4EnBE3SB0osUauGgQn+/z+a+zGu140lgpYqGtj/26sL2?= =?us-ascii?Q?g3M7xTpkp2A41+jB4ylt+Zrm1BoizPXl70cy4IvroeivQZe4p6NUoSXOnG55?= =?us-ascii?Q?q2+pa/ZB96PVQNkXzE5temTv6Fxp38tgbnxztkwja9xX1BBdgTMx4db2rNQ/?= =?us-ascii?Q?+SoGOCfD7Uuw7OgT3dlQFtB6HQV5+3sFoy7QQ8WOy9U2DMLczDAygKelF24Y?= =?us-ascii?Q?aiQpeOiIY28exAu7pNftMglzJ/xhzqrERzKqfS8intR+0huMpQN4JO1cRn0z?= =?us-ascii?Q?aaljm5WsQFN95Xa+xudmLraEPPpiY94/3zQFRHIy4/R6MNGGjQg2hGhaGyoi?= =?us-ascii?Q?CtUWZNPeUsahhqPdIWI6S5wZ3A0+siBWQWRpupOo5uludYz9oga4fxI+ESZ0?= =?us-ascii?Q?VKAvVIWjixImoaoBk7SYkGH4tE+d+kzRfCy46JD7DbPwm5UkaaqIh9QKfJw6?= =?us-ascii?Q?X0gsnLmbdXN+wSpRCY61gWddp1Juo7TE246mrYLCvd/dNzEAmn+7IAmOd0Xr?= =?us-ascii?Q?Jc2hzclNpMHYwz2lvoNXAo1jy4iFhOr4bHmqz9b/psgunDcwoze9ryVa/6a/?= =?us-ascii?Q?VP01o6odVBkO5tWEFO6dT6SZlbh5HP7/U5Gq/1GAA3Er0HHCph8AecKGkkUi?= =?us-ascii?Q?SZFT14JJyI1bisBtYWh/LnY3/m/adRjiRqq8DOdc941GoeQkYTDd0nAFjWaD?= =?us-ascii?Q?XmbcAwlE8PcLxtvc2UwyI7u3KcV18hynjrDeUvz4YKI4FGHMJfc2UjuVz+sg?= =?us-ascii?Q?JCIRXvD5Xzpm6gWgKztAhvuNSXaEx2ooOkLOiH8C57BuauYUPID1p5/zc/va?= =?us-ascii?Q?vleZPgcYccrqMmYh9GqkOHFyH7c+BPMQ47+bahDhr0NX8cx7zcjwKxAnGhl+?= =?us-ascii?Q?ZNRMsIKBmHkzctII0DU54GSmJJtgCYYNdhEjAnwx3Y1JkKsTV44pGyXami39?= =?us-ascii?Q?WaHEEMmXu9DBiTX21XtZlMr4ie89035xgKh8Ai2GFGkKtYJamQ6j8dX2MjRQ?= =?us-ascii?Q?7+/9lf56yoSpnmnxh9Qt3KQK?= Content-Type: text/plain; charset="us-ascii" Content-ID: <5A20E4362669D3409FC663FDF1BE41A9@eurprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1b5f917-a232-484d-b98d-08d97834b695 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2021 10:36:44.5354 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9pcpplelVkF9n4waWX7lBHGhLSdGuStBWrryL4ZnhbJ+ECRJYFsVv8BnVlT7iHGUDDRZfo1hr+ZBZPzGKQzxog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3407 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Sep 15, 2021 at 10:09:45AM +0200, Michael Walle wrote: > Am 2021-09-15 02:17, schrieb Vladimir Oltean: > > On Thu, Sep 02, 2021 at 06:45:56PM +0200, Michael Walle wrote: > > > The linux device tree hasn't set this property. To be similarly we > > > remove > > > > s/similarly/similar/ > > > > > it from the u-boot device tree, too. The second controller of the > > > LS1028A has indeed no card detect pin. > > > > Because it is an eMMC controller. > > > > > The present state register of the > > > second controller will always report the card as present. Thus, there > > > should be no functional change otherwise than one more register acces= s > > > to read the present state. > > > > Tested? > > Yes, I've tested the eMMC (and actually using it this way). I also > manually read out the register value and made sure the card detect > bit is set. > > > > The property should still be introduced in > > > the linux device tree. > > > > How do you feel about dropping this patch? > > If I drop this patch, I'll either have to (1) keep this property > the device tree sync patch too or (2) it will be removed without a > comment in that patch. > > I presume you prefer (1), but as I said, I'd keep the device trees > between linux and u-boot the same and keep it simple by just copying > the files. So yes, I'd like to keep this patch as the point of this > patch is to give an explanation why this property is removed (until > it might or might not be introduced in the kernel device tree; in > fact I thought I had send a patch to the LKML but I must have > forgotten it). > > I was thinking of putting it into the -u-boot.dtsi, but as there > is no breakage, I didn't. Ok, but we should still put "non-removable" in the Linux dtsi soon then.=