From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C8C6C433F5 for ; Wed, 15 Sep 2021 11:50:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E60FE61246 for ; Wed, 15 Sep 2021 11:50:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E60FE61246 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:40186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQTR2-0004f8-W9 for qemu-devel@archiver.kernel.org; Wed, 15 Sep 2021 07:50:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQTOH-0002Mc-El for qemu-devel@nongnu.org; Wed, 15 Sep 2021 07:47:49 -0400 Received: from mga14.intel.com ([192.55.52.115]:2234) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQTOE-0000ak-6D for qemu-devel@nongnu.org; Wed, 15 Sep 2021 07:47:48 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10107"; a="221958673" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="221958673" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 04:47:38 -0700 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="544811253" Received: from yangzhon-virtual.bj.intel.com (HELO yangzhon-Virtual) ([10.238.144.101]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA256; 15 Sep 2021 04:47:36 -0700 Date: Wed, 15 Sep 2021 19:33:38 +0800 From: Yang Zhong To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v4 23/33] sgx-epc: Add the reset interface for sgx-epc virt device Message-ID: <20210915113338.GB30272@yangzhon-Virtual> References: <20210719112136.57018-1-yang.zhong@intel.com> <20210719112136.57018-24-yang.zhong@intel.com> <77caedf9-31bb-c245-d5b5-20b9792a57ed@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <77caedf9-31bb-c245-d5b5-20b9792a57ed@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Received-SPF: pass client-ip=192.55.52.115; envelope-from=yang.zhong@intel.com; helo=mga14.intel.com X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yang.zhong@intel.com, seanjc@google.com, kai.huang@intel.com, qemu-devel@nongnu.org, jarkko@kernel.org, pbonzini@redhat.com, eblake@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Sep 14, 2021 at 08:53:48AM +0200, Philippe Mathieu-Daudé wrote: > On 7/19/21 1:21 PM, Yang Zhong wrote: > > If the VM is reset, we need make sure sgx virt epc in clean status. > > Once the VM is reset, and sgx epc virt device will be reseted by > > reset callback registered by qemu_register_reset(). Since this epc > > virt device depend on backend, this reset will call backend reset > > interface to re-mmap epc to guest. > > > > Signed-off-by: Yang Zhong > > --- > > hw/i386/sgx-epc.c | 94 ++++++++++++++++++++++++++++++++++++++++------- > > 1 file changed, 81 insertions(+), 13 deletions(-) > > > > diff --git a/hw/i386/sgx-epc.c b/hw/i386/sgx-epc.c > > index 924dea22f0..9880d832d5 100644 > > --- a/hw/i386/sgx-epc.c > > +++ b/hw/i386/sgx-epc.c > > @@ -18,6 +18,9 @@ > > #include "qapi/visitor.h" > > #include "target/i386/cpu.h" > > #include "exec/address-spaces.h" > > +#include "sysemu/reset.h" > > + > > +uint32_t epc_num; > > Missing 'static' qualifier. Philippe, thanks! This Qemu SGX reset solution will be replaced by kernel patchset made by Paolo(https://www.spinics.net/lists/kvm/msg253930.html). Yang