All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
	james.schulman@cirrus.com, lgirdwood@gmail.com,
	david.rhodes@cirrus.com
Subject: Re: [PATCH 6/6] ASoC: cs35l41: Fix a bunch of trivial code formating/style issues
Date: Wed, 15 Sep 2021 12:38:21 +0100	[thread overview]
Message-ID: <20210915113821.GA5389@sirena.org.uk> (raw)
In-Reply-To: <20210915105352.GC9223@ediswmail.ad.cirrus.com>

[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]

On Wed, Sep 15, 2021 at 10:53:52AM +0000, Charles Keepax wrote:
> On Tue, Sep 14, 2021 at 03:23:01PM +0100, Mark Brown wrote:
> > On Tue, Sep 14, 2021 at 03:13:49PM +0100, Charles Keepax wrote:
> > > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>

> > >  sound/soc/codecs/cs35l41-i2c.c    |   5 +-
> > >  sound/soc/codecs/cs35l41-spi.c    |  13 +-
> > >  sound/soc/codecs/cs35l41-tables.c | 477 +++++++++++++++++++-------------------
> > >  sound/soc/codecs/cs35l41.c        | 387 +++++++++++++++----------------
> > >  sound/soc/codecs/cs35l41.h        |  81 ++++---

> > This was upstreamed with your review a week ago :/

> Yeah sorry about that, they are all trivial patches (with the
> exception of the first patch which I did only notice whilst
> fixing up the other stuff) it didn't seem worth delaying the
> series for another couple of rounds for such trivial commments.

> Apologies if that was the wrong call.

These are pretty large changes, it's not just a couple of small cleanups
- especially this one is pretty huge.  Also note that Rob found a bunch
of errors in the DT binding that need fixing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-09-15 11:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 14:13 [PATCH 1/6] ASoC: cs35l41: Fix use of an uninitialised variable Charles Keepax
2021-09-14 14:13 ` [PATCH 2/6] ASoC: cs35l41: Use regmap_read_poll_timeout to wait for OTP boot Charles Keepax
2021-09-14 14:13 ` [PATCH 3/6] ASoC: cs35l41: Combine adjacent register writes Charles Keepax
2021-09-14 14:13 ` [PATCH 4/6] ASoC: cs35l41: Don't overwrite returned error code Charles Keepax
2021-09-14 14:13 ` [PATCH 5/6] ASoC: cs35l41: Fixup the error messages Charles Keepax
2021-09-14 14:13 ` [PATCH 6/6] ASoC: cs35l41: Fix a bunch of trivial code formating/style issues Charles Keepax
2021-09-14 14:23   ` Mark Brown
2021-09-15 10:53     ` Charles Keepax
2021-09-15 11:38       ` Mark Brown [this message]
2021-09-15 15:21 ` [PATCH 1/6] ASoC: cs35l41: Fix use of an uninitialised variable Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210915113821.GA5389@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=david.rhodes@cirrus.com \
    --cc=james.schulman@cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.