All of
 help / color / mirror / Atom feed
From: Adam Borowski <>
To: "Guenter Roeck" <>,
	"Pali Rohár" <>,
	"Jean Delvare" <>,
Cc: Adam Borowski <>
Subject: [PATCH v2] hwmon: (dell-smm) Don't build the proc interface if there's no /proc
Date: Wed, 15 Sep 2021 16:38:01 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Signed-off-by: Adam Borowski <>
Guenter wrote:

> This should be expressed as Kconfig dependency: I8K should depend on PROCFS.
> Otherwise the configuration flag is misleading.

Right, I did not notice I8K does nothing otherwise.

 arch/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 4e001bbbb425..a7365695ff72 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1253,6 +1253,7 @@ config I8K
 	tristate "Dell i8k legacy laptop support"
 	select HWMON
+	depends on PROC_FS
 	  This option enables legacy /proc/i8k userspace interface in hwmon
 	  dell-smm-hwmon driver. Character file /proc/i8k reports bios version,

  reply	other threads:[~2021-09-15 14:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 13:47 [PATCH] hwmon: (dell-smm) Don't build the proc interface if there's no /proc Adam Borowski
2021-09-15 14:20 ` Guenter Roeck
2021-09-15 14:38   ` Adam Borowski [this message]
2021-09-15 15:16     ` [PATCH v2] " Guenter Roeck
2021-09-15 15:17       ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.