From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mQWbC-0002BS-3l for mharc-grub-devel@gnu.org; Wed, 15 Sep 2021 11:13:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQWb6-0002AP-Ox for grub-devel@gnu.org; Wed, 15 Sep 2021 11:13:17 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:22006) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQWb2-00051k-Bs for grub-devel@gnu.org; Wed, 15 Sep 2021 11:13:16 -0400 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18FF5lll011618; Wed, 15 Sep 2021 15:13:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=1HIfBNQpjI/XwOlrhn/AhLXHZeuArm9L9zRDmFBREtE=; b=wczG4aC+RVLB2KXpCg5QmL0qb68QrOt5ZGUDSjf0GpJ0btVOGFmsUe0QfptcgXP1pOK0 1BL2hnMJGwcYif3+q8Hv50z42Q3x7xXlMd7axpUjuUz5zdM5eWNxBy9dHKKcdiPZsnGx bTmP00EenFhOiZGwZImq0FlN04MaxkPj/QxDYtCudg2ybtE/ytU7xashoS/Wg3tg2IRJ YXMr1Sd1coaHeZpCWQTcUOQ+DnOIf18oxZdqdk+0ywhFAkiWPdOyb+nuvLS9xpVQklbj UiW3uG4XJa+uW2M5gqts3YK00/pyoo3zUqEXgVTXvK3IUg8G+H1rAPID6gti42c1ZasX 9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=1HIfBNQpjI/XwOlrhn/AhLXHZeuArm9L9zRDmFBREtE=; b=ADv4/GuZU2Rt+YmZ01GT37JRw1EHKuA76tgZ6QLJaAo8YUzfvpuQt7O164duhhoSrKVL HsCXNXU7qnUuJ1j8xzSW/BtDBBnHYVVc3vlPYyXzhh0fz/7Igk0yCGdqqqcXUp+eE0X/ Q3FeEK8iSFx3nWg5a7Z6prJS6Rlo0zhlQdQyRz1fdaVdmQJqNZpCU4JaI3zOjJg6c/ri MeGLVaECyGu6w5fZ6AkugZp5SQOSUZLlLtcBPMF/tgrlt6KG34IVSER5mhBe1knGnKHz oXo/+BlW7HxkQqaIAVbJpSvo/KymuUgYbfg+e2naoThIz7sMdeOVlZKOPeFLu1NP0zRt zw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3b2pygd0cm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Sep 2021 15:13:06 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 18FFBelM146524; Wed, 15 Sep 2021 15:13:05 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2175.outbound.protection.outlook.com [104.47.57.175]) by userp3020.oracle.com with ESMTP id 3b167ttjrb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Sep 2021 15:13:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TKJjX9GBZ53lSjcdyBC4snSGxhzaExBDBwCQqIJrKl+OMzUD6h5prG5v/IV5zA3LY+QuOjfuqSdvmcfNjMC2nc+EQaCKvUjV8UBSOULGolfGO1C6o01yD2As3ZY3uxLTDJZ+fvJ+XH10Dg6xvrofDxySwFfEFr/kYq4sqMJYuqgXzCDHVN7ij8Z1QVSI+VDbojKKBFZRAdlFgmScfxkkuKRg++Z2HdUVhCJCwHPn9Pb3T4BD5z6rDnCedHb4odNRecSYZdqgCUMldTtASqagjWI5gNf+04v3m24tKg3DTRglI/b6DSQCMWHpMwACLbi4JlttpeGB8592V22ANqS57g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1HIfBNQpjI/XwOlrhn/AhLXHZeuArm9L9zRDmFBREtE=; b=LlvjpdaIMTzk5/VGSI8bw8dlNaQxLsrr6HyMzVd1l+Er7sQA67OYBEB0+u/M3LFaGjYuN1kxx65aqs2VgpvIe1LhxwJqyvXZ26e4leKkt2UiVxQnwN+QLTyL8X2HKNPzjVbNf0Txk0DGBRGynEgu+ZLbT8D7jpjlyTbIwhvNcIgsxdIsB+hzNbD6toNcR3s0ieGF/a+qRsUy7OXgnrqOYMxYPovqaVpWDWDQpwDtZ1mSkC49fOY/DTHYxxRqFBa2AHPS0Z+G2mjr2pZ7uVt6jOgUtdnGwf7c0gFXlNjFJDggn+Wajwb/3uWNbsxsci23/zZymmkUzPke/V0bKexh/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1HIfBNQpjI/XwOlrhn/AhLXHZeuArm9L9zRDmFBREtE=; b=fMOr95uUIOP6EUZGnAe5QrefteQpzONjEbvajypK093a6vkk2dqf5/IyOEngvciy6ZY48AvjPPst9kJO1eqQd6lXZzrcvR4zqsdU/+O2n47wxcVAqgkoQrnHkiW/8ndewUrJkcHBbXK7c02Ao+nsqInO6BkiHdrF5Uqe/xVMpQU= Authentication-Results: z9.de; dkim=none (message not signed) header.d=none;z9.de; dmarc=none action=none header.from=oracle.com; Received: from BN6PR1001MB2228.namprd10.prod.outlook.com (2603:10b6:405:2e::38) by BN6PR10MB1940.namprd10.prod.outlook.com (2603:10b6:404:ff::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Wed, 15 Sep 2021 15:13:03 +0000 Received: from BN6PR1001MB2228.namprd10.prod.outlook.com ([fe80::3cca:22b1:cbcf:eeed]) by BN6PR1001MB2228.namprd10.prod.outlook.com ([fe80::3cca:22b1:cbcf:eeed%7]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 15:13:03 +0000 Date: Wed, 15 Sep 2021 17:12:10 +0200 From: Daniel Kiper To: chris@z9.de, kyle.rankin@puri.sm Cc: alexander.burmashev@oracle.com, pmenzel@molgen.mpg.de, phcoder@gmail.com, grub-devel@gnu.org Subject: Re: [PATCH] templates: Add GRUB_CMDLINE_LINUX_RECOVERY Message-ID: <20210915151210.lneu6b4tf6s3vsxv@tomti.i.net-space.pl> References: <20210914192506.64480-1-chris@z9.de> <5e6bda1b-8a86-8d9a-9e45-62314f3cdb68@molgen.mpg.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e6bda1b-8a86-8d9a-9e45-62314f3cdb68@molgen.mpg.de> User-Agent: NeoMutt/20170113 (1.7.2) X-ClientProxiedBy: AS9PR06CA0165.eurprd06.prod.outlook.com (2603:10a6:20b:45c::12) To BN6PR1001MB2228.namprd10.prod.outlook.com (2603:10b6:405:2e::38) MIME-Version: 1.0 Received: from tomti.i.net-space.pl (84.10.22.86) by AS9PR06CA0165.eurprd06.prod.outlook.com (2603:10a6:20b:45c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Wed, 15 Sep 2021 15:13:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 834b0059-cfd0-4ac0-74b1-08d9785b4ff4 X-MS-TrafficTypeDiagnostic: BN6PR10MB1940: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vhbh7jrT1mbe5tnG5kQOF9BGDOfqm/g3UwNYCbiskK8KyEzUrHlj2uZ+PuoywVce+prVtky31QUJizRIezwLZLiuPpZUvN7S9o7y/m6qMS/ZiBa8QvoxmgYTElvUjYsp91Z5HGOkryGbJRL9NCUal6VmN8T37s9bux8XvNG4TS/faKSOr7czL5DgAo59EzODC58lAV5jWEs5krtbyH85WW0OBESPXBrcJJiteHzB9c5CaxkZ4Nuz98Pm9ARMBmucoizSmzNKsFKsSPvlRspwkqgSzAo+GgihtThDGXTukCzyhj0BbogBKydbBb4YHHf4E3xzM2ma9wLmJRMX2dbhemXKJGgAqEUv1CfKmzbAemr9LFODUswJauufZaScm/pAFVfOWCBZkwYmdkXkxu8DtgIUqmhRUKufycwXJi81q8p/eDPm9aSKEs58+fzuWrIYQ9N7razZktkkIxRJ6WRxcmuYKDSDiiuqKpvtDiysLy8NLdDvZrU6zrirzHyN9DE9vAFyvk5v5sQKQQAITSyd64zwZgfwKnxLxXCsyj66TFEnPNNG8CnHO6QZojS00b82g5TBpo95atWHyPaOXl20PAh/RAdvfbkRKrKUELdeHn5mPS6gXVxrcNoKFQHgTu0WDoXViNzXERVkTBL5E3aUlzsL4f0mwDyjt5LG5SwoeIth58PcDXU2uGJEnFsB+uFMcDrrD7/rYrbTeUrN+ipyBQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR1001MB2228.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(9686003)(55016002)(7696005)(508600001)(4326008)(5660300002)(86362001)(1076003)(6666004)(2906002)(66476007)(66946007)(66556008)(956004)(8676002)(26005)(52116002)(186003)(38350700002)(38100700002)(44832011)(6506007)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4e7/Y1ggKDsOqaEClpOWMUtUrKWgIM8Ob/ibVwpkWrqGHG1/zo7DDak285Z8?= =?us-ascii?Q?Q5MtONwzZh2GuX3rqnV1EpfPBuJR0af1DpuIZTwbWILuQyzjIrYSCa89O9AJ?= =?us-ascii?Q?AMjVlFdm81JfswAeN6qU5o5CXSLhaZl0lUMoTy7+nO/8fFoAXRMzZbRbCo70?= =?us-ascii?Q?OTPLSZCWOeNJBgqgMbCvbbbY5jXhKK5GKvi4J7GJ6geQk61AAGPV1DuPDNIZ?= =?us-ascii?Q?9X4kMimJmqhOVwfGQ0na6+XlmVOdhUvZScbyFQ11DUGHFBh7bhkzDAl+R46X?= =?us-ascii?Q?3bqgWjzasJ1xyEQcekpdMTcXDPY3zfhBAyqd3nEKY8h2MxMQGq9KM2y8dMu1?= =?us-ascii?Q?vLVP7u1BNmBsN6AH/xtUhuUKLYMd1qrki6w63u4n0axrNjWHf9jrL+Ua6fSK?= =?us-ascii?Q?FAUIEtUqLRccnt3kX7kZ4YXeAniZstECm/3rMf5qFb1I2d4KxiaBpUV8xZMG?= =?us-ascii?Q?bS0/KxgD4n54EhcyNen8mZB9JBQ2B5FnEcLjv3JW3RPIwwE+lMdPyMAfLPZ2?= =?us-ascii?Q?tp6N5hrBaQo5cGQ/idt4zCpB3WLshn6K10mrm64Wd1PqWwzpTAuCdNm+wQZv?= =?us-ascii?Q?ZBYuBomQRJtgf9LKeIbk9cv9YQh9KrZa07ij8ticiF99wkxx7T1JxkjK7Xl+?= =?us-ascii?Q?FQcbNDlVYbyKwS98PE/GJ6szXNVHD8FcUuPRUwSwfXNtcF2ZgJf4Vh6j5Gxw?= =?us-ascii?Q?qqDS7dSKMkfbvZflar1hmxT9RLROHz+xXOz6W+lCwawnxj2Tt3C/Ewb86vTa?= =?us-ascii?Q?RYlV6j3sYPmWJ5BM9JkhlwyMK8IlWM1RSqFkbKUw4TGo1c0tuQ9kaUsDRIxC?= =?us-ascii?Q?Tc6CBNjK1LgwayR9Zr4o7pHL61g0ODFR6FcyWW1a6CaXdaBokX+wbpO7Ee+i?= =?us-ascii?Q?KRx0XtXHJz/zM/Du9RuEVSHhDKP0ypqTNuWCEwl98Kbg9MybQdPZYcA9POTd?= =?us-ascii?Q?0qbDT1lQg4eQb/Ia9PGMtn27zCMv7ilUF2DaZ0VGlE1iJtz4GrYlocN+Xcql?= =?us-ascii?Q?Aj5E9DcfYfwdL1mkgAutjzNzMsnfSWijz8ySiZXJO78D56nl+L+VrDb5wj7z?= =?us-ascii?Q?yOjlmw7WT9Ia5K7QZZvRccW2FseoqzWz2TrrCd1n5TgQ8Tyh+YraloqseTsP?= =?us-ascii?Q?8eIm1gn/nwItmfDImV8nJs+0MLyf8JqdWrLgyzamUM/nahZpItSJu8q03C+s?= =?us-ascii?Q?s99NsNsEot/cVPAot0uVjAkiwPtXjZZr6WrVM8aMTKgHSsCxAS7mQi9omfHm?= =?us-ascii?Q?21eJUdgcvf7VEjhpxd5jLWAOg1mjZL8hJpFkSprPlUFk9PR6KbK3Y9Jt2epC?= =?us-ascii?Q?1X5Zn0/JK9hYun5941nLakbp?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 834b0059-cfd0-4ac0-74b1-08d9785b4ff4 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2228.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 15:13:03.1641 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fqrYIxdS/reXSxpnbViVIyCylYLJuc/7OYoaNu0R1Z6NQAyNngPC9qbPdYOqY2VmQUKkUOhYS8pfV5UQgnc26w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1940 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10108 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 suspectscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109150095 X-Proofpoint-GUID: pL6C_ZsoaPOmI93INhH9ovJUxlu7sAhw X-Proofpoint-ORIG-GUID: pL6C_ZsoaPOmI93INhH9ovJUxlu7sAhw Received-SPF: pass client-ip=205.220.165.32; envelope-from=daniel.kiper@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2021 15:13:18 -0000 On Wed, Sep 15, 2021 at 03:18:40PM +0200, Paul Menzel wrote: > [Cc: +Kyle] > > Am 14.09.21 um 21:25 schrieb chris@z9.de: > > From: Chris Vogel > > > > When generating grub.cfg using grub-mkconfig and the scripts 10_linux and > > 20_linux_xen there is no way to add kernel command line parameters _only_ to > > the recovery entries generated. > > > > This is needed to e.g. start a debug shell in installations using systemd > > using the kernel command line parameter "systemd.debug-shell" or to recover > > in a system with encrypted root in situations where the decryption of the > > root filesystem per crypttab in the intiramfs image is broken and the recovery > > entry should contain informations about how to decrypt the rootfs (cryptopts=). > > > > This patch does not change the default behaviour of grub if > > GRUB_CMDLINE_LINUX_RECOVERY is not set. > > > > If GRUB_CMDLINE_LINUX_RECOVERY is set and the generated recovery entry should > > include the kernel parameter 'single' the parameter must be explicitly included > > in GRUB_CMDLINE_LINUX_RECOVERY. > > > > As far as I know all credits for the idea and the initial implementation go to > > Kyle Ranking of Purism. > > "Signed-off-by: Kyle Rankin " is missing here. I can add it before committing the patch if Kyle does not object of course... :-) > > Signed-off-by: Chris Vogel Otherwise: Reviewed-by: Daniel Kiper Daniel