From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mQYis-0001tH-CN for mharc-grub-devel@gnu.org; Wed, 15 Sep 2021 13:29:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQWwr-0007iK-C6 for grub-devel@gnu.org; Wed, 15 Sep 2021 11:35:45 -0400 Received: from comms.puri.sm ([159.203.221.185]:41676) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQWwo-0007hB-Gc for grub-devel@gnu.org; Wed, 15 Sep 2021 11:35:45 -0400 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 911C9DFA4F; Wed, 15 Sep 2021 08:35:39 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h8psfsw2T6Ve; Wed, 15 Sep 2021 08:35:38 -0700 (PDT) Date: Wed, 15 Sep 2021 08:35:36 -0700 From: Kyle Rankin To: Daniel Kiper Cc: chris@z9.de, alexander.burmashev@oracle.com, pmenzel@molgen.mpg.de, phcoder@gmail.com, grub-devel@gnu.org Subject: Re: [PATCH] templates: Add GRUB_CMDLINE_LINUX_RECOVERY Message-ID: <20210915153536.GK965@disp7009> References: <20210914192506.64480-1-chris@z9.de> <5e6bda1b-8a86-8d9a-9e45-62314f3cdb68@molgen.mpg.de> <20210915151210.lneu6b4tf6s3vsxv@tomti.i.net-space.pl> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6lCXDTVICvIQMz0h" Content-Disposition: inline In-Reply-To: <20210915151210.lneu6b4tf6s3vsxv@tomti.i.net-space.pl> User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: pass client-ip=159.203.221.185; envelope-from=kyle.rankin@puri.sm; helo=comms.puri.sm X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 15 Sep 2021 13:29:25 -0400 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2021 15:35:45 -0000 --6lCXDTVICvIQMz0h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 15, 2021 at 05:12:10PM +0200, Daniel Kiper wrote: > On Wed, Sep 15, 2021 at 03:18:40PM +0200, Paul Menzel wrote: > > [Cc: +Kyle] > > > > Am 14.09.21 um 21:25 schrieb chris@z9.de: > > > From: Chris Vogel > > > > > > When generating grub.cfg using grub-mkconfig and the scripts 10_linux= and > > > 20_linux_xen there is no way to add kernel command line parameters _o= nly_ to > > > the recovery entries generated. > > > > > > This is needed to e.g. start a debug shell in installations using sys= temd > > > using the kernel command line parameter "systemd.debug-shell" or to r= ecover > > > in a system with encrypted root in situations where the decryption of= the > > > root filesystem per crypttab in the intiramfs image is broken and the= recovery > > > entry should contain informations about how to decrypt the rootfs (cr= yptopts=3D). > > > > > > This patch does not change the default behaviour of grub if > > > GRUB_CMDLINE_LINUX_RECOVERY is not set. > > > > > > If GRUB_CMDLINE_LINUX_RECOVERY is set and the generated recovery entr= y should > > > include the kernel parameter 'single' the parameter must be explicitl= y included > > > in GRUB_CMDLINE_LINUX_RECOVERY. > > > > > > As far as I know all credits for the idea and the initial implementat= ion go to > > > Kyle Ranking of Purism. > > > >=20 > "Signed-off-by: Kyle Rankin " is missing here. > I can add it before committing the patch if Kyle does not object of > course... :-) >=20 Signed-off-by: Kyle Rankin -Kyle > > > Signed-off-by: Chris Vogel >=20 > Otherwise: Reviewed-by: Daniel Kiper >=20 > Daniel --6lCXDTVICvIQMz0h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEETW6NlIuQhx75ri+skasyRbHRSr0FAmFCEsMACgkQkasyRbHR Sr1IMhAAq7D4Fdr+dDxNjweHqENh3Hj/3Ij6vhknc8Dr7GR/gaKyiAP34fhAY7Pv hORg7CRoM2aSc/SloGd7BraSjalInisJwHNQYyOz85dfjBvsJxUsR49Hg8nrymum wJPoZMpxcxW/JSdzhva6yz3FKUhTV8g1s277ES7pIHqxmAJVZ0dfH5FMeAD1V7yv HICwBowthuJXvO0iR3rrWwY+g1gThA6ewd1Qixac6Q+75aBlEG05a3N3+H0drJBw OIYlRwHlK/G9fhpbfNEEO7heVsjSwDomU3dYsi7hmbhRQeJvEyoTQwOtjcsgJDfv JdfHogAEQhkqNSnhsK13blpWGbYxWt5phwD84mVoj0le5bV9G519jOwNu8vW4ek+ pCWhqb4pKwqRdI98uAvuHvUfAwJ7A05WWTI8go14HuHQhU4smCsy9QsrohvIyIZ9 NFSCZiIkuETMBGS0Hld8G0Bl3PMzD6z62pLgRdckfBjSjpN89mn9zxqAwcNvEvXU Zd8pxef7pfvhz+efX4TF7UNkJR+t+LQOUee0vkLbsr65G0EWY7U0XgPMItJkwZ0W WgIGE3lBSkQYPndyCC73COdkX1umwbA3RGUUcbDnAJblbuAIhdLD6F6Nx+aDzKA1 /Pf89Whke4DPPYcqBkymjs1Q0/B8X/a5CWS+rbXuY+y5nHG5CXM= =YIjG -----END PGP SIGNATURE----- --6lCXDTVICvIQMz0h--