From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7711C433F5 for ; Wed, 15 Sep 2021 16:40:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A37D960FA0 for ; Wed, 15 Sep 2021 16:40:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229962AbhIOQmH (ORCPT ); Wed, 15 Sep 2021 12:42:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229898AbhIOQlz (ORCPT ); Wed, 15 Sep 2021 12:41:55 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EB45C061575 for ; Wed, 15 Sep 2021 09:40:36 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id j18so4219598ioj.8 for ; Wed, 15 Sep 2021 09:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/16IPATfLgdmiX/J8L+UemcIsELjpW//BCTY5UOTDZc=; b=F4lYbdy1XsW0VGz/Rzh+Aj72ATUvnLbalD6Ptxz76xKFknccKr4/wNjNNRxA3f+rOO cAhMSwo4XDdnHamdzMuLRquJ1avmiwtnTl55cs8KGZY/swZQDWzGHa6rRlvBdAcpjlXf XCTpPYWxBvGK0pq9hFa6/TFkehZJ2DMble4ADj5SNb9YE4pVsN9XG3KDDlmp1wSlZM/j VZ6qfhPUzGjNacIUClrpXGhFIfwsDaWu9KcP+CoxSEH+bXnFwf3YrbETpDHh0fmpCNQR 1guofFqzln+fFtLDfrs/2gq9fwfOlsst+Ka0U+X5CcDx82LeMKryhPO7j3x8Kc+p9VB1 20ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/16IPATfLgdmiX/J8L+UemcIsELjpW//BCTY5UOTDZc=; b=nWLesb/SRXsRI9hLCnazYzqSi8489zvcU3A4rS8r8rBzwYEvsSwxMTrSqsoRFiFIKJ 2ziKwNRk7fATc1aVm70oLq/UAM7eJ/I46fJM4ulMmIx6naBV3HEjpiOuL7qIqUDSYKi3 O/g1WTzOnIatJvVrmuB+/oAVhSk05XIH4T/XwR++FH10anShYZg9EtBHGr9Gmre38yff r+m55ql3M/5WWhmJmJC9xmBTq3KFMTPcp9tViza9AbuYtb0W8KyALSZ5K2SvblitfUb/ wfrK7RdY+7sdwZhKZD68nacX0qXnphP9cF4ENci+ryjUfiIEj7UnlfzK+/7w2IjZ0N+R FUmw== X-Gm-Message-State: AOAM530T2butiZ1d3lrODIRjekucXwl+3Y6vyMxR+f0+dOZfJHPXqH2T pD3AzXeYYYb0/AVDXTgzWlA= X-Google-Smtp-Source: ABdhPJzarxX1asWC2Hsxhbo5NFnL6GctWrBgWA+45Dvv3G1LUT0QkB+r4NenYOzwUgzCOEmqwSXLsg== X-Received: by 2002:a5d:935a:: with SMTP id i26mr767362ioo.79.1631724035933; Wed, 15 Sep 2021 09:40:35 -0700 (PDT) Received: from frodo.. (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id a5sm299540ilf.27.2021.09.15.09.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 09:40:35 -0700 (PDT) From: Jim Cromie To: jbaron@akamai.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel@ffwll.ch Cc: Jim Cromie Subject: [PATCH v8 06/16] dyndbg: no vpr-info on empty queries Date: Wed, 15 Sep 2021 10:39:47 -0600 Message-Id: <20210915163957.2949166-7-jim.cromie@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210915163957.2949166-1-jim.cromie@gmail.com> References: <20210915163957.2949166-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org when `echo $cmd > control` contains multiple queries, extra query separators (;\n) can parse as empty statements. This is normal, and pr-info on empty command is just noise. Also change varname. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index abc04bf4f765..356c8231175f 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -520,9 +520,9 @@ static int ddebug_exec_query(char *query_string, const char *modname) static int ddebug_exec_queries(char *query, const char *modname) { char *split; - int i, errs = 0, exitcode = 0, rc, nfound = 0; + int qct, errs = 0, exitcode = 0, rc, nfound = 0; - for (i = 0; query; query = split) { + for (qct = 0; query; query = split) { split = strpbrk(query, ";\n"); if (split) *split++ = '\0'; @@ -531,7 +531,7 @@ static int ddebug_exec_queries(char *query, const char *modname) if (!query || !*query || *query == '#') continue; - v2pr_info("query %d: <%s> mod:<%s>\n", i, query, modname ?: "*"); + v2pr_info("query %d: <%s> mod:<%s>\n", qct, query, modname ?: "*"); rc = ddebug_exec_query(query, modname); if (rc < 0) { @@ -540,10 +540,11 @@ static int ddebug_exec_queries(char *query, const char *modname) } else { nfound += rc; } - i++; + qct++; } - v2pr_info("processed %d queries, with %d matches, %d errs\n", - i, nfound, errs); + if (qct) + v2pr_info("processed %d queries, with %d matches, %d errs\n", + qct, nfound, errs); if (exitcode) return exitcode; -- 2.31.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E9ADC433F5 for ; Wed, 15 Sep 2021 16:40:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02FFA60FA0 for ; Wed, 15 Sep 2021 16:40:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 02FFA60FA0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5DD306E99C; Wed, 15 Sep 2021 16:40:39 +0000 (UTC) Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3B5F6E989; Wed, 15 Sep 2021 16:40:36 +0000 (UTC) Received: by mail-io1-xd30.google.com with SMTP id a15so4272606iot.2; Wed, 15 Sep 2021 09:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/16IPATfLgdmiX/J8L+UemcIsELjpW//BCTY5UOTDZc=; b=F4lYbdy1XsW0VGz/Rzh+Aj72ATUvnLbalD6Ptxz76xKFknccKr4/wNjNNRxA3f+rOO cAhMSwo4XDdnHamdzMuLRquJ1avmiwtnTl55cs8KGZY/swZQDWzGHa6rRlvBdAcpjlXf XCTpPYWxBvGK0pq9hFa6/TFkehZJ2DMble4ADj5SNb9YE4pVsN9XG3KDDlmp1wSlZM/j VZ6qfhPUzGjNacIUClrpXGhFIfwsDaWu9KcP+CoxSEH+bXnFwf3YrbETpDHh0fmpCNQR 1guofFqzln+fFtLDfrs/2gq9fwfOlsst+Ka0U+X5CcDx82LeMKryhPO7j3x8Kc+p9VB1 20ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/16IPATfLgdmiX/J8L+UemcIsELjpW//BCTY5UOTDZc=; b=ZdlQWfNmR39U8dvAFr68fjI7/v9imXyWTWc4AERIBVcIB2Y+sGc36SV7VLLfHb/so1 tXyCR1Nm9VBp07Zx0YakfrMBub/lSJ8qzwUxrHYBIQOCt68GAr9VRtfv4ZRdjYCX2ihc tRLzQeQm2pncu801l0S/t2XeGwnu+YwrXgous0pOpYuh0vZt5DwEtE9/79UMDJACpVSF e6apjDiMzM67SYsgeK1b7QuU3zr/Z9/zlqcxZmPjlbCZiwRydMcGKqfC9gM/NB7Ft3id RTx8qip6zY4NNbOIt8t2NWeVY9sHrAdivekHYbrq1KQF1hDkSBj3EwNVL0ljg+fy8Fp1 1+GQ== X-Gm-Message-State: AOAM532yK9K0I2mB9PzhriwYaUFyMfDSVmNXSFxLqxzd/biS8aTsYH0l J3Y9KyLbqegsWZHqK33/PG5ySoBTHP8= X-Google-Smtp-Source: ABdhPJzarxX1asWC2Hsxhbo5NFnL6GctWrBgWA+45Dvv3G1LUT0QkB+r4NenYOzwUgzCOEmqwSXLsg== X-Received: by 2002:a5d:935a:: with SMTP id i26mr767362ioo.79.1631724035933; Wed, 15 Sep 2021 09:40:35 -0700 (PDT) Received: from frodo.. (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id a5sm299540ilf.27.2021.09.15.09.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 09:40:35 -0700 (PDT) From: Jim Cromie To: jbaron@akamai.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel@ffwll.ch Cc: Jim Cromie Date: Wed, 15 Sep 2021 10:39:47 -0600 Message-Id: <20210915163957.2949166-7-jim.cromie@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210915163957.2949166-1-jim.cromie@gmail.com> References: <20210915163957.2949166-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Intel-gfx] [PATCH v8 06/16] dyndbg: no vpr-info on empty queries X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" when `echo $cmd > control` contains multiple queries, extra query separators (;\n) can parse as empty statements. This is normal, and pr-info on empty command is just noise. Also change varname. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index abc04bf4f765..356c8231175f 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -520,9 +520,9 @@ static int ddebug_exec_query(char *query_string, const char *modname) static int ddebug_exec_queries(char *query, const char *modname) { char *split; - int i, errs = 0, exitcode = 0, rc, nfound = 0; + int qct, errs = 0, exitcode = 0, rc, nfound = 0; - for (i = 0; query; query = split) { + for (qct = 0; query; query = split) { split = strpbrk(query, ";\n"); if (split) *split++ = '\0'; @@ -531,7 +531,7 @@ static int ddebug_exec_queries(char *query, const char *modname) if (!query || !*query || *query == '#') continue; - v2pr_info("query %d: <%s> mod:<%s>\n", i, query, modname ?: "*"); + v2pr_info("query %d: <%s> mod:<%s>\n", qct, query, modname ?: "*"); rc = ddebug_exec_query(query, modname); if (rc < 0) { @@ -540,10 +540,11 @@ static int ddebug_exec_queries(char *query, const char *modname) } else { nfound += rc; } - i++; + qct++; } - v2pr_info("processed %d queries, with %d matches, %d errs\n", - i, nfound, errs); + if (qct) + v2pr_info("processed %d queries, with %d matches, %d errs\n", + qct, nfound, errs); if (exitcode) return exitcode; -- 2.31.1