From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CD09C433F5 for ; Thu, 16 Sep 2021 06:59:37 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C94B611EE for ; Thu, 16 Sep 2021 06:59:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0C94B611EE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E4BE482DB2; Thu, 16 Sep 2021 08:59:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="rkNEtbKC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5DF2882DC3; Thu, 16 Sep 2021 08:59:31 +0200 (CEST) Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 42C3582D52 for ; Thu, 16 Sep 2021 08:59:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pg1-x52c.google.com with SMTP id q68so5251330pga.9 for ; Wed, 15 Sep 2021 23:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=VnVo/FJvCri28yOeMb68DPgE7IxOynLLey1lTHEw2uA=; b=rkNEtbKCn59YImV11Anm1G4zRYtBQeeWMYoWIvGVR3QJbXrYhwaN0Hc9i1LXKNZ7+e fcqC4YJBC4ZMRwn8bBm9s357oJ2XS9A9MDs4n03v5buBrx0x84knKveGRaZT7OaKSCxl g8MHpmJwFYwRpjxNihNRh2ONIwM6aR8BHHforLyTBvGrY9YItSRnDq3Te4chd4bZHeJl VFqnup1e4xFqYllYrFI294KiBtysbSMVaaRfv9aFM7/NAEJXgwlvNL6wgAuHxhAUh0mL F+3UMAnXEHLhR10Gdprsa2hvDj9gXmEdsYUHZlGR1RW5JKB7S1PKcbdA4WX1ffDjlt2N JojA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=VnVo/FJvCri28yOeMb68DPgE7IxOynLLey1lTHEw2uA=; b=j1DSicmb9Iar5WVjUxeHsNazdrocR//1N9/TVmDYyLqMrLdvSndIxRG5rmfPUVfQQv ZFY/rVgQZVXQi9/L5IiXpi62m/uLAsLRloaE5kpQEPb/GFiuLqGQkB5rGEaXeaPqSv+F 7JJfndFDpGlwXe/d0njcsWvE+SqwJHlq2YTNFw6K3xmKt7mW5vHgTGEJeZfeqki7GxeB ymFLOoaKHS39xekEx8K8EYYeTzzi+paRMyRH5AaLBohJN8K5gboO8KWPUnpk2gF/WNUX zFGz57SC0uA0jfaRqE6XnBapHbUsDYLgnU+05kW+KEg4A/ijpEyegz70sL7Od8Wm0gOp zhZQ== X-Gm-Message-State: AOAM531hW8OK4Vp1PED0nOB8Ij5fBORHDssqqGw1j0uBdRFiDeBvA/Pm oDZdRMpQSm7vlGo7fJN8LAZrfg== X-Google-Smtp-Source: ABdhPJyE62JE2or4MzbINLC+31eU9qs08YVW0ZxS/sIYBdEj4QY1ltvkQ/1MDaxrZSy+U2OC2WDtbA== X-Received: by 2002:a63:cf10:: with SMTP id j16mr3635622pgg.257.1631775565441; Wed, 15 Sep 2021 23:59:25 -0700 (PDT) Received: from laputa (p6e421539.tkyea130.ap.so-net.ne.jp. [110.66.21.57]) by smtp.gmail.com with ESMTPSA id d16sm1625914pjd.54.2021.09.15.23.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 23:59:24 -0700 (PDT) Date: Thu, 16 Sep 2021 15:59:21 +0900 From: AKASHI Takahiro To: Mark Kettenis Cc: Heinrich Schuchardt , ml.lawnick@gmx.de, sjg@chromium.org, u-boot@lists.denx.de Subject: Re: RFC: exclude partitions from efi_selftest Message-ID: <20210916065921.GA59501@laputa> Mail-Followup-To: AKASHI Takahiro , Mark Kettenis , Heinrich Schuchardt , ml.lawnick@gmx.de, sjg@chromium.org, u-boot@lists.denx.de References: <26bcd1d1-7d39-91a4-a0d4-942efd0826a9@gmx.de> <65886be5-884e-afb7-947a-b93e5904b1f7@gmx.de> <56145f9882899efe@bloch.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56145f9882899efe@bloch.sibelius.xs4all.nl> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Sep 15, 2021 at 02:00:31PM +0200, Mark Kettenis wrote: > > Date: Wed, 15 Sep 2021 12:42:16 +0200 > > From: Heinrich Schuchardt > > > > Am 15. September 2021 11:56:07 MESZ schrieb Michael Lawnick : > > >Am 14.09.2021 um 17:57 schrieb Heinrich Schuchardt: > > >> On 9/14/21 4:56 PM, Michael Lawnick wrote: > > >>> Hi, > > >>> > > >>> in our environment we get error on efi_selftest if one of several SSD > > >>> partitions isn't properly initialized (due to some other error, but > > >>> that's a different topic). I tried to track down to where the partitions > > >>> get registered for test but got a bit lost so I request advice from you. > > >> > > >> When the UEFI sub-system is intialized we call efi_disk_register(). If > > >> it fails, we don't enter the UEFI sub-system. > > >> > > >> Are you able to identify where efi_disk_register() fails? > > > > > >The system starts up properly. > > >This is what I see: > > >ASIM-CN10KAS> efiload $loadaddr > > >Loaded EFI App image at 0x40080000 with 0x216000 bytes > > >ASIM-CN10KAS> bootefi $loadaddr $fdtaddr > > >Scanning disk sdhci@824000000000.blk... > > >** Unrecognized filesystem type ** > > >** Unrecognized filesystem type ** > > >** Unrecognized filesystem type ** > > > > This is not an error. Just an info. > > It is somewhat annoying though. The way disks are partitioned on the > Apple M1 systems, there are several Apple native partition types that > need to be retained and that U-Boot doesn't support. So you see a lot > of these warnings. > > Or maybe we should have a whitelist of partition types not to warn > about? This message is not UEFI specific, but generic filesystem code generates it. So you could 1) At fs_probe_unsupported() in fs/fs.c, change log_err() to log_warning() [or log_info()] 2) Set CONFIG_DEFAULT_LOG_LEVEL to 3(error) [or 4(warning)] to suppress the message. Or you may simply want to modify _log() so as to add a preamble, like "WARN:", in front of the message. -Takahiro Akashi