All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 5/6] tests/kms_invalid_mode: Test clock==(U)INT_MAX
Date: Thu, 16 Sep 2021 18:35:14 +0300	[thread overview]
Message-ID: <20210916153515.21369-5-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20210916153515.21369-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Test against some big clock values to make sure we can't trick the
kernel into bypassing the validation via an integer overflows/etc.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/i915/kms_invalid_mode.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/tests/i915/kms_invalid_mode.c b/tests/i915/kms_invalid_mode.c
index 6d56a378d141..722aa816fca1 100644
--- a/tests/i915/kms_invalid_mode.c
+++ b/tests/i915/kms_invalid_mode.c
@@ -23,6 +23,7 @@
  */
 
 #include "igt.h"
+#include <limits.h>
 #include <stdbool.h>
 
 IGT_TEST_DESCRIPTION("Make sure all modesets are rejected when the requested mode is invalid");
@@ -107,6 +108,20 @@ adjust_mode_zero_clock(data_t *data, drmModeModeInfoPtr mode)
 	return true;
 }
 
+static bool
+adjust_mode_int_max_clock(data_t *data, drmModeModeInfoPtr mode)
+{
+	mode->clock = INT_MAX;
+	return true;
+}
+
+static bool
+adjust_mode_uint_max_clock(data_t *data, drmModeModeInfoPtr mode)
+{
+	mode->clock = UINT_MAX;
+	return true;
+}
+
 static bool
 adjust_mode_zero_hdisplay(data_t *data, drmModeModeInfoPtr mode)
 {
@@ -244,6 +259,12 @@ static const struct {
 	{ .name = "zero-clock",
 	  .adjust_mode = adjust_mode_zero_clock,
 	},
+	{ .name = "int-max-clock",
+	  .adjust_mode = adjust_mode_int_max_clock,
+	},
+	{ .name = "uint-max-clock",
+	  .adjust_mode = adjust_mode_uint_max_clock,
+	},
 	{ .name = "zero-hdisplay",
 	  .adjust_mode = adjust_mode_zero_hdisplay,
 	},
-- 
2.32.0

  parent reply	other threads:[~2021-09-16 15:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16 15:35 [igt-dev] [PATCH i-g-t 1/6] tests/kms_invalid_dotclock: Rename to kms_invalid_mode Ville Syrjala
2021-09-16 15:35 ` [igt-dev] [PATCH i-g-t 2/6] tests/kms_invalid_mode: Convert the max dotclock test into a subtest Ville Syrjala
2021-10-05 10:13   ` Karthik B S
2021-10-05 10:33     ` Petri Latvala
2021-10-05 10:38       ` Ville Syrjälä
2021-09-16 15:35 ` [igt-dev] [PATCH i-g-t 3/6] tests/kms_invalid_mode: Move bigjoiner handling into the proper place Ville Syrjala
2021-10-05 10:15   ` Karthik B S
2021-09-16 15:35 ` [igt-dev] [PATCH i-g-t 4/6] tests/kms_invalid_mode: Test various bogus timings Ville Syrjala
2021-10-05 10:22   ` Karthik B S
2021-09-16 15:35 ` Ville Syrjala [this message]
2021-10-05 10:24   ` [igt-dev] [PATCH i-g-t 5/6] tests/kms_invalid_mode: Test clock==(U)INT_MAX Karthik B S
2021-09-16 15:35 ` [igt-dev] [PATCH i-g-t 6/6] tests/kms_invalid_mode: Allow the test on !i915 Ville Syrjala
2021-10-05 10:27   ` Karthik B S
2021-09-16 19:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/6] tests/kms_invalid_dotclock: Rename to kms_invalid_mode Patchwork
2021-09-22 17:16 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/6] tests/kms_invalid_dotclock: Rename to kms_invalid_mode (rev2) Patchwork
2021-09-22 19:09 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-10-04 12:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/6] tests/kms_invalid_dotclock: Rename to kms_invalid_mode (rev3) Patchwork
2021-10-04 14:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-05 10:09 ` [igt-dev] [PATCH i-g-t 1/6] tests/kms_invalid_dotclock: Rename to kms_invalid_mode Karthik B S
2021-10-05 11:12   ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210916153515.21369-5-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.