From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B3CBC433EF for ; Thu, 16 Sep 2021 20:13:44 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55E4D611EE for ; Thu, 16 Sep 2021 20:13:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 55E4D611EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 557A78312A; Thu, 16 Sep 2021 22:13:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="O+xQxPZG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 49D5D8312F; Thu, 16 Sep 2021 22:13:38 +0200 (CEST) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1525A83129 for ; Thu, 16 Sep 2021 22:13:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72c.google.com with SMTP id a66so10346772qkc.1 for ; Thu, 16 Sep 2021 13:13:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wzqCgOyzoesoDXSioGN3jU/EzCsk3UO1ytwAgjXfzfk=; b=O+xQxPZGdkDVEX7H+vSCue9OCV3k2R0MjJC9sWg51B0bVmfPMVdvo3FcPgSGPg1FRR 43UTAbj50GSMWflLqoIOviDTNEi1qymsR+U8TMU9w6C3aQ/2HpzNgBF48mv0zX88j8K5 i/j0QKrbi1KB1uDUbJhl3wn4yclA2ONd0AdJw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wzqCgOyzoesoDXSioGN3jU/EzCsk3UO1ytwAgjXfzfk=; b=boscuNeRx0CgE8k1MLQkqk2ozouu644ZwSANkGmJYypQtBSVSQ/HDKyTIAshBak1cd gxsp7QaRyc1aQY/30Eyc8H3ACL5lJ/w1vKZ2BI/ZbSmApdj0LEAdAet9WfFLgZR4HKlB 8uyz8fCYIul5dOYRJxsQA1Ui/z2f8SE7eUt0qDc4le7VrmLtGlXNXryIvHflVKETLzhE Td+/c6G2jJviZ9kRjWU7tULxDskM13wPMp43EqPx0eopaXGL6O+TaJvyR8hKlAsjhR9Y EPgmztMN+b5+xfNRlYl08FBfXmhDAePtlhQelPgW4fQOg0ZOrQoFERG2dQjjkODwlXpz ntnQ== X-Gm-Message-State: AOAM533rYc2Jc/UKMk7Hfena1VKqX6xz6+EnTe4ZQBXj7DMMBHTFS9sX oXsSpsc8spkONbMmffjXNg0+BPapmqykTA== X-Google-Smtp-Source: ABdhPJzJInRCEHItNvmyl4ptvf+DLfV/+F1y8O6IE0lm1rrpIOMXEXcvc4q0mvtMW6XXUdOxCFgDRQ== X-Received: by 2002:ae9:ec0f:: with SMTP id h15mr6844052qkg.224.1631823213807; Thu, 16 Sep 2021 13:13:33 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-d880-4580-a9ce-9f2f.res6.spectrum.com. [2603:6081:7b01:cbda:d880:4580:a9ce:9f2f]) by smtp.gmail.com with ESMTPSA id k13sm59885qtq.36.2021.09.16.13.13.32 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Sep 2021 13:13:33 -0700 (PDT) Date: Thu, 16 Sep 2021 16:13:31 -0400 From: Tom Rini To: Francesco Dolcini Cc: u-boot@lists.denx.de Subject: Re: [PATCH] xtensa: Put U-Boot version string at correct place by linker script Message-ID: <20210916201331.GC3997@bill-the-cat> References: <20210802131838.21097-7-pali@kernel.org> <20210916173021.3347-1-trini@konsulko.com> <20210916193819.GA285648@francesco-nb.int.toradex.com> <20210916194220.GA3997@bill-the-cat> <20210916195035.GB285648@francesco-nb.int.toradex.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DIOMP1UsTsWJauNi" Content-Disposition: inline In-Reply-To: <20210916195035.GB285648@francesco-nb.int.toradex.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --DIOMP1UsTsWJauNi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 16, 2021 at 09:50:35PM +0200, Francesco Dolcini wrote: > On Thu, Sep 16, 2021 at 03:42:20PM -0400, Tom Rini wrote: > > On Thu, Sep 16, 2021 at 09:38:19PM +0200, Francesco Dolcini wrote: > > > On Thu, Sep 16, 2021 at 01:30:21PM -0400, Tom Rini wrote: > > > > *(.literal .text) \ > > > > + *(.literal .text_version_string) \ > > >=20 > > > Isn't ".litteral" a duplication? Even if I'm pretty sure it will not = cause any difference > > > in the generated binary I would remove it. > >=20 > > Honestly, I don't know xtensa. We also don't have qemu support for it > > currently, and I'm a bit worried in general about the state of the > > platform (it's on my TODO list to poke some people now). So, I hesitate > > to make any change that's not basically copy/paste of the existing > > lines. >=20 > I have no experience on xtensa either, but this is just the section > name, and you are just telling to put ".literal" there 2 times. I don't know. Looking at the resulting linker script (and with your suggestion): .text (((0x00002000 - 0x00002000) + ((128 << 20))) - 0x00040000) : AT(((L= OADADDR(.DoubleExceptionVector.text) + SIZEOF(.DoubleExceptionVector.text) = + 4 -1)) & ~(4 -1)) { _text_start =3D ABSOLUTE(.); *(.literal .text) *(.tex= t_version_string) *(.literal.* .text.* .stub) *(.gnu.warning .gnu.linkonce.= literal.*) *(.gnu.linkonce.t.*.literal .gnu.linkonce.t.*) *(.fini.literal) *(.fini) *(.gnu.version) _text_end =3D ABSOLUTE(.); } So there's "literal" scattered everywhere. If it doesn't matter, it reads more consistently to me to toss literal in one more time. But I emailed around and we'll see if xtensa stays around, it's also our oldest toolchain and virtually untouched since submission :( --=20 Tom --DIOMP1UsTsWJauNi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFDpWQACgkQFHw5/5Y0 tyzXuwv/W460tD7RWW/RYc+m1Dj588rT/0V6Nk8vLQKUXjr1KblEfzlPlWVpDCq2 SmAAcDml9WmkiwJ/y4u5fysAOoqqJc4b93hbiXI81mLyQqAh+iqIYdpHMXjnee86 tvrlSBeV6atVGlbtw5jkJU4/TjW4OE52XRsEkX2VyEEKxdQMJYZS8OdbbAgdrodI HjHzrKWW3s4q9KK/Z+Zt7AKerYRWD+ZCERT7pH6VOIgbVw4V38lC15jFDcVr/ekO 6wmEvluvfDfwdnz7uuMJUHY9kwmgWlsurQzkZcNaCue7ETXxA+EmrNv/D7fHMAnl X5qeH0gvj2oncIcgJhMl3twYyzEQ3kztjF5szhHJdO9afH07KN+ztbbg84PYNSR1 iPZySVAu5sUdwS7TM1YwwSQPEFDyAuh4KQpZaSkc69/bFvI0mxR0grMxuD7a/E+P bRbUvuTVht0YFTwcDJSpdQL+5PNcEH1LsExku8K/bfQHhk+KDOFnGCP7nGLyxGxd BhjCHlOm =KJtq -----END PGP SIGNATURE----- --DIOMP1UsTsWJauNi--