From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFFE7C433EF for ; Thu, 16 Sep 2021 20:23:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D584C61056 for ; Thu, 16 Sep 2021 20:23:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D584C61056 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=toradex.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6DDDE8312A; Thu, 16 Sep 2021 22:23:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=toradex.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=toradex.com header.i=@toradex.com header.b="qYlQNysa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2630F8314B; Thu, 16 Sep 2021 22:23:44 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on070b.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe07::70b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D89E583129 for ; Thu, 16 Sep 2021 22:23:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=toradex.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=francesco.dolcini@toradex.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZDLOP4sygvZvoEIvy/QZS+WPoZva43TZeixvyQC/eZmcShvDDA8mFKQsqM9gE1af92Ee4ioTaMkq2UMIHHBZj0WeYpJPN3PVXFgG0tiAYK6LF7/HATFqMkmrNbOA6FyMOgBbWiyfeHkpkEH0shBQSSUuQmlCQjvj4gjt9FBum4vSvEaOjRPdpgwx5epYohSBgqugOw5ywEaWbxbJxpzYRd3fqGxN2vNHgv9bLpUjWxobD/1zk4ESy1m1ovSe22bwnd2EfrLTfb3RjRIDxkEZJvzwMANRa0w6H9ytfaduPRupemOiSWp52JgHAO7AZNJguXOjK9JVW82l6jW6vA6oww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=14htzUJOrQe7DMwQ1x9SRNmkPrUVNdUgFVhCrBk3IIs=; b=RvnyXx15UcGjWnu0mH+T6fUBWn/OfqjWJO6UhD89/mN8ISvFNFvHBhFgv/JV/p3ts1z8GuVR4g8LaDKlGQYnBoK+wYsqx158WUYfE1eEIAciefVsIj2auEsApoo6uicFosMYxY9seL1mNtZomS6v7DumXvOljpI6t/rte6q/AIms5eRMmsXPHJNT2uGSnGduxugoYhIimngN64j7YUthDQ84adV5X9npjdIPgbg2FAdkLWuFfV/KZGcNqsMeNWf8uWYGRsgPHAIbqVdGyUckNwWK5I2fmJdZc2lhBOCIvXaFnBz/jbX/ExiWJrNnvPHzsMKtnwX3OD8Lyf4+nHEgAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=toradex.com; dmarc=pass action=none header.from=toradex.com; dkim=pass header.d=toradex.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toradex.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=14htzUJOrQe7DMwQ1x9SRNmkPrUVNdUgFVhCrBk3IIs=; b=qYlQNysaNdOG7Di+kcj+Xdwy7IGRIF7zxQG0e1wM42K4vvYMIJdIuSdXyftx4WITgWaf1Tw4go1nik/5oXSy+dhgwWgXeMQgQObZzOm1c32uzvc3uuL5bOHHpQ4Gx3UpQP//4u7BLMq9UAH5KxQkU4pC2GwIJaSXVcP4JNO/nw8= Authentication-Results: konsulko.com; dkim=none (message not signed) header.d=none;konsulko.com; dmarc=none action=none header.from=toradex.com; Received: from AM4PR05MB3474.eurprd05.prod.outlook.com (2603:10a6:205:4::31) by AM8PR05MB8066.eurprd05.prod.outlook.com (2603:10a6:20b:365::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Thu, 16 Sep 2021 20:23:39 +0000 Received: from AM4PR05MB3474.eurprd05.prod.outlook.com ([fe80::b904:9cb7:d200:427a]) by AM4PR05MB3474.eurprd05.prod.outlook.com ([fe80::b904:9cb7:d200:427a%5]) with mapi id 15.20.4523.016; Thu, 16 Sep 2021 20:23:39 +0000 Date: Thu, 16 Sep 2021 22:23:37 +0200 From: Francesco Dolcini To: Tom Rini Cc: u-boot@lists.denx.de Subject: Re: [PATCH] xtensa: Put U-Boot version string at correct place by linker script Message-ID: <20210916202337.GC285648@francesco-nb.int.toradex.com> References: <20210802131838.21097-7-pali@kernel.org> <20210916173021.3347-1-trini@konsulko.com> <20210916193819.GA285648@francesco-nb.int.toradex.com> <20210916194220.GA3997@bill-the-cat> <20210916195035.GB285648@francesco-nb.int.toradex.com> <20210916201331.GC3997@bill-the-cat> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210916201331.GC3997@bill-the-cat> X-ClientProxiedBy: GV0P278CA0090.CHEP278.PROD.OUTLOOK.COM (2603:10a6:710:2b::23) To AM4PR05MB3474.eurprd05.prod.outlook.com (2603:10a6:205:4::31) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from francesco-nb.toradex.int (93.49.2.63) by GV0P278CA0090.CHEP278.PROD.OUTLOOK.COM (2603:10a6:710:2b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 20:23:39 +0000 Received: by francesco-nb.toradex.int (Postfix, from userid 1000) id CBEB610A0354; Thu, 16 Sep 2021 22:23:37 +0200 (CEST) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7ccfd84f-acb2-4a2b-8657-08d9794fde9a X-MS-TrafficTypeDiagnostic: AM8PR05MB8066: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ulhtMpzCEvg4WCrDO/SReETVTjR839ASY9cvg1Ykbb7QX34pACWBnKw86zkLUyt/hRJtwuYZWQDSIrX54G2EQ5nWJEPxQZvDYcq9TGhYFa/jV0dYpNTRH4DHYH8+2hqrrHULcb6pTbwNX3nT6vNtX0St1Zm4EXBqPs4mjGA4WcTlLd9TTTMoIvs5bWtPuQj/3Em60Ee/FtpzP5jbsgAMpW7TEXllqW4fMnL8k7XlOUy+pX4Yjk0q1jOTS/cz9RZ1c0lKES0y6O1nMEpGExV4l2awOkEEIjgwB3pjbzJ+6x+H2P5aXwe58rOYJCqlgehLMlPYU5LBvd7QLWPRydk5uGJDdwlzC5IyYbqkPjbnIcWZZiTksFaCO+4iIDg7I8Ts/awQsldNUZwDTGBZmdf/Dqp7L70w3VhBgViF8wlNjstuMRSOsCQXW0XfTax1Wc/rvkaoL4rL0Lh3R2NRXd5ld7iJLtVTVMUxW9uE79bIqklAje+dVAHlqUOoZ5M3Ovi7gFxKumCmehfxLtvupt5f72v0Z8Zv1dkN0EPMLNhM9x9C/nx8wo2hLNHCs/NWCqIKgSstm7ySMP4xsx+BqDKEJYfbtuC21+AXWKGnRydTmCgunqGK/FQ3JYzMUHiD7t4sGtiZGYnV6UkCCd3kdfafx8f0M0F2/teRRjE964yD3rLH/xQvpfk45+5cAJuHQPdOnhaqmELzdZVOGnj2NN00Kw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM4PR05MB3474.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(6916009)(316002)(66946007)(33656002)(44832011)(186003)(8676002)(38350700002)(52116002)(38100700002)(2906002)(478600001)(66556008)(66476007)(86362001)(6266002)(8936002)(4326008)(83380400001)(42186006)(1076003)(26005)(5660300002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IPot3S3pX+D5u0R89MEeN+02qfi/E9LKedyLbtfFJF0aUnerrgt0WOkdE65I?= =?us-ascii?Q?SFrFc1+BWwrem0MB1Q5fpHziUTNDNm/S2Z2qYEXYlQxynmAyMhZQ2hSSutD8?= =?us-ascii?Q?MbjPtJb8YWWPccLr5ZYrf6EUgssHaCvcDLtv7f9ZQeDdvYvh+s2OEjV8wubo?= =?us-ascii?Q?iq/jo+RiUSJICbMrfi3NAVgNR1amECzc2T6LSrvSoXdTyLAnI1K/miPhAVi4?= =?us-ascii?Q?dRlgKlkFJ3Lik74jZiRZ0g4K0raq1s2CcKAY3H8ovZK47y5cbjOHfOTKwITv?= =?us-ascii?Q?In0xQXBLB3XW7Zn7pWMHDXjonvd7m9gUZFB+iy/OGbxNYa97sK4bHcU6MxQW?= =?us-ascii?Q?MQO6eZ40hJ2+EeMH5hBc7whRpLCbH4uNuw0C5ka2IKvHV6MFPa+iBvALI82r?= =?us-ascii?Q?ImHw0gaqgzlh9XFAysURNPOOmmdKkBV6VYoXoMNnoZGBZjsoFWXcQhbX3ia2?= =?us-ascii?Q?/pVODIISX4Htke65C5W9YeheAPocu+wYt9ZjKqUP5Hp1LITUNGKekvGwx7Iu?= =?us-ascii?Q?StkKfW0YH7b6usNpdLnyfCYkc6piI/sQT5/E8zJeGZpXmxy9CpzUB1O9pFwn?= =?us-ascii?Q?a1QS+wKRumpuHWpPktnHoCSZphz8PLkucUdYoz78+BCt6wI+TCcE7IKBJqtC?= =?us-ascii?Q?MtKkznrWV9Ji3Qgz9MDVAPUTf2tzdBvGsZfvsxFfgv8F/3N+zzWM/c79E7XF?= =?us-ascii?Q?uLT+26ZxDhbcXhgrnMUcc+n4fmqS8IrQF71/DIk4McxIBUUgjyXZtgHa6Wdp?= =?us-ascii?Q?wNtM4297qxuIEvO1G3roG+kvN15VT2H5z1cLdato34VPtJdr4ltzkjH2ZvYm?= =?us-ascii?Q?K00iAErdJGGXGdE9/fdCeTfAgtUNDwZHmh/gW18pioEiqVr37zvfnjTrxOK/?= =?us-ascii?Q?SRJzmiZQEG41WcmRwLGpkgcVxpHTDvKw2BGQTZxxJ5arGhs+W+infIxomujF?= =?us-ascii?Q?hJxtbyYUiPOFcBt0vZJo3hkRhxZZoXgKCJYaMd0OKhd9bdLVc6T99hHKcBGX?= =?us-ascii?Q?ZynLKf5l9ilOsnQOHyLlEhKUI4rcadJB2F5Y5TusTpOwbS9cJSzTdGqRKjpE?= =?us-ascii?Q?f26aAOAGBZEZjSEGhKCKJ344jHEfI1WK8zTW3pXJ44vkscE/TKqCodvuHMyD?= =?us-ascii?Q?Sl+BqyKAxpIFfOAqHWNA+yUFfeLA+RIhKlIhGjDZGL7nwXGlxsJSTx90+L2m?= =?us-ascii?Q?OOSY8PpeGw/FzYcuAjeRd4266Dz9whhRvpi69S4JaI/iI20kKQzM1CcBYAmm?= =?us-ascii?Q?r5MCVrpuqYLtlZ7PoW3R3N3KoJxGwdad18BHW1d+HNfph3CgYg44rCcLPGuc?= =?us-ascii?Q?aBsEg7DRxFKfdARF/4I4FOHi?= X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ccfd84f-acb2-4a2b-8657-08d9794fde9a X-MS-Exchange-CrossTenant-AuthSource: AM4PR05MB3474.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 20:23:39.4361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i3CHDgDvQ8woFoBu35HdH2T4RjwGupQZ7dztR/1LPiSJzgPIopbrhovLhRgl+7Mim9ua2LKISCRD5Xht2LwHJ2JU8Rclel1ifKTERTawFZE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR05MB8066 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Sep 16, 2021 at 04:13:31PM -0400, Tom Rini wrote: > On Thu, Sep 16, 2021 at 09:50:35PM +0200, Francesco Dolcini wrote: > > On Thu, Sep 16, 2021 at 03:42:20PM -0400, Tom Rini wrote: > > > On Thu, Sep 16, 2021 at 09:38:19PM +0200, Francesco Dolcini wrote: > > > > On Thu, Sep 16, 2021 at 01:30:21PM -0400, Tom Rini wrote: > > > > > *(.literal .text) \ > > > > > + *(.literal .text_version_string) \ > > > > > > > > Isn't ".litteral" a duplication? Even if I'm pretty sure it will not cause any difference > > > > in the generated binary I would remove it. > > > > > > Honestly, I don't know xtensa. We also don't have qemu support for it > > > currently, and I'm a bit worried in general about the state of the > > > platform (it's on my TODO list to poke some people now). So, I hesitate > > > to make any change that's not basically copy/paste of the existing > > > lines. > > > > I have no experience on xtensa either, but this is just the section > > name, and you are just telling to put ".literal" there 2 times. > > I don't know. Looking at the resulting linker script (and with your > suggestion): > .text (((0x00002000 - 0x00002000) + ((128 << 20))) - 0x00040000) : AT(((LOADADDR(.DoubleExceptionVector.text) + SIZEOF(.DoubleExceptionVector.text) + 4 -1)) & ~(4 -1)) { _text_start = ABSOLUTE(.); *(.literal .text) *(.text_version_string) *(.literal.* .text.* .stub) *(.gnu.warning .gnu.linkonce.literal.*) *(.gnu.linkonce.t.*.literal .gnu.linkonce.t.*) > *(.fini.literal) *(.fini) *(.gnu.version) _text_end = ABSOLUTE(.); } > > So there's "literal" scattered everywhere. If it doesn't matter, it > reads more consistently to me to toss literal in one more time. Heheh, ".literal" is present only once here, ".literal.*" is matching something else, likewise all the others that are scathered all around. This looks fine to me. > But I emailed around and we'll see if xtensa stays around, it's also our > oldest toolchain and virtually untouched since submission :( My small comment is just about the linker script format, I guess some other folk should be able to confirm what I wrote. Unfortunately it will not solve the general problem with xtensa ... Francesco