All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Dongwon Kim <dongwon.kim@intel.com>
Cc: qemu-devel@nongnu.org, Vivek Kasireddy <vivek.kasireddy@intel.com>
Subject: Re: [PATCH] ui/gtk: skip any extra draw of same guest scanout blob res
Date: Fri, 17 Sep 2021 12:02:02 +0200	[thread overview]
Message-ID: <20210917100202.vrdadmmqbeebwp5g@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210916234156.5505-1-dongwon.kim@intel.com>

  Hi,

> +    bool      draw_submitted;
> +    QemuMutex mutex;

Why the mutex?  I think all the code runs while holding the BQL so it
should be serialized.

> +#ifdef CONFIG_GBM
> +        if (dmabuf) {
> +            qemu_mutex_lock(&dmabuf->mutex);
> +            if (!dmabuf->draw_submitted) {
> +                qemu_mutex_unlock(&dmabuf->mutex);
> +                return;
> +            } else {
> +                dmabuf->draw_submitted = false;
> +            }
> +        }
> +#endif

Factoring out that into helper functions is probably a good idea.  Then
have stub functions for the CONFIG_GBM=no case and *alot* less #ifdefs
in the code ...

thanks,
  Gerd



  reply	other threads:[~2021-09-17 10:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16 23:41 [PATCH] ui/gtk: skip any extra draw of same guest scanout blob res Dongwon Kim
2021-09-17 10:02 ` Gerd Hoffmann [this message]
2021-09-17 16:34   ` Dongwon Kim
2021-09-23 23:41   ` Dongwon Kim
2021-09-24 22:51 ` [PATCH v2] " Dongwon Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210917100202.vrdadmmqbeebwp5g@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=dongwon.kim@intel.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vivek.kasireddy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.