From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44AC2C433EF for ; Fri, 17 Sep 2021 12:08:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26A8960187 for ; Fri, 17 Sep 2021 12:08:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344415AbhIQMJd (ORCPT ); Fri, 17 Sep 2021 08:09:33 -0400 Received: from esa.microchip.iphmx.com ([68.232.153.233]:65137 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243593AbhIQMIj (ORCPT ); Fri, 17 Sep 2021 08:08:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1631880437; x=1663416437; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tJKSBuOTBiBd8Y63je4r0LFxJcPueVYGL0ehIQ+Ul8U=; b=194d4TVUNwkGc76lLt2EroXIof6hvj8uU+Va0RWQGD6pEPStUDPzrvfM M2GPlQYAKLkYQAPi0A6j53AfsprqnS2hVryvx38P4ZDGFTNqVNHh4w/t9 44wJ9c+3YXV0dRQeMRS9kCB6PvLS0SsX3kGrMpZnapVRX/ikIpS4qjf/P 36SMoZqLvO90FZ8AsdrkzLFwC4L3Utxz7FgbnLo8pqrgwA7hWKb7cpSRK AH9FN3zLSQP4UOqI3KS8b3xdbKyDqbYY9/gt2Q2TReOvADPCcsZwpCWAN s82OrHV+xED/mkncFp66AZRYQKAV66Wq7H9W7AQIzfQvRDqqjUsTP3nMG w==; IronPort-SDR: 86a7+gZKgm+MF0xwruVDvpHlD+PyJtJTRBMsHFYY9SC/WXiSYAipPhWw0AdryS+cugFaJOyrV0 SzpzrkMIUvEbxL+sVO0g0711kleeUIJ1L4TbqMV/y/GWNy0TMJEXTqYTZMdLfarXujdqlNKyzZ iBpkRo2TtFrod0N29k+9jKwyX+ojVW9FOiXa3hHKhTpSFIHQq//fKFY79SKvY+wkvV3BDgWJtC /DY8dPq+GcG93YDe1KOTtQrjm09zHiklYUcBs3QbAMybT6aJZuDAC8vJvqEt+EQndri0E1j8pu 8hnUfOO/fbIl/dZnwamo4bQN X-IronPort-AV: E=Sophos;i="5.85,301,1624345200"; d="scan'208";a="144535347" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 Sep 2021 05:07:10 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 17 Sep 2021 05:07:09 -0700 Received: from rob-dk-mpu01.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 17 Sep 2021 05:07:07 -0700 From: Claudiu Beznea To: , , , , CC: , , , Claudiu Beznea Subject: [PATCH v3 10/17] clk: at91: clk-master: fix prescaler logic Date: Fri, 17 Sep 2021 15:06:35 +0300 Message-ID: <20210917120642.8993-11-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210917120642.8993-1-claudiu.beznea@microchip.com> References: <20210917120642.8993-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When prescaler value read from register is MASTER_PRES_MAX it means that the input clock will be divided by 3. Fix the code to reflect this. Fixes: 7a110b9107ed8 ("clk: at91: clk-master: re-factor master clock") Signed-off-by: Claudiu Beznea --- drivers/clk/at91/clk-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/at91/clk-master.c b/drivers/clk/at91/clk-master.c index 6da9ae34313a..e67bcd03a827 100644 --- a/drivers/clk/at91/clk-master.c +++ b/drivers/clk/at91/clk-master.c @@ -386,7 +386,7 @@ static unsigned long clk_master_pres_recalc_rate(struct clk_hw *hw, val &= master->layout->mask; pres = (val >> master->layout->pres_shift) & MASTER_PRES_MASK; - if (pres == 3 && characteristics->have_div3_pres) + if (pres == MASTER_PRES_MAX && characteristics->have_div3_pres) pres = 3; else pres = (1 << pres); -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 790C2C433EF for ; Fri, 17 Sep 2021 12:14:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D94C60F9C for ; Fri, 17 Sep 2021 12:14:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D94C60F9C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ReIGozMo9rlQx4dYN0NoBoPH+QvZ5gOyoNHXbxOgwj0=; b=zmgEMRcA6OY/Hm gjkDvNtPzC97psWaQMHmsMXuHIdzw67pnfGrhzAiZKGYXAA190L0boU+RHI+tWWxEcdihyOoaCjyk HQDcc/uvBnDbgZ3UBDzohq2M30pir7LV4Ha2waG2IGUdMAa9+vYI6ZjOogFXlmvdEXMCD2ykhGie2 ub3dElMpPJCfDPrKpYOqSy7ZwAdOuc6T01EXSLkTvblnv7FT9/kFBBYmmyn8iE/hYsZhsmbECMNKu 1ovEAsQ99WebpPoqSI+nNed7U7b5g8paYP8C4mrlX4CMSt4VfJySW/dDRBvTZ+EK9vo1bcUCThKPB Hi4NHmg0PqxPvVFPJF9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRCib-00DyFE-3I; Fri, 17 Sep 2021 12:11:49 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRCeD-00Dw5y-QC for linux-arm-kernel@lists.infradead.org; Fri, 17 Sep 2021 12:07:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1631880437; x=1663416437; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tJKSBuOTBiBd8Y63je4r0LFxJcPueVYGL0ehIQ+Ul8U=; b=194d4TVUNwkGc76lLt2EroXIof6hvj8uU+Va0RWQGD6pEPStUDPzrvfM M2GPlQYAKLkYQAPi0A6j53AfsprqnS2hVryvx38P4ZDGFTNqVNHh4w/t9 44wJ9c+3YXV0dRQeMRS9kCB6PvLS0SsX3kGrMpZnapVRX/ikIpS4qjf/P 36SMoZqLvO90FZ8AsdrkzLFwC4L3Utxz7FgbnLo8pqrgwA7hWKb7cpSRK AH9FN3zLSQP4UOqI3KS8b3xdbKyDqbYY9/gt2Q2TReOvADPCcsZwpCWAN s82OrHV+xED/mkncFp66AZRYQKAV66Wq7H9W7AQIzfQvRDqqjUsTP3nMG w==; IronPort-SDR: 86a7+gZKgm+MF0xwruVDvpHlD+PyJtJTRBMsHFYY9SC/WXiSYAipPhWw0AdryS+cugFaJOyrV0 SzpzrkMIUvEbxL+sVO0g0711kleeUIJ1L4TbqMV/y/GWNy0TMJEXTqYTZMdLfarXujdqlNKyzZ iBpkRo2TtFrod0N29k+9jKwyX+ojVW9FOiXa3hHKhTpSFIHQq//fKFY79SKvY+wkvV3BDgWJtC /DY8dPq+GcG93YDe1KOTtQrjm09zHiklYUcBs3QbAMybT6aJZuDAC8vJvqEt+EQndri0E1j8pu 8hnUfOO/fbIl/dZnwamo4bQN X-IronPort-AV: E=Sophos;i="5.85,301,1624345200"; d="scan'208";a="144535347" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 Sep 2021 05:07:10 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 17 Sep 2021 05:07:09 -0700 Received: from rob-dk-mpu01.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 17 Sep 2021 05:07:07 -0700 From: Claudiu Beznea To: , , , , CC: , , , Claudiu Beznea Subject: [PATCH v3 10/17] clk: at91: clk-master: fix prescaler logic Date: Fri, 17 Sep 2021 15:06:35 +0300 Message-ID: <20210917120642.8993-11-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210917120642.8993-1-claudiu.beznea@microchip.com> References: <20210917120642.8993-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210917_050717_894185_AF849854 X-CRM114-Status: GOOD ( 11.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When prescaler value read from register is MASTER_PRES_MAX it means that the input clock will be divided by 3. Fix the code to reflect this. Fixes: 7a110b9107ed8 ("clk: at91: clk-master: re-factor master clock") Signed-off-by: Claudiu Beznea --- drivers/clk/at91/clk-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/at91/clk-master.c b/drivers/clk/at91/clk-master.c index 6da9ae34313a..e67bcd03a827 100644 --- a/drivers/clk/at91/clk-master.c +++ b/drivers/clk/at91/clk-master.c @@ -386,7 +386,7 @@ static unsigned long clk_master_pres_recalc_rate(struct clk_hw *hw, val &= master->layout->mask; pres = (val >> master->layout->pres_shift) & MASTER_PRES_MASK; - if (pres == 3 && characteristics->have_div3_pres) + if (pres == MASTER_PRES_MAX && characteristics->have_div3_pres) pres = 3; else pres = (1 << pres); -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel