From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5828DC433F5 for ; Fri, 17 Sep 2021 12:07:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42DB460187 for ; Fri, 17 Sep 2021 12:07:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243726AbhIQMId (ORCPT ); Fri, 17 Sep 2021 08:08:33 -0400 Received: from esa.microchip.iphmx.com ([68.232.153.233]:65121 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344034AbhIQMI0 (ORCPT ); Fri, 17 Sep 2021 08:08:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1631880424; x=1663416424; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bbgvOX8odhhcgQRbsWErZdBKALu82PPpkMqqT+eQSGM=; b=N4Mqc0F7vpJm5LHLUA2MP8minlNIo1JGrxy4Te4d8vkbcaHneDsY+t76 sW7emTiB11fwKydqha7bthqh3bxMn7IV+lGyUOR2lMxoCqnsW3zird4l8 j5u5mbnrXZbD+0OKjscwr4lx8pcZP6adw6oxFsdAqXHCKVqHiom06Cv83 AMmg98PmcBo4jGrE8ebQxhGxBtftHjGzBVBQsrR22qtmALUfn7+VOgHk6 +7jHi+wBEPTi/GJ/dxvtz1z/x/y9/BVVFgDf8W5wjMkUVki4MndIoqf17 HLiDCqjuzolSH9fwThTZIDuKgjH/b+POEw5M+ZfYepLVtkbLrFzcO+rMg A==; IronPort-SDR: YCdtSnmOwuhP8Y32yRoWgLZ64YYCrnADNP7WIVXTO9HttaZqgZLWIp4r8yqyyerJJRPbX7BDiW wV6xX+PTP68T893q+yv5r9lOyAUGhbss9dVf5WKlvKgKY/YgUawGJefhwGlNzGN6LfauCGaH/F WXJMlmhKIlxa42iTq9q+3j0a1lPdXHD4ws2ZbRyUNBCO1yAP6p/Yl28MmHL8x75w1VK/Im3rXr KMjapveUpFA1LFbDdZJ+3gSYFLRUHMqX0aTJ5Q5Kgp5mGVo7UpyHcUWCEL1xv4qCJeaeJwwHrf vd9NOd9HY4hnd0U3/V2YNDYf X-IronPort-AV: E=Sophos;i="5.85,301,1624345200"; d="scan'208";a="144535328" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 Sep 2021 05:07:04 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 17 Sep 2021 05:07:02 -0700 Received: from rob-dk-mpu01.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 17 Sep 2021 05:07:00 -0700 From: Claudiu Beznea To: , , , , CC: , , , Claudiu Beznea Subject: [PATCH v3 07/17] clk: at91: sam9x60-pll: use DIV_ROUND_CLOSEST_ULL Date: Fri, 17 Sep 2021 15:06:32 +0300 Message-ID: <20210917120642.8993-8-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210917120642.8993-1-claudiu.beznea@microchip.com> References: <20210917120642.8993-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use DIV_ROUND_CLOSEST_ULL() to avoid any inconsistency b/w the rate computed in sam9x60_frac_pll_recalc_rate() and the one computed in sam9x60_frac_pll_compute_mul_frac(). Fixes: 43b1bb4a9b3e1 ("clk: at91: clk-sam9x60-pll: re-factor to support plls with multiple outputs") Signed-off-by: Claudiu Beznea --- drivers/clk/at91/clk-sam9x60-pll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/at91/clk-sam9x60-pll.c b/drivers/clk/at91/clk-sam9x60-pll.c index 7020d3bf6e13..a73d7c96ce1d 100644 --- a/drivers/clk/at91/clk-sam9x60-pll.c +++ b/drivers/clk/at91/clk-sam9x60-pll.c @@ -73,8 +73,8 @@ static unsigned long sam9x60_frac_pll_recalc_rate(struct clk_hw *hw, struct sam9x60_pll_core *core = to_sam9x60_pll_core(hw); struct sam9x60_frac *frac = to_sam9x60_frac(core); - return (parent_rate * (frac->mul + 1) + - ((u64)parent_rate * frac->frac >> 22)); + return parent_rate * (frac->mul + 1) + + DIV_ROUND_CLOSEST_ULL((u64)parent_rate * frac->frac, (1 << 22)); } static int sam9x60_frac_pll_set(struct sam9x60_pll_core *core) -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB2AC433F5 for ; Fri, 17 Sep 2021 12:10:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F19FF60187 for ; Fri, 17 Sep 2021 12:10:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F19FF60187 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IO8KZ4OnSCIMVo6SfuPtL/nBD2jOZ/VvlDp8i4iq+D8=; b=oozXCXpTvcvViW 9z3KBSnP5MpNH/Bb2eqHksl2KXYfAVICzBvzayEKcMhP7Vd8cPMeXcc2OcQH7opso2QFjFh5Hxi8v V5BT32xUikRkyaXuEdGu5LnfK0XDWF7uM/z6+TqhJb897Oq8z/VX3nj3kEXGAEMnwBXCeIUVVX01o NgxSZcuFQWAwCpBj6ux7LuWpJJJYmsz4f0eJMmfXCIzTncmiW71v1RVzyQNpnDL8iPKu/alNJQ7kZ MvKlUegxzjXWJ2iDng1qGRfgOpzBD43XwDgBOhyFyiKrIIJl+ujHra6ODd7/2sjcLOXwlkrYaMoC8 ZsIMEynjnTG1JMa3UHXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRCfp-00Dwh9-CN; Fri, 17 Sep 2021 12:08:57 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRCe0-00Dw0y-O9 for linux-arm-kernel@lists.infradead.org; Fri, 17 Sep 2021 12:07:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1631880424; x=1663416424; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bbgvOX8odhhcgQRbsWErZdBKALu82PPpkMqqT+eQSGM=; b=N4Mqc0F7vpJm5LHLUA2MP8minlNIo1JGrxy4Te4d8vkbcaHneDsY+t76 sW7emTiB11fwKydqha7bthqh3bxMn7IV+lGyUOR2lMxoCqnsW3zird4l8 j5u5mbnrXZbD+0OKjscwr4lx8pcZP6adw6oxFsdAqXHCKVqHiom06Cv83 AMmg98PmcBo4jGrE8ebQxhGxBtftHjGzBVBQsrR22qtmALUfn7+VOgHk6 +7jHi+wBEPTi/GJ/dxvtz1z/x/y9/BVVFgDf8W5wjMkUVki4MndIoqf17 HLiDCqjuzolSH9fwThTZIDuKgjH/b+POEw5M+ZfYepLVtkbLrFzcO+rMg A==; IronPort-SDR: YCdtSnmOwuhP8Y32yRoWgLZ64YYCrnADNP7WIVXTO9HttaZqgZLWIp4r8yqyyerJJRPbX7BDiW wV6xX+PTP68T893q+yv5r9lOyAUGhbss9dVf5WKlvKgKY/YgUawGJefhwGlNzGN6LfauCGaH/F WXJMlmhKIlxa42iTq9q+3j0a1lPdXHD4ws2ZbRyUNBCO1yAP6p/Yl28MmHL8x75w1VK/Im3rXr KMjapveUpFA1LFbDdZJ+3gSYFLRUHMqX0aTJ5Q5Kgp5mGVo7UpyHcUWCEL1xv4qCJeaeJwwHrf vd9NOd9HY4hnd0U3/V2YNDYf X-IronPort-AV: E=Sophos;i="5.85,301,1624345200"; d="scan'208";a="144535328" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 Sep 2021 05:07:04 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 17 Sep 2021 05:07:02 -0700 Received: from rob-dk-mpu01.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 17 Sep 2021 05:07:00 -0700 From: Claudiu Beznea To: , , , , CC: , , , Claudiu Beznea Subject: [PATCH v3 07/17] clk: at91: sam9x60-pll: use DIV_ROUND_CLOSEST_ULL Date: Fri, 17 Sep 2021 15:06:32 +0300 Message-ID: <20210917120642.8993-8-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210917120642.8993-1-claudiu.beznea@microchip.com> References: <20210917120642.8993-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210917_050704_821426_04FE5D3E X-CRM114-Status: UNSURE ( 9.17 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use DIV_ROUND_CLOSEST_ULL() to avoid any inconsistency b/w the rate computed in sam9x60_frac_pll_recalc_rate() and the one computed in sam9x60_frac_pll_compute_mul_frac(). Fixes: 43b1bb4a9b3e1 ("clk: at91: clk-sam9x60-pll: re-factor to support plls with multiple outputs") Signed-off-by: Claudiu Beznea --- drivers/clk/at91/clk-sam9x60-pll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/at91/clk-sam9x60-pll.c b/drivers/clk/at91/clk-sam9x60-pll.c index 7020d3bf6e13..a73d7c96ce1d 100644 --- a/drivers/clk/at91/clk-sam9x60-pll.c +++ b/drivers/clk/at91/clk-sam9x60-pll.c @@ -73,8 +73,8 @@ static unsigned long sam9x60_frac_pll_recalc_rate(struct clk_hw *hw, struct sam9x60_pll_core *core = to_sam9x60_pll_core(hw); struct sam9x60_frac *frac = to_sam9x60_frac(core); - return (parent_rate * (frac->mul + 1) + - ((u64)parent_rate * frac->frac >> 22)); + return parent_rate * (frac->mul + 1) + + DIV_ROUND_CLOSEST_ULL((u64)parent_rate * frac->frac, (1 << 22)); } static int sam9x60_frac_pll_set(struct sam9x60_pll_core *core) -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel