From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7111C433F5 for ; Fri, 17 Sep 2021 12:08:44 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C533611F2 for ; Fri, 17 Sep 2021 12:08:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4C533611F2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6851D83216; Fri, 17 Sep 2021 14:08:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="JuQ4fpoy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B2A4E83217; Fri, 17 Sep 2021 14:08:40 +0200 (CEST) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BFCD68320D for ; Fri, 17 Sep 2021 14:08:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72b.google.com with SMTP id 72so4916482qkk.7 for ; Fri, 17 Sep 2021 05:08:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6sqk3CROJNOGacM6GCOkSVCqg67esZXI6c99ny1z+ik=; b=JuQ4fpoyeYaFBSopn1HQsPWZwPFidNT2aNgRGERb7rA9UK2xheEQV+VJm8ACvzRm9E HrvgVvgFXZSqHWypYaQZGHE6RGxNSQ/43sf/QXGj41Z58oCEq8Gim+QYv2egvlmBR+uI QmHmmvpMN6G1YMb+ti45lISyRog9R3rPjBYew= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6sqk3CROJNOGacM6GCOkSVCqg67esZXI6c99ny1z+ik=; b=CwI64Q84n+gQ8hx0V8QjSQZfajeqwXD5yVDDwRdifhSXhD8rCCF1uE/4Sxhm+ldg02 PY+6vq3wAPxpkba4hPxLf8ZVSWF6aP1fGHUxayjFGsB4u+RpaMZU4hCkDqVo0FbLCZrD U09iZSlzMYQ9eCRWrlmN47149xgWHjgvAAx4SJ7TDdA+1OWivLe9EN21RbIzwPhKhk/t TIiXIzX6L1kVqZFKMPojwGDsyFPIWMr1N+ryfZt9D2wkUNsoFS+ZEGDHlV9iLyxHvFR0 eoOl9KUzpzil4L78x3kPdbvD7I5x2TRyy3oq+jQVdcHANQWpSUtPb5g7F+4LeW9Q+YG/ q2ZQ== X-Gm-Message-State: AOAM532EcyeGMKnDdXUKnufxqI86YH9xMriiYuteFptYpARyk6NSjxhs cgrgAPkFbJXXgPqWoFPj+nqoM1VcmIMzaw== X-Google-Smtp-Source: ABdhPJxekh9+y0Lygj0C2449kOL/sOcpbsTu3XWjW3VSPwy6LfaSduMA/kE6sR8RrwD2sjZkL31w7A== X-Received: by 2002:a37:f706:: with SMTP id q6mr10106023qkj.519.1631880515511; Fri, 17 Sep 2021 05:08:35 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a431-c986-449b-ee60.res6.spectrum.com. [2603:6081:7b01:cbda:a431:c986:449b:ee60]) by smtp.gmail.com with ESMTPSA id j9sm3814387qta.65.2021.09.17.05.08.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Sep 2021 05:08:34 -0700 (PDT) Date: Fri, 17 Sep 2021 08:08:32 -0400 From: Tom Rini To: T Karthik Reddy , Ilias Apalodimas Cc: Ashok Reddy Soma , "u-boot@lists.denx.de" , "miquel.raynal@bootlin.com" , git Subject: Re: [PATCH] test/py: tpm2: Skip tpm pytest based on env variable Message-ID: <20210917120832.GG3997@bill-the-cat> References: <20210723121826.23072-1-ashok.reddy.soma@xilinx.com> <20210804152149.GB9379@bill-the-cat> <20210805132246.GJ858@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VuQYccsttdhdIfIP" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --VuQYccsttdhdIfIP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 17, 2021 at 11:49:51AM +0000, T Karthik Reddy wrote: > Hi Tom, >=20 > > -----Original Message----- > > From: Tom Rini > > Sent: Thursday, August 5, 2021 6:53 PM > > To: T Karthik Reddy > > Cc: Ashok Reddy Soma ; u-boot@lists.denx.de; > > miquel.raynal@bootlin.com; git > > Subject: Re: [PATCH] test/py: tpm2: Skip tpm pytest based on env variab= le > >=20 > > On Thu, Aug 05, 2021 at 05:56:50AM +0000, T Karthik Reddy wrote: > > > Hello Tom Rini, > > > > > > > -----Original Message----- > > > > From: Tom Rini > > > > Sent: Wednesday, August 4, 2021 8:52 PM > > > > To: Ashok Reddy Soma > > > > Cc: u-boot@lists.denx.de; miquel.raynal@bootlin.com; git > > > > ; T Karthik Reddy > > > > Subject: Re: [PATCH] test/py: tpm2: Skip tpm pytest based on env > > > > variable > > > > > > > > On Fri, Jul 23, 2021 at 06:18:26AM -0600, Ashok Reddy Soma wrote: > > > > > > > > > From: T Karthik Reddy > > > > > > > > > > Tpm test cases relies on tpm device setup. Provide an environment > > > > > variable "env__tpm_device_test_skip =3D True" to skip the test ca= se > > > > > if tpm device is not present. > > > > > Only needed will have to add variable to the py-test framework. > > > > > Test runs successfully even this variable is absent. > > > > > > > > > > Signed-off-by: T Karthik Reddy > > > > > Signed-off-by: Ashok Reddy Soma > > > > > > > > Why is this not using boardenv_* like other tests do to disable run= ning? > > > > > > What I meant here was this test doesn't depend on configuration value > > > from boardenv_*. But it uses env__tpm_device_test_skip variable from > > the configuration file. > > > I referred test/py/tests/test_sleep.py for writing this test case, he= nce > > copied comments as well. > > > Should I change this NOTE in comment section? > >=20 > > Thanks for explaining. This got me to re-read the existing tests and w= hile > > none of it is as clear as I would like, your example here is just as cl= ear as the > > rest, so it's fine and I'll pick it up soon. >=20 > I see this patch is not yet applied on the repo, could you please let me = know when this will be applied? Ilias, since you've said you'd review TPM related patches, does this: https://patchwork.ozlabs.org/project/uboot/patch/1624340962-91190-1-git-sen= d-email-t.karthik.reddy@xilinx.com/ work for you? Thanks. --=20 Tom --VuQYccsttdhdIfIP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFEhUAACgkQFHw5/5Y0 tyxxxgwAuPmUxQffM4KwG2uptuv9bLfBYSMFA9tUmWwjETWVwX+xFgKROd3RQnVb ZLncGDm0SjhigSF4prMNKGa2BdE/xFbpdW7NFTd3TyEISzclDWwP1h2x4m6QApd9 W6VYEiRbYLMbzzsjNI15qUuUk76EbcDXWcz8expiNRtRi9kApfI5YdDPnnJA3z8D ESWmC9RwMHdGVN1zj7/3BbyBptzUGSHJVeo/R5uy3KgpBMlptuWmdp6BUNAXONNx 7juqbmjCQoMXmKxYh/9Y52SXT7MnyiGhqHDOAVuan9N5u8jFU/UCrZHhVkbnGleR 0UiMrNL/swPcE4UkX3t2V/PV1C6RDjYAmTXAue/2wKJ5jrv8A35iP9fcM2BJZYNc YuT0BG7tt9zfjD3fBBoJAY85KUhZCXrVTPZcYc2V5X0cKOhjYt2UOIo9MdIIQu+H 3ZoPwWwPFrySCMq7SfAoB8McD7jFNzgP49PJOAM4Id/jqjlxGasuIWivMwesZmlN jOoG26Gt =09qN -----END PGP SIGNATURE----- --VuQYccsttdhdIfIP--