All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>, Bin Meng <bmeng.cn@gmail.com>,
	Priyanka Jain <priyanka.jain@nxp.com>,
	Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Subject: [PATCH 01/11] pci: provide prototype for pci_skip_dev outside of #if defined(CONFIG_DM_PCI_COMPAT)
Date: Fri, 17 Sep 2021 15:11:20 +0300	[thread overview]
Message-ID: <20210917121130.526216-2-vladimir.oltean@nxp.com> (raw)
In-Reply-To: <20210917121130.526216-1-vladimir.oltean@nxp.com>

The weak definition of pci_skip_dev from drivers/pci/pci_common.c is not
under CONFIG_DM_PCI_COMPAT, and that definition needs a previous
function prototype declaration to avoid W=1 build warnings.

That prototype is not available due to it being under CONFIG_DM_PCI_COMPAT,
so move it outside of that preprocessor block.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 include/pci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/pci.h b/include/pci.h
index 0fc22adffd00..11009a2f787a 100644
--- a/include/pci.h
+++ b/include/pci.h
@@ -724,6 +724,7 @@ void pciauto_config_init(struct pci_controller *hose);
  */
 int pciauto_region_allocate(struct pci_region *res, pci_size_t size,
 			    pci_addr_t *bar, bool supports_64bit);
+int pci_skip_dev(struct pci_controller *hose, pci_dev_t dev);
 
 #if defined(CONFIG_DM_PCI_COMPAT)
 extern int pci_hose_read_config_byte_via_dword(struct pci_controller *hose,
@@ -741,7 +742,6 @@ extern struct pci_controller* pci_bus_to_hose(int bus);
 extern struct pci_controller *find_hose_by_cfg_addr(void *cfg_addr);
 extern struct pci_controller *pci_get_hose_head(void);
 
-extern int pci_skip_dev(struct pci_controller *hose, pci_dev_t dev);
 extern int pci_hose_scan(struct pci_controller *hose);
 extern int pci_hose_scan_bus(struct pci_controller *hose, int bus);
 
-- 
2.25.1


  reply	other threads:[~2021-09-17 12:12 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 12:11 [PATCH 00/11] Drive-by PCI W=1 cleanups Vladimir Oltean
2021-09-17 12:11 ` Vladimir Oltean [this message]
2021-09-18  6:54   ` [PATCH 01/11] pci: provide prototype for pci_skip_dev outside of #if defined(CONFIG_DM_PCI_COMPAT) Bin Meng
2021-10-03 23:33   ` Tom Rini
2021-09-17 12:11 ` [PATCH 02/11] pci: include pci_internal.h inside pci_auto.c Vladimir Oltean
2021-09-18  6:55   ` Bin Meng
2021-10-03 23:33   ` Tom Rini
2021-09-17 12:11 ` [PATCH 03/11] pci: pci_bar_show can be static Vladimir Oltean
2021-09-18  6:55   ` Bin Meng
2021-10-03 23:33   ` Tom Rini
2021-09-17 12:11 ` [PATCH 04/11] pci: pci_header_show " Vladimir Oltean
2021-09-18  6:55   ` Bin Meng
2021-10-03 23:33   ` Tom Rini
2021-09-17 12:11 ` [PATCH 05/11] pci: pciinfo_header " Vladimir Oltean
2021-09-18  6:55   ` Bin Meng
2021-10-03 23:33   ` Tom Rini
2021-09-17 12:11 ` [PATCH 06/11] pci: pci_write_config " Vladimir Oltean
2021-09-18  6:55   ` Bin Meng
2021-10-03 23:33   ` Tom Rini
2021-09-17 12:11 ` [PATCH 07/11] pci: pci_read_config " Vladimir Oltean
2021-09-18  6:55   ` Bin Meng
2021-10-03 23:34   ` Tom Rini
2021-09-17 12:11 ` [PATCH 08/11] pci: _dm_pci_phys_to_bus " Vladimir Oltean
2021-09-18  6:55   ` Bin Meng
2021-10-03 23:34   ` Tom Rini
2021-09-17 12:11 ` [PATCH 09/11] pci: layerscape: ls_pcie_conf_address " Vladimir Oltean
2021-09-18  6:55   ` Bin Meng
2021-10-03 23:34   ` Tom Rini
2021-09-17 12:11 ` [PATCH 10/11] pci: pcie_layerscape_fixup_common: include fdt_support.h for ft_pci_setup Vladimir Oltean
2021-09-18  6:55   ` Bin Meng
2021-10-03 23:34   ` Tom Rini
2021-09-17 12:11 ` [PATCH 11/11] pci: pcie_layerscape_fixup_common: lx2_board_fix_fdt can be static Vladimir Oltean
2021-09-18  6:55   ` Bin Meng
2021-10-03 23:34   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210917121130.526216-2-vladimir.oltean@nxp.com \
    --to=vladimir.oltean@nxp.com \
    --cc=Zhiqiang.Hou@nxp.com \
    --cc=bmeng.cn@gmail.com \
    --cc=priyanka.jain@nxp.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.