All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: netdev@vger.kernel.org
Cc: mkubecek@suse.cz, vadimp@nvidia.com, moshe@nvidia.com,
	popadrian1996@gmail.com, mlxsw@nvidia.com,
	Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH ethtool-next 6/7] sff-8636: Convert if statement to switch-case
Date: Fri, 17 Sep 2021 17:40:42 +0300	[thread overview]
Message-ID: <20210917144043.566049-7-idosch@idosch.org> (raw)
In-Reply-To: <20210917144043.566049-1-idosch@idosch.org>

From: Ido Schimmel <idosch@nvidia.com>

The indentation is wrong and the statement can be more clearly
represented using a switch-case statement. Convert it.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
 qsfp.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/qsfp.c b/qsfp.c
index 3401db84352d..d1464cb50fdc 100644
--- a/qsfp.c
+++ b/qsfp.c
@@ -863,11 +863,13 @@ void sff8636_show_all(const __u8 *id, __u32 eeprom_len)
 	}
 
 	sff8636_show_identifier(id);
-	if ((id[SFF8636_ID_OFFSET] == SFF8024_ID_QSFP) ||
-		(id[SFF8636_ID_OFFSET] == SFF8024_ID_QSFP_PLUS) ||
-		(id[SFF8636_ID_OFFSET] == SFF8024_ID_QSFP28)) {
+	switch (id[SFF8636_ID_OFFSET]) {
+	case SFF8024_ID_QSFP:
+	case SFF8024_ID_QSFP_PLUS:
+	case SFF8024_ID_QSFP28:
 		sff8636_show_page_zero(id);
 		sff8636_show_dom(id, id + 3 * 0x80, eeprom_len);
+		break;
 	}
 }
 
-- 
2.31.1


  parent reply	other threads:[~2021-09-17 14:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 14:40 [PATCH ethtool-next 0/7] ethtool: Small EEPROM changes Ido Schimmel
2021-09-17 14:40 ` [PATCH ethtool-next 1/7] cmis: Fix CLEI code parsing Ido Schimmel
2021-09-30 20:21   ` Michal Kubecek
2021-09-30 20:41     ` Ido Schimmel
2021-09-30 21:12       ` Michal Kubecek
2021-09-17 14:40 ` [PATCH ethtool-next 2/7] cmis: Fix wrong define name Ido Schimmel
2021-09-17 14:40 ` [PATCH ethtool-next 3/7] cmis: Correct comment Ido Schimmel
2021-09-17 14:40 ` [PATCH ethtool-next 4/7] sff-8636: Remove incorrect comment Ido Schimmel
2021-09-17 14:40 ` [PATCH ethtool-next 5/7] sff-8636: Fix incorrect function name Ido Schimmel
2021-09-17 14:40 ` Ido Schimmel [this message]
2021-09-17 14:40 ` [PATCH ethtool-next 7/7] sff-8636: Remove extra blank lines Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210917144043.566049-7-idosch@idosch.org \
    --to=idosch@idosch.org \
    --cc=idosch@nvidia.com \
    --cc=mkubecek@suse.cz \
    --cc=mlxsw@nvidia.com \
    --cc=moshe@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=popadrian1996@gmail.com \
    --cc=vadimp@nvidia.com \
    --subject='Re: [PATCH ethtool-next 6/7] sff-8636: Convert if statement to switch-case' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.