From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C334C433FE for ; Fri, 17 Sep 2021 14:45:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76C8E6124B for ; Fri, 17 Sep 2021 14:45:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233320AbhIQOrD (ORCPT ); Fri, 17 Sep 2021 10:47:03 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:34564 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230264AbhIQOqn (ORCPT ); Fri, 17 Sep 2021 10:46:43 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 18HEiuTn011585; Fri, 17 Sep 2021 09:44:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1631889896; bh=ysv5ZVPe5SGTihFHDPFl1BAEPEEhCTFeV2XgJ/Kb9JI=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=vkJkfidlcpaV16pn0laV4EMyXR17j10FcfVn+xGD7EjPXB9IrGlGJPo2peKTWTjuU CL5kMbRzzYU3Wjvlhd9gxXctwwVQEjercvfN2rbnpQ3L9FsQPX7uEL9HnpLnwcDbPp rOIs8xG78EvoWz3rcBPeXv16+NFGnOeqIHckT2aM= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 18HEiuYu086672 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Sep 2021 09:44:56 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 17 Sep 2021 09:44:55 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Fri, 17 Sep 2021 09:44:55 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 18HEitB9062243; Fri, 17 Sep 2021 09:44:55 -0500 Date: Fri, 17 Sep 2021 09:44:55 -0500 From: Nishanth Menon To: Sinthu Raja CC: Suman Anna , Rob Herring , Baolin Wang , Bjorn Andersson , Ohad Ben-Cohen , , , , , Sinthu Raja Subject: Re: [PATCH] dt-bindings: hwlock: omap: Remove board-specific compatible from DT example Message-ID: <20210917144455.nj6bc2enytlgqmzn@studied> References: <20210917094740.18891-1-sinthu.raja@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210917094740.18891-1-sinthu.raja@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 15:17-20210917, Sinthu Raja wrote: > From: Sinthu Raja > > The example includes a board-specific compatible property, this is > wrong as the example should be board agnostic. Replace the same with a > generic soc node. > > Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML") > Signed-off-by: Sinthu Raja > --- > > This patch was triggered by discussions in [1]. > > When applying the patch, if you could provide an immutable tag for the > bindings, it would help line things up for new platforms to be added for > us. See [2] for the context Aah yes, thanks.. Bjorn.. once Rob acks ofcourse (since this is bindings). Reviewed-by: Nishanth Menon > > [1] https://lore.kernel.org/all/20210818074030.1877-1-sinthu.raja@ti.com/ > [2] https://lore.kernel.org/linux-arm-kernel/20210125141642.4yybjnklk3qsqjdy@steersman/ > > .../devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml > index ae1b37dbee75..d56dc1bebdc6 100644 > --- a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml > +++ b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml > @@ -47,10 +47,8 @@ examples: > }; > > - | > - / { > + soc { > /* K3 AM65x SoCs */ > - model = "Texas Instruments K3 AM654 SoC"; > - compatible = "ti,am654-evm", "ti,am654"; > #address-cells = <2>; > #size-cells = <2>; > > -- > 2.32.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14DCFC433F5 for ; Fri, 17 Sep 2021 14:47:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1E9560F9C for ; Fri, 17 Sep 2021 14:47:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C1E9560F9C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lrzwT9a73vLfrg328nuTUuAMAS2OugpVLYvUerE1yps=; b=jF2BNZ+Te3Ne+c oph0JZmwwPKf/jI2PI93CJ4S+DCrfCLy1U8lS85BULZUSfto+fBquVdcI4R7yiEC9gbJa5yA2hHbs SobfwZQReW/wqyNotgpbdwVLa704lEPvcWSfvgzl/nKIEexdzZfpLTMT+ICyMaKtplIZkGB/ghoMV ttZUXFxTSxu28KRrPlKWxaH5bopxwuSJf4AX2CuWPmR8xDQeQu9OKxiCQd0uf2oajT3WG9tNYV2DP WaarqWaC6n6auNFXLt0mEExavRLFM8vvqQaeeraqtctj0pIG5iztU+y1DEssx2CLLTWg90LY2dI/D Zfc7ttsABZ3AWc4ednXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRF6z-00ERba-1K; Fri, 17 Sep 2021 14:45:09 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRF6v-00ERao-0Y for linux-arm-kernel@lists.infradead.org; Fri, 17 Sep 2021 14:45:07 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 18HEiuTn011585; Fri, 17 Sep 2021 09:44:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1631889896; bh=ysv5ZVPe5SGTihFHDPFl1BAEPEEhCTFeV2XgJ/Kb9JI=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=vkJkfidlcpaV16pn0laV4EMyXR17j10FcfVn+xGD7EjPXB9IrGlGJPo2peKTWTjuU CL5kMbRzzYU3Wjvlhd9gxXctwwVQEjercvfN2rbnpQ3L9FsQPX7uEL9HnpLnwcDbPp rOIs8xG78EvoWz3rcBPeXv16+NFGnOeqIHckT2aM= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 18HEiuYu086672 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Sep 2021 09:44:56 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 17 Sep 2021 09:44:55 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Fri, 17 Sep 2021 09:44:55 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 18HEitB9062243; Fri, 17 Sep 2021 09:44:55 -0500 Date: Fri, 17 Sep 2021 09:44:55 -0500 From: Nishanth Menon To: Sinthu Raja Subject: Re: [PATCH] dt-bindings: hwlock: omap: Remove board-specific compatible from DT example Message-ID: <20210917144455.nj6bc2enytlgqmzn@studied> References: <20210917094740.18891-1-sinthu.raja@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210917094740.18891-1-sinthu.raja@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210917_074505_229185_398B698C X-CRM114-Status: GOOD ( 19.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ohad Ben-Cohen , devicetree@vger.kernel.org, Sinthu Raja , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Rob Herring , Baolin Wang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15:17-20210917, Sinthu Raja wrote: > From: Sinthu Raja > > The example includes a board-specific compatible property, this is > wrong as the example should be board agnostic. Replace the same with a > generic soc node. > > Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML") > Signed-off-by: Sinthu Raja > --- > > This patch was triggered by discussions in [1]. > > When applying the patch, if you could provide an immutable tag for the > bindings, it would help line things up for new platforms to be added for > us. See [2] for the context Aah yes, thanks.. Bjorn.. once Rob acks ofcourse (since this is bindings). Reviewed-by: Nishanth Menon > > [1] https://lore.kernel.org/all/20210818074030.1877-1-sinthu.raja@ti.com/ > [2] https://lore.kernel.org/linux-arm-kernel/20210125141642.4yybjnklk3qsqjdy@steersman/ > > .../devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml > index ae1b37dbee75..d56dc1bebdc6 100644 > --- a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml > +++ b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml > @@ -47,10 +47,8 @@ examples: > }; > > - | > - / { > + soc { > /* K3 AM65x SoCs */ > - model = "Texas Instruments K3 AM654 SoC"; > - compatible = "ti,am654-evm", "ti,am654"; > #address-cells = <2>; > #size-cells = <2>; > > -- > 2.32.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel