From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D85ECC433FE for ; Fri, 17 Sep 2021 17:25:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF7F760F4A for ; Fri, 17 Sep 2021 17:25:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240958AbhIQR0z (ORCPT ); Fri, 17 Sep 2021 13:26:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240938AbhIQR0y (ORCPT ); Fri, 17 Sep 2021 13:26:54 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3186DC061574 for ; Fri, 17 Sep 2021 10:25:31 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id g11so6894474qvd.2 for ; Fri, 17 Sep 2021 10:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=p9Wdpm3PSA3ThdYdzsHmj18B3OFNZmUu9ZK37+B/sXA=; b=MiEhajDEtlfmkDMoND8cuyhvIhfBuSMlc/EhJaGD+lkLlcJuKNZ76xtz6U9+KRKV1C IyvlpwDvhazxPoMO4zautNbQ+zDTNioitudaWEOuIn7iCvMFKAnnXANt3dye7v6UsYLZ ueLzU8q3Mft61+tgDnFm+v6QdiFKePN8WBkNukAKikOZ3+e72vFyRjwJRirDJX794H2P guThBiD/SRfY7ilMSZy7NpqGVt+Vxer/a6tf5JEp/dvL7JECXIoWF2mKA7QVJQTdVszS iY8aFTcXskm8bNmK3+QAJeZUIR4sd7oZOlDwxlF9MZiE5goDAssZlZXT+fTtHewskAbH KlJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=p9Wdpm3PSA3ThdYdzsHmj18B3OFNZmUu9ZK37+B/sXA=; b=QJXwAYYhn7/5QIOy9dl8x/wZgztIDb53xBPUcko8n36S5Jio6HffIo60ZjYd1XlBcI cEli5S/XK2H9fH1nV/mBKtKcVJb1DdvN13ARLD/Dhs17LCuwfsWNxoIU1Y9k4zU63TVX K0iy0GfpVWRDG25eytNZq0N3kQQPTYO/6wg8EaGFB9oAYxfl3Mio0Dg6yakb8I4pg+nH maCl/JvB9l12WlV62i7w7fp2hOafoWUiviglMyECncWRvavl2CfK1he+dJ7PWvx3lDCg U/ARjbAu9K2WzZt5sPQWgiOb9t/9gtKcjGJSN0tvuOyXeTKW5eTzkpC+eQuc0534Xpxx qEAA== X-Gm-Message-State: AOAM5315tns8iVCqELW/m/5/6W2axDiCQnH1iObRzVbbVijS/KmGWmgi Zt8vyUbyK2fw9mApA9+YLGBFJA== X-Google-Smtp-Source: ABdhPJxy0iPe43C+sb2UJxr4WCzMyQAwirLD6q9JPWwd91MwFYk3IdM0k7kiIIS+zm2T3Xr76odp3A== X-Received: by 2002:a0c:e2d3:: with SMTP id t19mr12202361qvl.23.1631899530240; Fri, 17 Sep 2021 10:25:30 -0700 (PDT) Received: from localhost ([167.100.64.199]) by smtp.gmail.com with ESMTPSA id q7sm5295437qkm.68.2021.09.17.10.25.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Sep 2021 10:25:29 -0700 (PDT) Date: Fri, 17 Sep 2021 13:25:25 -0400 From: Sean Paul To: Stephen Boyd Cc: Sean Paul , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Sean Paul , Rob Clark , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 10/13] drm/msm/dpu: Remove encoder->enable() hack Message-ID: <20210917172525.GQ2515@art_vandelay> References: <20210915203834.1439-1-sean@poorly.run> <20210915203834.1439-11-sean@poorly.run> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Sep 16, 2021 at 08:53:50PM -0700, Stephen Boyd wrote: > Quoting Sean Paul (2021-09-15 13:38:29) > > From: Sean Paul > > > > encoder->commit() was being misused because there were some global > > resources which needed to be tweaked in encoder->enable() which were not > > accessible in dpu_encoder.c. That is no longer true and the redirect > > serves no purpose any longer. So remove the indirection. > > When did it become false? Just curious when this became obsolete. In commit commit cd6d923167b1bf3e051f9d90fa129456d78ef06e Author: Rob Clark Date: Thu Aug 29 09:45:17 2019 -0700 drm/msm/dpu: async commit support There was a call to dpu_crtc_commit_kickoff() which was removed from dpu_kms_encoder_enable(). That was the bit which required the back-and-forth between ->enable() and ->commit(). > > > > > Signed-off-by: Sean Paul > > Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-11-sean@poorly.run #v1 > > > > Changes in v2: > > -None > > --- > > Reviewed-by: Stephen Boyd > Tested-by: Stephen Boyd Thanks! -- Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64277C433EF for ; Fri, 17 Sep 2021 17:25:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30706610E9 for ; Fri, 17 Sep 2021 17:25:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 30706610E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 857EA6E03E; Fri, 17 Sep 2021 17:25:32 +0000 (UTC) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2691E6E039 for ; Fri, 17 Sep 2021 17:25:31 +0000 (UTC) Received: by mail-qv1-xf2c.google.com with SMTP id w8so6910921qvt.0 for ; Fri, 17 Sep 2021 10:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=p9Wdpm3PSA3ThdYdzsHmj18B3OFNZmUu9ZK37+B/sXA=; b=MiEhajDEtlfmkDMoND8cuyhvIhfBuSMlc/EhJaGD+lkLlcJuKNZ76xtz6U9+KRKV1C IyvlpwDvhazxPoMO4zautNbQ+zDTNioitudaWEOuIn7iCvMFKAnnXANt3dye7v6UsYLZ ueLzU8q3Mft61+tgDnFm+v6QdiFKePN8WBkNukAKikOZ3+e72vFyRjwJRirDJX794H2P guThBiD/SRfY7ilMSZy7NpqGVt+Vxer/a6tf5JEp/dvL7JECXIoWF2mKA7QVJQTdVszS iY8aFTcXskm8bNmK3+QAJeZUIR4sd7oZOlDwxlF9MZiE5goDAssZlZXT+fTtHewskAbH KlJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=p9Wdpm3PSA3ThdYdzsHmj18B3OFNZmUu9ZK37+B/sXA=; b=cs8M08UQ2epbiknjroGbcdQ6+ey+UJlwKJ3u/SCGokCOI2rxg7IBcazlxRxsamw9gH 24zg7CylUUJ9d7zdklO5SRczBwUpTHI/g9OO8M7tR00UTrMXZrCxom/QzHOa4OjjczsL YCeZ4tKOFUV3iDFaReZdC4lYpWAle80obnpCZUXAOwfd4stxVUgd2tOYlLQy7l8Zd5oP 5QeHb1sQeQ17VF65HgNVrOJXJUZUHIbih2UEPKsRJcu2pIVt8kK4PJUbbfGwmh6Vqcn/ keYpjkc2fS/8YgCOUkEF2YjWPqnmMct5h4UBDTHFTIWmykzmnLjgtY5CGcBv+SLiCHpw ndyA== X-Gm-Message-State: AOAM533Ly/phKOeLdyj1rNB/BxsNPbdgSimVgwyJMBSmOyG9APaxBjc4 f/kG4g5UnhHFIeapYhbOqPEblg== X-Google-Smtp-Source: ABdhPJxy0iPe43C+sb2UJxr4WCzMyQAwirLD6q9JPWwd91MwFYk3IdM0k7kiIIS+zm2T3Xr76odp3A== X-Received: by 2002:a0c:e2d3:: with SMTP id t19mr12202361qvl.23.1631899530240; Fri, 17 Sep 2021 10:25:30 -0700 (PDT) Received: from localhost ([167.100.64.199]) by smtp.gmail.com with ESMTPSA id q7sm5295437qkm.68.2021.09.17.10.25.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Sep 2021 10:25:29 -0700 (PDT) Date: Fri, 17 Sep 2021 13:25:25 -0400 From: Sean Paul To: Stephen Boyd Cc: Sean Paul , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Sean Paul , Rob Clark , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org Message-ID: <20210917172525.GQ2515@art_vandelay> References: <20210915203834.1439-1-sean@poorly.run> <20210915203834.1439-11-sean@poorly.run> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH v2 10/13] drm/msm/dpu: Remove encoder->enable() hack X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Sep 16, 2021 at 08:53:50PM -0700, Stephen Boyd wrote: > Quoting Sean Paul (2021-09-15 13:38:29) > > From: Sean Paul > > > > encoder->commit() was being misused because there were some global > > resources which needed to be tweaked in encoder->enable() which were not > > accessible in dpu_encoder.c. That is no longer true and the redirect > > serves no purpose any longer. So remove the indirection. > > When did it become false? Just curious when this became obsolete. In commit commit cd6d923167b1bf3e051f9d90fa129456d78ef06e Author: Rob Clark Date: Thu Aug 29 09:45:17 2019 -0700 drm/msm/dpu: async commit support There was a call to dpu_crtc_commit_kickoff() which was removed from dpu_kms_encoder_enable(). That was the bit which required the back-and-forth between ->enable() and ->commit(). > > > > > Signed-off-by: Sean Paul > > Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-11-sean@poorly.run #v1 > > > > Changes in v2: > > -None > > --- > > Reviewed-by: Stephen Boyd > Tested-by: Stephen Boyd Thanks! -- Sean Paul, Software Engineer, Google / Chromium OS