From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA507C4332F for ; Fri, 17 Sep 2021 22:02:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0E7E6112E for ; Fri, 17 Sep 2021 22:02:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344640AbhIQWDh (ORCPT ); Fri, 17 Sep 2021 18:03:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344401AbhIQWDg (ORCPT ); Fri, 17 Sep 2021 18:03:36 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84E90C061574 for ; Fri, 17 Sep 2021 15:02:13 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id c8so38432986lfi.3 for ; Fri, 17 Sep 2021 15:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=znAe7ewx7rCSOAdsfm/NBUX+TUdTojIOSWYXmGT9kJY=; b=BiV/2Re8gTOEq754wm9xZr5SQTOn6jjqymEgSYMv/GPL37PMahL91jKVHZGSuxMQ/Y FpCVnXYOAefaT505OcZixPlQEyFF7emGaGoCcqyaa7u5+Haj7FlHN6KjNUY0O0iZ75zD b6pwrA6rQhAZNxIRkuZCLwM+udhUX4qCzZ00urqfyItObHUfW5VYEi+UX7rtDt16Gi9C XSRvBKiuo0aDlcRyteieFM2UYe3w4t4mNG3k1ZsqhLGVMEEND1U+m5WO5ZHUZYUyCmCx YSS1VH09OP14J1ADc6/JQ5Wj3sk07N60cGmqYI5tnERyT5CoCVVD7Xe91gITm7SXbRrp pReQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=znAe7ewx7rCSOAdsfm/NBUX+TUdTojIOSWYXmGT9kJY=; b=NkTRXpD2kAqWCb4jZzmlPsrPYBWnGpy+rcE/TISioxIdH8H2Jerk9AEEx7Juz5RY7L Xuefanvi/+QcibIdggXeuXVg5CjU6civQQJXbh15Xxi8hinM8AomnBe7Od0BfEpLA2e2 zdtgLvsKzaNEU5KAjBVjT7x5pVmEnHd81Gn/6lOsPCWjCUbuCb/tT24QBHpJ0dE15Akf 3JE905zpRCkCW/7ytzyj4QL45jM67k9fK3ZwbvkBEaxCpbQW0ZoWy93NtGbeRSV0a+uY NYp00iyHaKtdKBlIXMmny2RuvEcqU6hAf95/u4A0epIuu/OGQjx3OjfDa6PAVdGBesPX 0HsA== X-Gm-Message-State: AOAM533S1xfnfSleDNFAkWyo0dxc7tcqCx4+HIlMoR38ep6UTiAKinJO 43cqxyaUCHXv5L3PcWe30qIjMQ== X-Google-Smtp-Source: ABdhPJyf4+itBme+L5CJNkEh3rv/yMj9GUuPX48RaK3E/af8ir/KWxFqHjLMEmbr1OBIHEQbNgBRKg== X-Received: by 2002:a05:6512:344f:: with SMTP id j15mr9427594lfr.56.1631916131856; Fri, 17 Sep 2021 15:02:11 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id o21sm616352lfu.4.2021.09.17.15.02.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Sep 2021 15:02:11 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 52ECD103041; Sat, 18 Sep 2021 01:02:09 +0300 (+03) Date: Sat, 18 Sep 2021 01:02:09 +0300 From: "Kirill A. Shutemov" To: Kent Overstreet Cc: Johannes Weiner , Dave Chinner , "Darrick J. Wong" , Matthew Wilcox , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Christoph Hellwig , David Howells Subject: Re: Folio discussion recap Message-ID: <20210917220209.zhac33jiqtxvdttk@box> References: <20210916025854.GE34899@magnolia> <20210917052440.GJ1756565@dread.disaster.area> <20210917205735.tistsacwwzkcdklx@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 17, 2021 at 05:17:09PM -0400, Kent Overstreet wrote: > On Fri, Sep 17, 2021 at 11:57:35PM +0300, Kirill A. Shutemov wrote: > > On Fri, Sep 17, 2021 at 12:31:36PM -0400, Johannes Weiner wrote: > > > I didn't suggest to change what the folio currently already is for the > > > page cache. I asked to keep anon pages out of it (and in the future > > > potentially other random stuff that is using compound pages). > > > > It would mean that anon-THP cannot benefit from the work Willy did with > > folios. Anon-THP is the most active user of compound pages at the moment > > and it also suffers from the compound_head() plague. You ask to exclude > > anon-THP siting *possible* future benefits for pagecache. > > > > Sorry, but this doesn't sound fair to me. > > I'm less concerned with what's fair than figuring out what the consensus is so > we can move forward. I agree that anonymous THPs could benefit greatly from > conversion to folios - but looking at the code it doesn't look like much of that > has been done yet. > > I understand you've had some input into the folio patches, so maybe you'd be > best able to answer while Matthew is away - would it be fair to say that, in the > interests of moving forward, anonymous pages could be split out for now? That > way the MM people gain time to come to their own consensus and we can still > unblock the FS work that's already been done on top of folios. I can't answer for Matthew. Anon conversion patchset doesn't exists yet (but it is in plans) so there's nothing to split out. Once someone will come up with such patchset he has to sell it upstream on its own merit. Possible future efforts should not block code at hands. "Talk is cheap. Show me the code." -- Kirill A. Shutemov