All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	martin@kaiser.cx, fmdefrancesco@gmail.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Michael Straube <straube.linux@gmail.com>
Subject: [PATCH 06/12] staging: r8188eu: remove more dead code from ODM_Write_DIG()
Date: Sat, 18 Sep 2021 01:30:42 +0200	[thread overview]
Message-ID: <20210917233048.31677-7-straube.linux@gmail.com> (raw)
In-Reply-To: <20210917233048.31677-1-straube.linux@gmail.com>

SupportICType is ODM_RTL8188E in this driver. Remove code that is
never executed.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
 drivers/staging/r8188eu/hal/odm.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/hal/odm.c
index cac4f8ff7b63..48c10b78f4a5 100644
--- a/drivers/staging/r8188eu/hal/odm.c
+++ b/drivers/staging/r8188eu/hal/odm.c
@@ -466,12 +466,8 @@ void ODM_Write_DIG(struct odm_dm_struct *pDM_Odm, u8 CurrentIGI)
 
 	if (pDM_DigTable->CurIGValue != CurrentIGI) {
 		ODM_SetBBReg(pDM_Odm, ODM_REG(IGI_A, pDM_Odm), ODM_BIT(IGI, pDM_Odm), CurrentIGI);
-		if (pDM_Odm->SupportICType != ODM_RTL8188E)
-			ODM_SetBBReg(pDM_Odm, ODM_REG(IGI_B, pDM_Odm), ODM_BIT(IGI, pDM_Odm), CurrentIGI);
-
 		pDM_DigTable->CurIGValue = CurrentIGI;
 	}
-/*  Add by Neil Chen to enable edcca to MP Platform */
 }
 
 /* Need LPS mode for CE platform --2012--08--24--- */
-- 
2.33.0


  parent reply	other threads:[~2021-09-17 23:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 23:30 [PATCH 00/12] staging: r8188eu: remove odm_RegDefine11AC.h Michael Straube
2021-09-17 23:30 ` [PATCH 01/12] staging: r8188eu: remove comments from odm_interface.h Michael Straube
2021-09-17 23:30 ` [PATCH 02/12] staging: r8188eu: remove unused macros " Michael Straube
2021-09-17 23:30 ` [PATCH 03/12] staging: r8188eu: remove _ic_type from macro _cat in odm_interface.h Michael Straube
2021-09-17 23:30 ` [PATCH 04/12] staging: r8188eu: remove dead code from ODM_Write_DIG() Michael Straube
2021-09-17 23:30 ` [PATCH 05/12] staging: r8188eu: remove unnecessary if statement Michael Straube
2021-09-17 23:30 ` Michael Straube [this message]
2021-09-17 23:30 ` [PATCH 07/12] staging: r8188eu: remove macro ODM_REG Michael Straube
2021-09-17 23:30 ` [PATCH 08/12] staging: r8188eu: remove macro ODM_BIT Michael Straube
2021-09-17 23:30 ` [PATCH 09/12] staging: r8188eu: remove unnecessary if statements Michael Straube
2021-09-17 23:30 ` [PATCH 10/12] staging: r8188eu: remove dead code from odm.c Michael Straube
2021-09-17 23:30 ` [PATCH 11/12] staging: r8188eu: remove ODM_IC_11N_SERIES, ODM_IC_11AC_SERIES macros Michael Straube
2021-09-18  9:12   ` Michael Straube
2021-09-17 23:30 ` [PATCH 12/12] staging: r8188eu: remove header file odm_RegDefine11AC.h Michael Straube

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210917233048.31677-7-straube.linux@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=fmdefrancesco@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.