From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8834EC433FE for ; Sat, 18 Sep 2021 11:50:26 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF03F6126A for ; Sat, 18 Sep 2021 11:50:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AF03F6126A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A317182D1C; Sat, 18 Sep 2021 13:50:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="id+3G0vh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0BA1B82DC3; Sat, 18 Sep 2021 13:50:19 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0619.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0e::619]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 53E8C82BE5 for ; Sat, 18 Sep 2021 13:50:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X2z+3msTqeLW3b4Pt0j7vkRztG1atBRCyvfbtXQljrh//y0jBUEalw/PfraHB8DJjWBphTd79FUx51K5vjKRH9/EwiYcG1j1vJw96u5hHZnHwNmHy3nubQu5MGwr78dqykfIHEdxVVgK39VLst7RS05DY5uVXhyzNnqDkaW1/L+VVvdBhBK4okubHEyElW/QgMHKMo7zLOyfPUaqDucGXM7v3tBmfK9JH1nEqX5dsNFkZOmfveF5ROA8EqsW/CIbvw2/gbtofNpiOd1Ivpm2R4aRqWLS+E6vVFd6noLSxmarBI6Jl2QBwq/86cLwnE9C70nOcaT2zZ3buanHW3tqqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=aTJ3a4pHpkYWcOJ6zQ1IZZt5luhKZKt8+/XUg5l4KSM=; b=nOwey3ewN3tbfl2g6mUzotsjN7qC/Wi27Z3gvBNCjWLFoZQ8X+dJhiGXoLcwV79RUs6ekv5hs41vO1kfmq/QLExZZ9y72KmC3qAkx1Cu5lQYbK76sgldGUYOusx0OcDXHX7iIZpcADIIkelLdAfzjKIeyr/xQFW9+tVUNnUlf/MybmiBfK8Jmjdehd5DLa8jz/j8QrKxD4VPQs7D/OP8m8ezZye9AsA1X35VAk7ldEowBFGLbBpzotil61lhyhON+Ajgjq2aEErVSW/yX2e6P07m7nzUNAU04NI9geV5K6wAHkjWBq7KIRKWN/u8iVG3lRkM2ApciH3rCbp5/gQMOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aTJ3a4pHpkYWcOJ6zQ1IZZt5luhKZKt8+/XUg5l4KSM=; b=id+3G0vh6UyU1dBcy7bBruYx9Y1LLVKHeXD7H0jv4jCx1koJW1YyiCVFivPwGBFqDsMn4mn5hzR8J08xY0EotxH1GrqSVJ4YEOACSjVJqhaXVxI+4yjgwWh66dKo0cvr0NulxBA0tx3cRUShIdGUsbjFVjuGIotBYJJU3VYsw7M= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR04MB6016.eurprd04.prod.outlook.com (2603:10a6:803:d3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Sat, 18 Sep 2021 11:50:08 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4500.021; Sat, 18 Sep 2021 11:50:08 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de Cc: Joe Hershberger , Ramon Fried , Tim Harvey , Michael Walle Subject: [PATCH 1/2] net: dsa: pass CPU port fixed PHY to .port_disable Date: Sat, 18 Sep 2021 14:49:55 +0300 Message-Id: <20210918114956.1064294-2-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210918114956.1064294-1-vladimir.oltean@nxp.com> References: <20210918114956.1064294-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: VI1P195CA0095.EURP195.PROD.OUTLOOK.COM (2603:10a6:802:59::48) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (82.78.148.104) by VI1P195CA0095.EURP195.PROD.OUTLOOK.COM (2603:10a6:802:59::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16 via Frontend Transport; Sat, 18 Sep 2021 11:50:07 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4d7bd01f-9547-4207-1dfe-08d97a9a7657 X-MS-TrafficTypeDiagnostic: VI1PR04MB6016: X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ugKjn2ZHEUihrx73SGlPyfbZSGBnqAQkhASrV76KG+6VFitHCWbCcm4h0gUzjIRypaOKi+R6EMhF5MPf/Ev9xYNugYaH9gLBdeekpnhVNW2tdESb1Azq58Af5QGPW5YiTRrir6/pCx8dptKcQ1YkYX+3rkw4vdyE+o56Q4V++90H2F2t14cyl5niRGpZf+KeJC4EXDmAOgp7x7icUlk1mEbZvMTIlraBVyncOp1g6nrPClVxSI29K2CjVNetxETVyJzEIz3fA4GgnauzYkBudaF4eHj6phJ3FCJT0s6tORCugXduF8zGOpWw1vOI/li6qXt4PN1nNGfQOcIY4FFFFE2Uh8tVjrYfpdOAnLcH9aIDdeJ9PGTaNumcSvhjOhK1nWcM7qeYzfKBt9394gBD/Lc3QHxZbvIutfhZA9VhtE0oeHKJ8GML0jyRunDyBg5G2Q2JEQcAi8Ct3EKr+n1xvm41TRmf9+4llVb1Pf8eK/lyOicPBg7aPd3xWw+dqF/Yi2m4Q+rvMmc6ck+ZuD3HmIUcaKQlMDofFj6yQ9kN96UbzwgXKzmEPXA+MwftfZgaCRRxyufhMmDgZkTC4kIoQqyCwIVkr33LdqpMsjsBkre2laNv9ZPITBm0pT0BiPDkdXEGmMb+AgRhNCPPZIdKMXVzyZyb5+HkyDZmkM1wdUEnJ2JIrFNQZhSqnmKIphsvrxqKNvqWgnlXZYzyqthvxkehETa7OrRgFwcndE3XdzE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(376002)(396003)(346002)(366004)(66946007)(66556008)(6916009)(66476007)(956004)(8936002)(4326008)(38350700002)(2906002)(26005)(6486002)(36756003)(38100700002)(44832011)(6506007)(316002)(186003)(6512007)(478600001)(52116002)(86362001)(8676002)(54906003)(5660300002)(83380400001)(6666004)(1076003)(4744005)(2616005)(142923001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BAE9MGy8uRq9pUGc6JDqqore8VkI5sj1FT3Fp6LrjAY7Gz3QoUemVKRnyfKr?= =?us-ascii?Q?34Udl0mUYs1lI2jwXBHl3qW8mAtPdPdbcNE+gvzBH2CbWrWiqFm2csTQiODl?= =?us-ascii?Q?p4hug5eaVZXDV8eguZ6A+XVqVD3Dv11LLpev0NbvSAih6ZbevWzzAwpJf+VE?= =?us-ascii?Q?K4lO+1cXBES6UxKvv376Rpue0H4whgN3/GZ3kMf518bgEZ1f926VQcbY0Zf3?= =?us-ascii?Q?AJaE3V15Cc69t/NcHN+rms/nZWVOsW3KiPusS3wlKdgFExzJSLhsRK2M3OPY?= =?us-ascii?Q?LeC+vS7fA9HmuSr/acFNntRPx06GUrwWlq5xEbQrpR2rhXpdPPaYHEjr5ZEx?= =?us-ascii?Q?fhFmMWqRrpQ+2VCOWZo6XK6YpJ+WgtxZDdFLZHOQkxrsIlrvzrS6oFNHJqMN?= =?us-ascii?Q?qeER9jLsHeIvJrG0ruiy+nrxtv9MYV0UbIlXnjWKqIk6s2T4ZzflwX9cI6dO?= =?us-ascii?Q?guSNBBSZxaK+96XNoM/y0AQCTob1ctcrvL5eofgshwnrs8nXU7w/GuNNvZ0X?= =?us-ascii?Q?v1pB9FNhGj4Vp4lFdQ6q1PJ9ljw3leBGRHUNl2wN2DuM/safDE326dUtnT1Z?= =?us-ascii?Q?zJuIc1Y+iRnXZEuIKJRirHyfo3BLzX9XauKRy5jXox4XpbmzuKaZdVpi06sk?= =?us-ascii?Q?1Fda1qynXU4ZrAPj3Fytge1E+9ok74BHp4StKIBlwj0EmjyKuFMph9rVZZv1?= =?us-ascii?Q?PNV9kX/vrCWgMW+TmRq8uTqI2rmuHlzxfIFYoiraUsB4g7YGtpdQh/YxWtrZ?= =?us-ascii?Q?++4ad3ptYN5xA5lioUIxnZ8hsNJH40Fsfm1QrK56Dmvw2XdVRgfUPWxO88lQ?= =?us-ascii?Q?zX4jmP5G+WyVvR8XXe1orVwHUYztSE132sRW0m1/4mRvU1B47Eau6zwlZU68?= =?us-ascii?Q?YGLpvvlT/6tM0OYOrj9fuhxCO7OOJdNONkbvtga9iyag5YeZ7TaegnZkP3Bw?= =?us-ascii?Q?LNl+ut8D5b6sfSVTuseNCpWo0kFRRVmqyIDGgyLZHDHGLRGDUJw94a5PhlTB?= =?us-ascii?Q?XFNUF4+3vySQoKgkoFDTSkFtnmOc10eWvunCPgzGogZ3+uwFwILRI84QVzs/?= =?us-ascii?Q?4suP0YQ1mhfHaJ7T2ABAzqI3HpktDJGEgS+FWIZXZaDlOmxVr/kpebmme/qG?= =?us-ascii?Q?F4JlhkDqS+oUqPFl2v8ZOS9L2ezuqqOCfRAAYQqCgrS8VWK3jM8Z5sM6Y0YF?= =?us-ascii?Q?pxqQTnjX0pyAbe1KYRzC9NDpD9i/RnkceyzviLZwvwgvwN53p7oFwiz2/VFA?= =?us-ascii?Q?6mFZuaWv2Bc9JRKKXn6IWzDMUIjeEQq+cwZ5J0a9wVhaUoAIncl4jjFWy2oW?= =?us-ascii?Q?gSbFZo/ZvCgScjajp2QRpBeY?= X-MS-Exchange-Transport-Forked: True X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d7bd01f-9547-4207-1dfe-08d97a9a7657 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2021 11:50:07.9748 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ghpz5d3am2D8UIf5mU7eKy1fVR6q5HghBK3jE4UYkYsjbmSuXPtu/1/8lIc+uOrLrp9vM4zf1uWHrcdwqprSGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6016 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean While adding the logic for DSA to register a fixed-link PHY for the CPU port, I forgot to pass it to the .port_disable method too, just .port_enable. Bug had no impact for felix_switch.c, due to the phy argument not being used, but ksz9477.c does use it => NULL pointer dereference. Fixes: fc054d563bfb ("net: Introduce DSA class for Ethernet switches") Signed-off-by: Vladimir Oltean --- net/dsa-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c index 9b8ae1e82b92..d1c6c78acd6c 100644 --- a/net/dsa-uclass.c +++ b/net/dsa-uclass.c @@ -100,7 +100,7 @@ static void dsa_port_stop(struct udevice *pdev) port_pdata = dev_get_parent_plat(pdev); ops->port_disable(dev, port_pdata->index, port_pdata->phy); - ops->port_disable(dev, priv->cpu_port, NULL); + ops->port_disable(dev, priv->cpu_port, priv->cpu_port_fixed_phy); } eth_get_ops(master)->stop(master); -- 2.25.1