* [ast-bpf:relo_core 5/11] kernel/bpf/btf.c:6498:6: warning: variable 'err' set but not used
@ 2021-09-18 7:53 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-09-18 7:53 UTC (permalink / raw)
To: Alexei Starovoitov; +Cc: llvm, kbuild-all, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2752 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/ast/bpf.git relo_core
head: 35a0182c26565e1db43f99a764834bff8a2e4202
commit: 98beca424883749fbcf9f244bb26c96ed3102502 [5/11] bpf: Add bpf_core_add_cands() and wire it into bpf_core_apply_relo_insn().
config: x86_64-randconfig-a002-20210918 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c8b3d7d6d6de37af68b2f379d0e37304f78e115f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/ast/bpf.git/commit/?id=98beca424883749fbcf9f244bb26c96ed3102502
git remote add ast-bpf https://git.kernel.org/pub/scm/linux/kernel/git/ast/bpf.git
git fetch --no-tags ast-bpf relo_core
git checkout 98beca424883749fbcf9f244bb26c96ed3102502
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> kernel/bpf/btf.c:6498:6: warning: variable 'err' set but not used [-Wunused-but-set-variable]
int err;
^
1 warning generated.
vim +/err +6498 kernel/bpf/btf.c
6491
6492 BPF_CALL_5(bpf_core_apply_relo, int, btf_fd, struct bpf_core_relo_desc *, relo,
6493 int, relo_sz, void *, insn, int, flags)
6494 {
6495 struct bpf_core_cand_list *cands = NULL;
6496 struct bpf_core_relo core_relo = {};
6497 struct btf *btf;
> 6498 int err;
6499
6500 if (flags)
6501 return -EINVAL;
6502
6503 if (sizeof(*relo) != relo_sz)
6504 return -EINVAL;
6505 btf = btf_get_by_fd(btf_fd);
6506 if (IS_ERR(btf))
6507 return PTR_ERR(btf);
6508 if (btf_is_kernel(btf)) {
6509 btf_put(btf);
6510 return -EACCES;
6511 }
6512 if (relo->kind != BPF_CORE_TYPE_ID_LOCAL) {
6513 cands = bpf_core_find_cands(btf, relo->type_id);
6514 if (IS_ERR(cands)) {
6515 btf_put(btf);
6516 printk("target candidate search failed for %d\n",
6517 relo->type_id);
6518 return PTR_ERR(cands);
6519 }
6520 }
6521 core_relo.type_id = relo->type_id;
6522 core_relo.access_str_off = relo->access_str_off;
6523 core_relo.kind = relo->kind;
6524 err = bpf_core_apply_relo_insn("prog_name", insn, 0, &core_relo, 0, btf, cands);
6525 btf_put(btf);
6526 return 0;
6527 }
6528
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28262 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [ast-bpf:relo_core 5/11] kernel/bpf/btf.c:6498:6: warning: variable 'err' set but not used
@ 2021-09-18 7:53 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-09-18 7:53 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2824 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/ast/bpf.git relo_core
head: 35a0182c26565e1db43f99a764834bff8a2e4202
commit: 98beca424883749fbcf9f244bb26c96ed3102502 [5/11] bpf: Add bpf_core_add_cands() and wire it into bpf_core_apply_relo_insn().
config: x86_64-randconfig-a002-20210918 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c8b3d7d6d6de37af68b2f379d0e37304f78e115f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/ast/bpf.git/commit/?id=98beca424883749fbcf9f244bb26c96ed3102502
git remote add ast-bpf https://git.kernel.org/pub/scm/linux/kernel/git/ast/bpf.git
git fetch --no-tags ast-bpf relo_core
git checkout 98beca424883749fbcf9f244bb26c96ed3102502
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> kernel/bpf/btf.c:6498:6: warning: variable 'err' set but not used [-Wunused-but-set-variable]
int err;
^
1 warning generated.
vim +/err +6498 kernel/bpf/btf.c
6491
6492 BPF_CALL_5(bpf_core_apply_relo, int, btf_fd, struct bpf_core_relo_desc *, relo,
6493 int, relo_sz, void *, insn, int, flags)
6494 {
6495 struct bpf_core_cand_list *cands = NULL;
6496 struct bpf_core_relo core_relo = {};
6497 struct btf *btf;
> 6498 int err;
6499
6500 if (flags)
6501 return -EINVAL;
6502
6503 if (sizeof(*relo) != relo_sz)
6504 return -EINVAL;
6505 btf = btf_get_by_fd(btf_fd);
6506 if (IS_ERR(btf))
6507 return PTR_ERR(btf);
6508 if (btf_is_kernel(btf)) {
6509 btf_put(btf);
6510 return -EACCES;
6511 }
6512 if (relo->kind != BPF_CORE_TYPE_ID_LOCAL) {
6513 cands = bpf_core_find_cands(btf, relo->type_id);
6514 if (IS_ERR(cands)) {
6515 btf_put(btf);
6516 printk("target candidate search failed for %d\n",
6517 relo->type_id);
6518 return PTR_ERR(cands);
6519 }
6520 }
6521 core_relo.type_id = relo->type_id;
6522 core_relo.access_str_off = relo->access_str_off;
6523 core_relo.kind = relo->kind;
6524 err = bpf_core_apply_relo_insn("prog_name", insn, 0, &core_relo, 0, btf, cands);
6525 btf_put(btf);
6526 return 0;
6527 }
6528
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28262 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-18 7:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-18 7:53 [ast-bpf:relo_core 5/11] kernel/bpf/btf.c:6498:6: warning: variable 'err' set but not used kernel test robot
2021-09-18 7:53 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.