* [PATCH] iio: ssp_sensors: fix error code in ssp_print_mcu_debug()
@ 2021-09-14 10:53 Dan Carpenter
2021-09-18 18:13 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-09-14 10:53 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: Lars-Peter Clausen, linux-iio, kernel-janitors
The ssp_print_mcu_debug() function should return negative error codes on
error. Returning "length" is meaningless. This change does not affect
runtime because the callers only care about zero/non-zero.
Reported-by: Jonathan Cameron <jic23@kernel.org>
Fixes: 50dd64d57eee ("iio: common: ssp_sensors: Add sensorhub driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/iio/common/ssp_sensors/ssp_spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/common/ssp_sensors/ssp_spi.c b/drivers/iio/common/ssp_sensors/ssp_spi.c
index 4864c38b8d1c..77449b4f3df5 100644
--- a/drivers/iio/common/ssp_sensors/ssp_spi.c
+++ b/drivers/iio/common/ssp_sensors/ssp_spi.c
@@ -137,7 +137,7 @@ static int ssp_print_mcu_debug(char *data_frame, int *data_index,
if (length > received_len - *data_index || length <= 0) {
ssp_dbg("[SSP]: MSG From MCU-invalid debug length(%d/%d)\n",
length, received_len);
- return length ? length : -EPROTO;
+ return -EPROTO;
}
ssp_dbg("[SSP]: MSG From MCU - %s\n", &data_frame[*data_index]);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: ssp_sensors: fix error code in ssp_print_mcu_debug()
2021-09-14 10:53 [PATCH] iio: ssp_sensors: fix error code in ssp_print_mcu_debug() Dan Carpenter
@ 2021-09-18 18:13 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-09-18 18:13 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Lars-Peter Clausen, linux-iio, kernel-janitors
On Tue, 14 Sep 2021 13:53:33 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The ssp_print_mcu_debug() function should return negative error codes on
> error. Returning "length" is meaningless. This change does not affect
> runtime because the callers only care about zero/non-zero.
>
> Reported-by: Jonathan Cameron <jic23@kernel.org>
> Fixes: 50dd64d57eee ("iio: common: ssp_sensors: Add sensorhub driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/common/ssp_sensors/ssp_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/ssp_sensors/ssp_spi.c b/drivers/iio/common/ssp_sensors/ssp_spi.c
> index 4864c38b8d1c..77449b4f3df5 100644
> --- a/drivers/iio/common/ssp_sensors/ssp_spi.c
> +++ b/drivers/iio/common/ssp_sensors/ssp_spi.c
> @@ -137,7 +137,7 @@ static int ssp_print_mcu_debug(char *data_frame, int *data_index,
> if (length > received_len - *data_index || length <= 0) {
> ssp_dbg("[SSP]: MSG From MCU-invalid debug length(%d/%d)\n",
> length, received_len);
> - return length ? length : -EPROTO;
> + return -EPROTO;
> }
>
> ssp_dbg("[SSP]: MSG From MCU - %s\n", &data_frame[*data_index]);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-18 18:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-14 10:53 [PATCH] iio: ssp_sensors: fix error code in ssp_print_mcu_debug() Dan Carpenter
2021-09-18 18:13 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.