[PATCH] tcg/tci: Remove its experimental status

[PATCH] tcg/tci: Remove its experimental status

[Philippe Mathieu-Daudé]

The following commits (released in v6.0.0) made raised the
quality of the TCI backend to the other TCG architectures,
thus is is not considerated experimental anymore:
- c6fbea47664..2f74f45e32b
- dc09f047edd..9e9acb7b348
- b6139eb0578..2fc6f16ca5e
- dbcbda2cd84..5e8892db93f

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 docs/about/build-platforms.rst | 4 ++--
 configure                      | 2 +-
 meson.build                    | 4 ++--
 meson_options.txt              | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/docs/about/build-platforms.rst b/docs/about/build-platforms.rst
index bcb15497213..2eff89e8cba 100644
--- a/docs/about/build-platforms.rst
+++ b/docs/about/build-platforms.rst
@@ -56,8 +56,8 @@ Those hosts are officially supported, with various accelerators:
 
 Other host architectures are not supported. It is possible to build QEMU on an
 unsupported host architecture using the configure ``--enable-tcg-interpreter``
-option to enable the experimental TCI support, but note that this is very slow
-and is not recommended.
+option to enable the TCI support, but note that this is very slow and is not
+recommended.
 
 Non-supported architectures may be removed in the future following the
 :ref:`deprecation process<Deprecated features>`.
diff --git a/configure b/configure
index 1043ccce4f9..26c0d0128c0 100755
--- a/configure
+++ b/configure
@@ -1814,7 +1814,7 @@ Advanced options (experts only):
   --with-trace-file=NAME   Full PATH,NAME of file to store traces
                            Default:trace-<pid>
   --disable-slirp          disable SLIRP userspace network connectivity
-  --enable-tcg-interpreter enable TCI (TCG with bytecode interpreter, experimental and slow)
+  --enable-tcg-interpreter enable TCI (TCG with bytecode interpreter, slow)
   --enable-malloc-trim     enable libc malloc_trim() for memory optimization
   --oss-lib                path to OSS library
   --cpu=CPU                Build for host CPU [$cpu]
diff --git a/meson.build b/meson.build
index 2711cbb789c..8b52675d7e8 100644
--- a/meson.build
+++ b/meson.build
@@ -249,7 +249,7 @@
 if not get_option('tcg').disabled()
   if cpu not in supported_cpus
     if get_option('tcg_interpreter')
-      warning('Unsupported CPU @0@, will use TCG with TCI (experimental and slow)'.format(cpu))
+      warning('Unsupported CPU @0@, will use TCG with TCI (slow)'.format(cpu))
     else
       error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu))
     endif
@@ -2987,7 +2987,7 @@
 summary_info += {'TCG support':       config_all.has_key('CONFIG_TCG')}
 if config_all.has_key('CONFIG_TCG')
   if get_option('tcg_interpreter')
-    summary_info += {'TCG backend':   'TCI (TCG with bytecode interpreter, experimental and slow)'}
+    summary_info += {'TCG backend':   'TCI (TCG with bytecode interpreter, slow)'}
   else
     summary_info += {'TCG backend':   'native (@0@)'.format(cpu)}
   endif
diff --git a/meson_options.txt b/meson_options.txt
index a9a9b8f4c6a..3a77a93ad7f 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -42,7 +42,7 @@ option('xen_pci_passthrough', type: 'feature', value: 'auto',
 option('tcg', type: 'feature', value: 'auto',
        description: 'TCG support')
 option('tcg_interpreter', type: 'boolean', value: false,
-       description: 'TCG with bytecode interpreter (experimental and slow)')
+       description: 'TCG with bytecode interpreter (slow)')
 option('cfi', type: 'boolean', value: 'false',
        description: 'Control-Flow Integrity (CFI)')
 option('cfi_debug', type: 'boolean', value: 'false',
-- 
2.31.1

Re: [PATCH] tcg/tci: Remove its experimental status

[Stefan Weil]

Am 20.09.21 um 08:23 schrieb Philippe Mathieu-Daudé:

> The following commits (released in v6.0.0) made raised the
> quality of the TCI backend to the other TCG architectures,
> thus is is not considerated experimental anymore:
> - c6fbea47664..2f74f45e32b
> - dc09f047edd..9e9acb7b348
> - b6139eb0578..2fc6f16ca5e
> - dbcbda2cd84..5e8892db93f
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   docs/about/build-platforms.rst | 4 ++--
>   configure                      | 2 +-
>   meson.build                    | 4 ++--
>   meson_options.txt              | 2 +-
>   4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/docs/about/build-platforms.rst b/docs/about/build-platforms.rst
> index bcb15497213..2eff89e8cba 100644
> --- a/docs/about/build-platforms.rst
> +++ b/docs/about/build-platforms.rst
> @@ -56,8 +56,8 @@ Those hosts are officially supported, with various accelerators:
>   
>   Other host architectures are not supported. It is possible to build QEMU on an
>   unsupported host architecture using the configure ``--enable-tcg-interpreter``
> -option to enable the experimental TCI support, but note that this is very slow
> -and is not recommended.
> +option to enable the TCI support, but note that this is very slow and is not
> +recommended.


Maybe "recommended for normal use." or a similar statement?

Reviewed-by: Stefan Weil <sw@weilnetz.de>

Re: [PATCH] tcg/tci: Remove its experimental status

[Richard Henderson]

On 9/19/21 11:23 PM, Philippe Mathieu-Daudé wrote:
>   Other host architectures are not supported. It is possible to build QEMU on an
>   unsupported host architecture using the configure ``--enable-tcg-interpreter``
> -option to enable the experimental TCI support, but note that this is very slow
> -and is not recommended.
> +option to enable the TCI support, but note that this is very slow and is not
> +recommended.

This could be possible for sysemu, I suppose, but not for user-only.  We require 
host-specific support for signal handling, at minimum.


r~